135123 2014-07-21 11:42:46 -0700 [CMake] Source/ThirdParty/ANGLE/include/ directory not listed in WebKit2_INCLUDE_DIRECTORIES 2014-07-22 11:31:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zan zan bunhere cdumez commit-queue gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 1023731 0 zan 2014-07-21 11:42:46 -0700 [CMake] Source/ThirdParty/ANGLE/include/ directory not listed in WebKit2_INCLUDE_DIRECTORIES 1023733 1 235233 zan 2014-07-21 11:45:16 -0700 Created attachment 235233 Patch 1023737 2 235233 mrobinson 2014-07-21 11:52:04 -0700 Comment on attachment 235233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235233&action=review > Source/WebKit2/ChangeLog:9 > + * CMakeLists.txt: List the ANGLE/include/ directory in WebKit2_INCLUDE_DIRECTORIES. Spotted > + missing when LayerTreeHostGtk was caught including system-provided OpenGLES2 and EGL headers. I think this is correct actually. We don't use the ANGLE implementation of OpenGL or EGL. 1023808 3 235233 darin 2014-07-21 17:00:41 -0700 Comment on attachment 235233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235233&action=review >> Source/WebKit2/ChangeLog:9 >> + missing when LayerTreeHostGtk was caught including system-provided OpenGLES2 and EGL headers. > > I think this is correct actually. We don't use the ANGLE implementation of OpenGL or EGL. Martin, is there a reason you didn’t do a review- when you added this comment? 1023812 4 mrobinson 2014-07-21 17:05:59 -0700 Yes. I'm fairly certain that we do not want the ANGLE headers to override the system ones, but Zan has been working closer with this issue than me. I didn't want to flip the flag outright since he might have some reason I had not thought of for this behavior. 1023814 5 235233 mrobinson 2014-07-21 17:06:28 -0700 Comment on attachment 235233 Patch That said, I'm almost certain if we use the system OpenGL at runtime we want to compile against the system OpenGL headers. 1024008 6 zan 2014-07-22 11:31:35 -0700 The WebCore_INCLUDE_DIRECTORIES list includes this directory, so this patch tried to do the same for WebKit2_INCLUDE_DIRECTORIES. But I agree with Martin that we should be using the system's headers. 235233 2014-07-21 11:45:16 -0700 2014-07-21 17:06:27 -0700 Patch bug-135123-20140721114500.patch text/plain 1251 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTMwOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA3LTIxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIFNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvIGRpcmVjdG9yeSBub3QgbGlzdGVkIGluIFdlYktpdDJf SU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogTGlzdCB0aGUgQU5HTEUvaW5jbHVkZS8gZGly ZWN0b3J5IGluIFdlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFUy4gU3BvdHRlZAorICAgICAgICBt aXNzaW5nIHdoZW4gTGF5ZXJUcmVlSG9zdEd0ayB3YXMgY2F1Z2h0IGluY2x1ZGluZyBzeXN0ZW0t cHJvdmlkZWQgT3BlbkdMRVMyIGFuZCBFR0wgaGVhZGVycy4KKwogMjAxNC0wNy0yMSAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRGF0YWJhc2VQcm9jZXNzIGRv ZXNuJ3QgcmVsYXVuY2ggYWZ0ZXIgY3Jhc2hpbmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DTWFr ZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAko cmV2aXNpb24gMTcxMzA3KQorKysgU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQJKHdvcmtp bmcgY29weSkKQEAgLTEzOSw2ICsxMzksNyBAQCBzZXQoV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9S SUVTCiAKIGlmIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgIGxpc3QoQVBQRU5EIFdlYktpdDJf SU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvaW5j bHVkZSIKICAgICAgICAgIiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvS0hSIgogICAg ICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvaW5jbHVkZS9HTFNMQU5HIgogICAgICkK