135117 2014-07-21 09:40:06 -0700 DatabaseProcess doesn't relaunch after crashing 2014-07-21 18:16:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 1023682 0 beidson 2014-07-21 09:40:06 -0700 DatabaseProcess doesn't relaunch after crashing It needs to tell its WebContext when it crashes. <rdar://problem/17717343> 1023684 1 235222 beidson 2014-07-21 09:45:19 -0700 Created attachment 235222 Patch v1 1023692 2 235222 ap 2014-07-21 10:10:05 -0700 Comment on attachment 235222 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > Source/WebKit2/UIProcess/WebContext.cpp:499 > + WebContextSupplementMap::const_iterator it = m_supplements.begin(); > + WebContextSupplementMap::const_iterator end = m_supplements.end(); > + for (; it != end; ++it) We can't have a C++11 loop here, can we? 1023694 3 beidson 2014-07-21 10:11:31 -0700 (In reply to comment #2) > (From update of attachment 235222 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > > > Source/WebKit2/UIProcess/WebContext.cpp:499 > > + WebContextSupplementMap::const_iterator it = m_supplements.begin(); > > + WebContextSupplementMap::const_iterator end = m_supplements.end(); > > + for (; it != end; ++it) > > We can't have a C++11 loop here, can we? Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. 1023700 4 beidson 2014-07-21 10:14:46 -0700 http://trac.webkit.org/changeset/171303 1023816 5 235222 darin 2014-07-21 17:08:16 -0700 Comment on attachment 235222 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review >>> Source/WebKit2/UIProcess/WebContext.cpp:499 >>> + for (; it != end; ++it) >> >> We can't have a C++11 loop here, can we? > > Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. It’s especially good if you use values(). 1023853 6 beidson 2014-07-21 18:16:38 -0700 (In reply to comment #5) > (From update of attachment 235222 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > > >>> Source/WebKit2/UIProcess/WebContext.cpp:499 > >>> + for (; it != end; ++it) > >> > >> We can't have a C++11 loop here, can we? > > > > Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. > > It’s especially good if you use values(). That definitely would've been even better than what I landed. 235222 2014-07-21 09:45:19 -0700 2014-07-21 17:08:16 -0700 Patch v1 patch text/plain 4214 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3MDRjYjBlLi5jNTlmMDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTQtMDctMjEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIERhdGFiYXNlUHJvY2VzcyBkb2Vzbid0IHJlbGF1bmNoIGFmdGVyIGNyYXNoaW5nLgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTc3MTczNDM+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvRGF0YWJhc2VzL0RhdGFiYXNlUHJvY2Vzc1By b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RGF0YWJhc2VQcm9jZXNzUHJveHk6OmRpZENsb3Nl KTogVGVsbCB0aGUgV2ViQ29udGV4dC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6ZGF0YWJhc2VQcm9jZXNzQ3Jhc2hl ZCk6IE5vdGlmeSBzdXBwbGVtZW50cywgdGhlbiBjbGVhciB0aGUgRGF0YWJhc2VQcm9jZXNzUHJv eHkgcG9pbnRlci4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYkNvbnRleHRTdXBwbGVtZW50Lmg6CisgICAgICAgIChXZWJLaXQ6Oldl YkNvbnRleHRTdXBwbGVtZW50Ojpwcm9jZXNzRGlkQ2xvc2UpOiBBZGRlZC4gTm8gdXNlcnMgcmln aHQgbm93LCBidXQgdGhlIHBhdGNoIGluIGJ1ZyAxMzUwMzUgd2lsbCBuZWVkIHRoaXMuCisKIDIw MTQtMDctMjAgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAg ICAgRml4IHdhcm5pbmdzIGNhdXNlZCBieSB1bnVzZWQgcGFyYW1ldGVyLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RhdGFiYXNlcy9EYXRhYmFzZVByb2Nlc3NQcm94eS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRGF0YWJhc2VzL0RhdGFiYXNlUHJvY2Vzc1By b3h5LmNwcAppbmRleCBiYjlkNTM0Li4xZDM2NjJhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0RhdGFiYXNlcy9EYXRhYmFzZVByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RhdGFiYXNlcy9EYXRhYmFzZVByb2Nlc3NQcm94eS5jcHAK QEAgLTgwLDYgKzgwLDIyIEBAIHZvaWQgRGF0YWJhc2VQcm9jZXNzUHJveHk6OmdldERhdGFiYXNl UHJvY2Vzc0Nvbm5lY3Rpb24oUGFzc1JlZlB0cjxNZXNzYWdlczo6V2ViCiAKIHZvaWQgRGF0YWJh c2VQcm9jZXNzUHJveHk6OmRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiopCiB7CisgICAgLy8gVGhl IGRhdGFiYXNlIHByb2Nlc3MgbXVzdCBoYXZlIGNyYXNoZWQgb3IgZXhpdGVkLCBzbyBzZW5kIGFu eSBwZW5kaW5nIHN5bmMgcmVwbGllcyB3ZSBtaWdodCBoYXZlLgorICAgIHdoaWxlICghbV9wZW5k aW5nQ29ubmVjdGlvblJlcGxpZXMuaXNFbXB0eSgpKSB7CisgICAgICAgIGF1dG8gcmVwbHkgPSBt X3BlbmRpbmdDb25uZWN0aW9uUmVwbGllcy50YWtlRmlyc3QoKTsKKworI2lmIE9TKERBUldJTikK KyAgICAgICAgcmVwbHktPnNlbmQoSVBDOjpBdHRhY2htZW50KDAsIE1BQ0hfTVNHX1RZUEVfTU9W RV9TRU5EKSk7CisjZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykKKyAgICAgICAgcmVwbHkt PnNlbmQoSVBDOjpBdHRhY2htZW50KCkpOworI2Vsc2UKKyAgICAgICAgbm90SW1wbGVtZW50ZWQo KTsKKyNlbmRpZgorICAgIH0KKworICAgIC8vIFRlbGwgV2ViQ29udGV4dCB0byBmb3JnZXQgYWJv dXQgdGhpcyBkYXRhYmFzZSBwcm9jZXNzLiBUaGlzIG1heSBjYXVzZSB1cyB0byBiZSBkZWxldGVk LgorICAgIG1fd2ViQ29udGV4dC0+ZGF0YWJhc2VQcm9jZXNzQ3Jhc2hlZCh0aGlzKTsKKyAgICAK IH0KIAogdm9pZCBEYXRhYmFzZVByb2Nlc3NQcm94eTo6ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdl KElQQzo6Q29ubmVjdGlvbiosIElQQzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5h bWUsIElQQzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VOYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkNvbnRleHQuY3BwCmluZGV4IGM4N2I2NGIuLjRhNzRkMmMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKQEAgLTQ4OCw2ICs0ODgsMTkgQEAgdm9pZCBXZWJD b250ZXh0OjpnZXREYXRhYmFzZVByb2Nlc3NDb25uZWN0aW9uKFBhc3NSZWZQdHI8TWVzc2FnZXM6 OldlYlByb2Nlc3NQcm8KIAogICAgIG1fZGF0YWJhc2VQcm9jZXNzLT5nZXREYXRhYmFzZVByb2Nl c3NDb25uZWN0aW9uKHJlcGx5KTsKIH0KKwordm9pZCBXZWJDb250ZXh0OjpkYXRhYmFzZVByb2Nl c3NDcmFzaGVkKERhdGFiYXNlUHJvY2Vzc1Byb3h5KiBkYXRhYmFzZVByb2Nlc3NQcm94eSkKK3sK KyAgICBBU1NFUlQobV9kYXRhYmFzZVByb2Nlc3MpOworICAgIEFTU0VSVChkYXRhYmFzZVByb2Nl c3NQcm94eSA9PSBtX2RhdGFiYXNlUHJvY2Vzcy5nZXQoKSk7CisKKyAgICBXZWJDb250ZXh0U3Vw cGxlbWVudE1hcDo6Y29uc3RfaXRlcmF0b3IgaXQgPSBtX3N1cHBsZW1lbnRzLmJlZ2luKCk7Cisg ICAgV2ViQ29udGV4dFN1cHBsZW1lbnRNYXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fc3VwcGxl bWVudHMuZW5kKCk7CisgICAgZm9yICg7IGl0ICE9IGVuZDsgKytpdCkKKyAgICAgICAgaXQtPnZh bHVlLT5wcm9jZXNzRGlkQ2xvc2UoZGF0YWJhc2VQcm9jZXNzUHJveHkpOworCisgICAgbV9kYXRh YmFzZVByb2Nlc3MgPSBudWxscHRyOworfQogI2VuZGlmCiAKIHZvaWQgV2ViQ29udGV4dDo6d2ls bFN0YXJ0VXNpbmdQcml2YXRlQnJvd3NpbmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250 ZXh0LmgKaW5kZXggZDYwZWRlZS4uZjFlMzc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi Q29udGV4dC5oCkBAIC0zMDIsNiArMzAyLDcgQEAgcHVibGljOgogI2lmIEVOQUJMRShEQVRBQkFT RV9QUk9DRVNTKQogICAgIHZvaWQgZW5zdXJlRGF0YWJhc2VQcm9jZXNzKCk7CiAgICAgdm9pZCBn ZXREYXRhYmFzZVByb2Nlc3NDb25uZWN0aW9uKFBhc3NSZWZQdHI8TWVzc2FnZXM6OldlYlByb2Nl c3NQcm94eTo6R2V0RGF0YWJhc2VQcm9jZXNzQ29ubmVjdGlvbjo6RGVsYXllZFJlcGx5Pik7Cisg ICAgdm9pZCBkYXRhYmFzZVByb2Nlc3NDcmFzaGVkKERhdGFiYXNlUHJvY2Vzc1Byb3h5Kik7CiAj ZW5kaWYKIAogI2lmIFBMQVRGT1JNKENPQ09BKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkNvbnRleHRTdXBwbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViQ29udGV4dFN1cHBsZW1lbnQuaAppbmRleCA2OWY4N2U0Li5jZjVhZjBhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dFN1cHBsZW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dFN1cHBsZW1lbnQuaApAQCAtMjgs NiArMjgsNyBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorY2xhc3MgRGF0YWJhc2VQcm9jZXNz UHJveHk7CiBjbGFzcyBOZXR3b3JrUHJvY2Vzc1Byb3h5OwogY2xhc3MgV2ViQ29udGV4dDsKIGNs YXNzIFdlYlByb2Nlc3NQcm94eTsKQEAgLTU1LDYgKzU2LDEwIEBAIHB1YmxpYzoKICAgICB7CiAg ICAgfQogCisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRDbG9zZShEYXRhYmFzZVByb2Nlc3NQ cm94eSopCisgICAgeworICAgIH0KKwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRUZXJtaW5hdGUo V2ViUHJvY2Vzc1Byb3h5KikgY29uc3QKICAgICB7CiAgICAgICAgIHJldHVybiB0cnVlOwo=