135108 2014-07-20 19:43:14 -0700 [iOS] a Paused media session is not active 2014-07-21 08:06:19 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue darin glenn jeremyj-wk jer.noble philipj sergio oldest_to_newest 1023596 0 eric.carlson 2014-07-20 19:43:14 -0700 MediaSessionManager::hasActive should not return true for a session in the Paused state, we should only activate the AudioSession for Playing sessions. 1023597 1 eric.carlson 2014-07-20 19:43:48 -0700 <rdar://problem/17188368> 1023599 2 235200 eric.carlson 2014-07-20 19:57:56 -0700 Created attachment 235200 Proposed patch 1023603 3 darin 2014-07-20 20:40:07 -0700 With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does. 1023670 4 eric.carlson 2014-07-21 08:05:29 -0700 (In reply to comment #3) > With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does. Good point. I renamed MediaSessionManager::hasActive to "activeAudioSessionRequired" to make obvious what the method does. 1023671 5 eric.carlson 2014-07-21 08:06:19 -0700 Committed r171299 - https://trac.webkit.org/r171299 235200 2014-07-20 19:57:56 -0700 2014-07-20 20:39:31 -0700 Proposed patch patch_3.txt text/plain 1564 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTI4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGEgUGF1c2Vk IG1lZGlhIHNlc3Npb24gaXMgbm90IGFjdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWN0aXZhdGluZyB0aGUgc2hhcmVkIEF1ZGlvU2Vzc2lvbiB3 aWxsIHBhdXNlIGF1ZGlvIHBsYXlpbmcgaW4gYW5vdGhlciBhcHBsaWNhdGlvbiwKKyAgICAgICAg c28gb25seSByZXBvcnQgYSBQbGF5aW5nIG1lZGlhIHNlc3Npb25zIGFzIGFjdGl2ZS4KKworICAg ICAgICAqIHBsYXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlcjo6aGFzQWN0aXZlKTogT25seSByZXR1cm4gdHJ1 ZSBmb3IgYSBQbGF5aW5nIHNlc3Npb24uCisKIDIwMTQtMDctMTggIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgSFRNTE1lZGlhRWxlbWVudCBzaG91 bGQgcmVnaXN0ZXJXaXRoRG9jdW1lbnQgb24gaU9TCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAkocmV2aXNpb24g MTcxMjc3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFu YWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxLDcgKzcxLDcgQEAgYm9vbCBNZWRpYVNlc3Np b25NYW5hZ2VyOjpoYXMoTWVkaWFTZXNzaQogYm9vbCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpoYXNB Y3RpdmUoKSBjb25zdAogewogICAgIGZvciAoYXV0byogc2Vzc2lvbiA6IG1fc2Vzc2lvbnMpIHsK LSAgICAgICAgaWYgKHNlc3Npb24tPm1lZGlhVHlwZSgpICE9IE1lZGlhU2Vzc2lvbjo6Tm9uZSAm JiAoc2Vzc2lvbi0+c3RhdGUoKSA9PSBNZWRpYVNlc3Npb246OlN0YXRlOjpQbGF5aW5nIHx8IHNl c3Npb24tPnN0YXRlKCkgPT0gTWVkaWFTZXNzaW9uOjpTdGF0ZTo6UGF1c2VkKSkKKyAgICAgICAg aWYgKHNlc3Npb24tPm1lZGlhVHlwZSgpICE9IE1lZGlhU2Vzc2lvbjo6Tm9uZSAmJiBzZXNzaW9u LT5zdGF0ZSgpID09IE1lZGlhU2Vzc2lvbjo6U3RhdGU6OlBsYXlpbmcpCiAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9CiAgICAgCg==