135103 2014-07-20 10:54:58 -0700 [iOS WK1] Single touch div scrolling in Mobile Safari doesn't work in framesets (breaks Word previews) 2014-07-21 11:27:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1023544 0 simon.fraser 2014-07-20 10:54:58 -0700 [iOS WK1] Single touch div scrolling in Mobile Safari doesn't work in framesets (breaks Word previews) 1023548 1 235188 simon.fraser 2014-07-20 11:04:51 -0700 Created attachment 235188 Patch 1023549 2 simon.fraser 2014-07-20 11:05:23 -0700 <rdar://problem/11830219> 1023559 3 235188 darin 2014-07-20 13:41:00 -0700 Comment on attachment 235188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235188&action=review r=me, not sure if you need to switch to a post-order traversal > Source/WebCore/rendering/RenderLayerCompositor.cpp:474 > + notifySubframesAfterLayerFlush(); > + didFlushLayers(); It seems strange to flush the top frame separately. Also, I think the function should be named for what it does rather than in what circumstance it’s called in. Maybe flushDescendantLayers, except that argues against putting it in there. > Source/WebCore/rendering/RenderLayerCompositor.cpp:500 > + for (Frame* currFrame = frame.tree().firstChild(); currFrame; currFrame = currFrame->tree().traverseNext(&frame)) { I suggest naming this variable subframe or descendant rather than currFrame. Since we want to flush subframes before their parent, this traversal is not the one we want. This is a pre-order traversal, where each frame is visited before its children. I think what we want is a post-order traversal, where children are visited before their parents. Unfortunately, we don’t have a post-order traversal function in FrameTree. It’s not hard to write one. The nextPostOrder function in NodeTraversal.cpp is not a bad model: static Frame* firstDescendantFramePostOrder(Frame& frame) { Frame* descendant = &frame; while (Frame* firstChild = descendant->tree()->firstChild()) descendant = firstChild; return descendant; } static Frame* nextFramePostOrder(Frame* frame) { Frame* next = frame->tree()->nextSibling(); if (!next) return frame->tree()->parent(); return firstDescendantFramePostOrder(*next); } And the loop is a little different: for (Frame* subframe = firstDescendantFramePostOrder(frame); subframe != &frame; subframe = nextFramePostOrder(subframe)) { ... } 1023707 4 simon.fraser 2014-07-21 10:38:04 -0700 The order in which we notify subframes doesn't really matter in this code, and I'd rather not add an O(N^2) post-order frame traversal. 1023723 5 simon.fraser 2014-07-21 11:27:30 -0700 https://trac.webkit.org/r171306 235188 2014-07-20 11:04:51 -0700 2014-07-20 13:41:00 -0700 Patch bug-135103-20140720110435.patch text/plain 4389 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVhODlhYzJjYmZjNDIw MjhkYzI2OTdhZWNmMjY1NDliODg1Zjc2OS4uY2JjMGE3ZDMwMmJiMzIyZWE4ZjdjN2EwY2Q1NWQz NjYyNjk5YTNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA3LTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0sxXSBT aW5nbGUgdG91Y2ggZGl2IHNjcm9sbGluZyBkb2Vzbid0IHdvcmsgaW4gZnJhbWVzZXRzIChicmVh a3MgV29yZCBwcmV2aWV3cykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNTEwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTE4MzAyMTk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjE2NjEx NyBhbGwgbGF5ZXIgZmx1c2hpbmcgc3RhcnRzIG9uIHRoZSByb290IGZyYW1lOyB3ZSBubyBsb25n ZXIgZmx1c2ggbGF5ZXJzCisgICAgICAgIGZvciBlYWNoIGZyYW1lIGR1cmluZyBwYWludGluZy4g SG93ZXZlciwgZmx1c2hpbmcgR3JhcGhpY3NMYXllcnMgY2FuIHNldCBzb21lIHN0YXRlCisgICAg ICAgIG9uIGEgc3ViZnJhbWUgUmVuZGVyTGF5ZXJDb21wb3NpdG9yIHRoYXQgaXMgbm93IG5ldmVy IHByb2Nlc3NlZCwgd2hpY2ggYnJlYWtzIHNjcm9sbAorICAgICAgICBsYXllciByZWdpc3RyYXRp b24uCisgICAgICAgIAorICAgICAgICBGaXggYnkgZG9pbmcgYSB3YWxrIG9mIHRoZSBGcmFtZSB0 cmVlLCBhbmQgY2FsbGluZyBkaWRGbHVzaExheWVycygpIG9uIHN1YmZyYW1lIFJlbmRlckxheWVy Q29tcG9zaXRvcnMKKyAgICAgICAgYmVmb3JlIGNhbGxpbmcgZGlkRmx1c2hMYXllcnMoKSBvbiBz ZWxmLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZsdXNoUGVuZGluZ0xheWVy Q2hhbmdlcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmRpZEZs dXNoTGF5ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6bm90 aWZ5U3ViZnJhbWVzQWZ0ZXJMYXllckZsdXNoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyQ29tcG9zaXRvcjo6ZW5jbG9zaW5nQ29tcG9zaXRvckZsdXNoaW5nTGF5ZXJzKTogRHJpdmUt YnkgbnVsbHB0ci4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmg6 CisKIDIwMTQtMDctMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPUyBXSzJdIHBvc2l0aW9uOmZpeGVkIGluIGlmcmFtZXMgd2l0aCBwcm9ncmFt bWF0aWMgc2Nyb2xsIGNvdWxkIGVuZCB1cCBpbiB0aGUgd3JvbmcgcGxhY2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggYjY2 N2NmN2E2NmJiMTI0YzdjYjE2YmZlODU4Yjg0MjllMzM4ODI3Ny4uN2ViMTE2NDU2ZjZmZGM2ZjRk YjZhNzJmMTA0NmE3MGU2ZjQ2OTRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTQ3MCwxOSArNDcwLDQwIEBAIHZvaWQg UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoYm9vbCBpc0Zs dXNoUm9vdCkKICAgICBBU1NFUlQobV9mbHVzaGluZ0xheWVycyk7CiAgICAgbV9mbHVzaGluZ0xh eWVycyA9IGZhbHNlOwogCi0jaWYgUExBVEZPUk0oSU9TKQotICAgIHVwZGF0ZUN1c3RvbUxheWVy c0FmdGVyRmx1c2goKTsKKyAgICBub3RpZnlTdWJmcmFtZXNBZnRlckxheWVyRmx1c2goKTsKKyAg ICBkaWRGbHVzaExheWVycygpOwogCisjaWYgUExBVEZPUk0oSU9TKQogICAgIENocm9tZUNsaWVu dCogY2xpZW50ID0gdGhpcy0+Y2hyb21lQ2xpZW50KCk7CiAgICAgaWYgKGNsaWVudCAmJiBpc0Zs dXNoUm9vdCkKICAgICAgICAgY2xpZW50LT5kaWRGbHVzaENvbXBvc2l0aW5nTGF5ZXJzKCk7CiAj ZW5kaWYKIAorICAgIHN0YXJ0TGF5ZXJGbHVzaFRpbWVySWZOZWVkZWQoKTsKK30KKwordm9pZCBS ZW5kZXJMYXllckNvbXBvc2l0b3I6OmRpZEZsdXNoTGF5ZXJzKCkKK3sKKyNpZiBQTEFURk9STShJ T1MpCisgICAgdXBkYXRlQ3VzdG9tTGF5ZXJzQWZ0ZXJGbHVzaCgpOworI2VuZGlmCisKICAgICBm b3IgKGF1dG8gaXQgPSBtX3Njcm9sbENvb3JkaW5hdGVkTGF5ZXJzTmVlZGluZ1VwZGF0ZS5iZWdp bigpLCBlbmQgPSBtX3Njcm9sbENvb3JkaW5hdGVkTGF5ZXJzTmVlZGluZ1VwZGF0ZS5lbmQoKTsg aXQgIT0gZW5kOyArK2l0KQogICAgICAgICB1cGRhdGVTY3JvbGxDb29yZGluYXRlZFN0YXR1cygq Kml0KTsKIAogICAgIG1fc2Nyb2xsQ29vcmRpbmF0ZWRMYXllcnNOZWVkaW5nVXBkYXRlLmNsZWFy KCk7Ci0gICAgc3RhcnRMYXllckZsdXNoVGltZXJJZk5lZWRlZCgpOworfQorCit2b2lkIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6bm90aWZ5U3ViZnJhbWVzQWZ0ZXJMYXllckZsdXNoKCkKK3sKKyAg ICBGcmFtZSYgZnJhbWUgPSBtX3JlbmRlclZpZXcuZnJhbWVWaWV3KCkuZnJhbWUoKTsKKyAgICBm b3IgKEZyYW1lKiBjdXJyRnJhbWUgPSBmcmFtZS50cmVlKCkuZmlyc3RDaGlsZCgpOyBjdXJyRnJh bWU7IGN1cnJGcmFtZSA9IGN1cnJGcmFtZS0+dHJlZSgpLnRyYXZlcnNlTmV4dCgmZnJhbWUpKSB7 CisgICAgICAgIFJlbmRlclZpZXcqIHZpZXcgPSBjdXJyRnJhbWUtPmNvbnRlbnRSZW5kZXJlcigp OworICAgICAgICBpZiAoIXZpZXcpCisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICB2 aWV3LT5jb21wb3NpdG9yKCkuZGlkRmx1c2hMYXllcnMoKTsKKyAgICB9CiB9CiAKICNpZiBQTEFU Rk9STShJT1MpCkBAIC02MDAsNyArNjIxLDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6 OmxheWVyVGlsZWRCYWNraW5nVXNhZ2VDaGFuZ2VkKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGcKIFJl bmRlckxheWVyQ29tcG9zaXRvciogUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjplbmNsb3NpbmdDb21w b3NpdG9yRmx1c2hpbmdMYXllcnMoKSBjb25zdAogewogICAgIGZvciAoRnJhbWUqIGZyYW1lID0g Jm1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS5mcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+ dHJlZSgpLnBhcmVudCgpKSB7Ci0gICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvciogY29tcG9z aXRvciA9IGZyYW1lLT5jb250ZW50UmVuZGVyZXIoKSA/ICZmcmFtZS0+Y29udGVudFJlbmRlcmVy KCktPmNvbXBvc2l0b3IoKSA6IDA7CisgICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvciogY29t cG9zaXRvciA9IGZyYW1lLT5jb250ZW50UmVuZGVyZXIoKSA/ICZmcmFtZS0+Y29udGVudFJlbmRl cmVyKCktPmNvbXBvc2l0b3IoKSA6IG51bGxwdHI7CiAgICAgICAgIGlmIChjb21wb3NpdG9yLT5p c0ZsdXNoaW5nTGF5ZXJzKCkpCiAgICAgICAgICAgICByZXR1cm4gY29tcG9zaXRvcjsKICAgICB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgK aW5kZXggZWZkMzJkZjBhYTI1YmYyODM0ZGI0NDU4NjFiZTc0MGYxN2EyZTJjMC4uOTgxN2EyY2Jk YTkxMmNjMTczYjQwZGU2ODhiNWMwNGRkNjczODZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMzgxLDYgKzM4MSw4IEBAIHBy aXZhdGU6CiAgICAgdm9pZCBub3RpZnlJRnJhbWVzT2ZDb21wb3NpdGluZ0NoYW5nZSgpOwogCiAg ICAgYm9vbCBpc0ZsdXNoaW5nTGF5ZXJzKCkgY29uc3QgeyByZXR1cm4gbV9mbHVzaGluZ0xheWVy czsgfQorICAgIHZvaWQgZGlkRmx1c2hMYXllcnMoKTsKKyAgICB2b2lkIG5vdGlmeVN1YmZyYW1l c0FmdGVyTGF5ZXJGbHVzaCgpOwogICAgIAogICAgIFBhZ2UqIHBhZ2UoKSBjb25zdDsKICAgICAK