135083 2014-07-18 21:45:58 -0700 Perf dashboard shouldn't show the full git hash 2016-02-16 13:53:06 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin cdumez dfarler kling rniwa oldest_to_newest 1023430 0 rniwa 2014-07-18 21:45:58 -0700 Right now the perf dashboard shows the entire git hash in the popups and in the panes. We should only show the first 8 characters. 1023431 1 235167 rniwa 2014-07-18 21:47:55 -0700 Created attachment 235167 Fixes the bug 1023432 2 235167 benjamin 2014-07-18 21:53:52 -0700 Comment on attachment 235167 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review > Websites/perf.webkit.org/public/js/helper-classes.js:101 > + formattedCurrentHash = currentRevision.substring(0, 8); formattedCurrentHash = currentRevision[:8] ? > Websites/perf.webkit.org/public/js/helper-classes.js:103 > + labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash; ditto for substring 1023433 3 benjamin 2014-07-18 21:56:59 -0700 (In reply to comment #2) > (From update of attachment 235167 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review > > > Websites/perf.webkit.org/public/js/helper-classes.js:101 > > + formattedCurrentHash = currentRevision.substring(0, 8); > > formattedCurrentHash = currentRevision[:8] ? > > > Websites/perf.webkit.org/public/js/helper-classes.js:103 > > + labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash; > > ditto for substring Never mind :) 1023435 4 rniwa 2014-07-18 21:59:50 -0700 Committed r171258: <http://trac.webkit.org/changeset/171258> 235167 2014-07-18 21:47:55 -0700 2014-07-18 21:53:51 -0700 Fixes the bug bug-135083-20140718214739.patch text/plain 2946 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxMjU3KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE0LTA3LTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkIHNob3VsZG4ndCBzaG93IHRoZSBmdWxsIGdpdCBoYXNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwODMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZXRlY3Qg R2l0L01lcmN1cmlhbCBoYXNoIGJ5IGNoZWNraW5nIHRoZSBsZW5ndGguCisKKyAgICAgICAgSWYg aXQncyBhIGhhc2gsIHVzZSB0aGUgZmlyc3QgOCBjaGFyYWN0ZXJzIGluIHRoZSBsYWJlbAorICAg ICAgICB3aGlsZSByZXRhaW5pbmcgdGhlIGZ1bGwgbGVuZ3RoIHRvIGJlIHVzZWQgaW4gaHlwZXJs aW5rcy4KKworICAgICAgICAqIHB1YmxpYy9qcy9oZWxwZXItY2xhc3Nlcy5qczoKKyAgICAgICAg KC50aGlzLmZvcm1hdHRlZFJldmlzaW9ucyk6CisgICAgICAgIChUZXN0QnVpbGQpOgorCiAyMDE0 LTA1LTI5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBh biBpbnN0cnVjdGlvbiBvbiBob3cgdG8gYmFja3VwIHRoZSBkYXRhYmFzZS4KSW5kZXg6IFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvanMvaGVscGVyLWNsYXNzZXMuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9qcy9oZWxwZXItY2xhc3Nlcy5q cwkocmV2aXNpb24gMTcxMjU3KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9q cy9oZWxwZXItY2xhc3Nlcy5qcwkod29ya2luZyBjb3B5KQpAQCAtODUsMTkgKzg1LDMwIEBAIGZ1 bmN0aW9uIFRlc3RCdWlsZChyZXBvc2l0b3JpZXMsIGJ1aWxkZXIKICAgICAgICAgICAgICAgICBw cmV2aW91c1JldmlzaW9uID0gdW5kZWZpbmVkOwogCiAgICAgICAgICAgICB2YXIgcmV2aXNpb25Q cmVmaXggPSAnJzsKLSAgICAgICAgICAgIHZhciByZXZpc2lvbkRlbGltaXRvciA9ICctJzsKKyAg ICAgICAgICAgIHZhciByZXZpc2lvbkRlbGltaXRlciA9ICctJzsKKyAgICAgICAgICAgIHZhciBp c0hhc2ggPSBmYWxzZTsKICAgICAgICAgICAgIGlmIChwYXJzZUludChjdXJyZW50UmV2aXNpb24p ID09IGN1cnJlbnRSZXZpc2lvbikgeyAvLyBlLmcuIHIxMjM0NS4KICAgICAgICAgICAgICAgICBy ZXZpc2lvblByZWZpeCA9ICdyJzsKICAgICAgICAgICAgICAgICBpZiAocHJldmlvdXNSZXZpc2lv bikKICAgICAgICAgICAgICAgICAgICAgcHJldmlvdXNSZXZpc2lvbiA9IChwYXJzZUludChwcmV2 aW91c1JldmlzaW9uKSArIDEpOwogICAgICAgICAgICAgfSBlbHNlIGlmIChjdXJyZW50UmV2aXNp b24uaW5kZXhPZignICcpID49IDApIC8vIGUuZy4gMTAuOSAxM0M2NC4KLSAgICAgICAgICAgICAg ICByZXZpc2lvbkRlbGltaXRvciA9ICcgLSAnOworICAgICAgICAgICAgICAgIHJldmlzaW9uRGVs aW1pdGVyID0gJyAtICc7CisgICAgICAgICAgICBlbHNlIGlmIChjdXJyZW50UmV2aXNpb24ubGVu Z3RoID09IDQwKSAvLyBlLmcuIGdpdCBoYXNoCisgICAgICAgICAgICAgICAgaXNIYXNoID0gdHJ1 ZTsKIAogICAgICAgICAgICAgdmFyIGxhYmVsRm9yVGhpc1JlcG9zaXRvcnk7Ci0gICAgICAgICAg ICBpZiAocHJldmlvdXNSZXZpc2lvbikKLSAgICAgICAgICAgICAgICBsYWJlbEZvclRoaXNSZXBv c2l0b3J5ID0gcmV2aXNpb25QcmVmaXggKyBwcmV2aW91c1JldmlzaW9uICsgcmV2aXNpb25EZWxp bWl0b3IgKyByZXZpc2lvblByZWZpeCArIGN1cnJlbnRSZXZpc2lvbjsKLSAgICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgICAgICBsYWJlbEZvclRoaXNSZXBvc2l0b3J5ID0gJ0AgJyArIHJldmlz aW9uUHJlZml4ICsgY3VycmVudFJldmlzaW9uOworICAgICAgICAgICAgaWYgKGlzSGFzaCkgewor ICAgICAgICAgICAgICAgIGZvcm1hdHRlZEN1cnJlbnRIYXNoID0gY3VycmVudFJldmlzaW9uLnN1 YnN0cmluZygwLCA4KTsKKyAgICAgICAgICAgICAgICBpZiAocHJldmlvdXNSZXZpc2lvbikKKyAg ICAgICAgICAgICAgICAgICAgbGFiZWxGb3JUaGlzUmVwb3NpdG9yeSA9IHByZXZpb3VzUmV2aXNp b24uc3Vic3RyaW5nKDAsIDgpICsgJy4uJyArIGZvcm1hdHRlZEN1cnJlbnRIYXNoOworICAgICAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgbGFiZWxGb3JUaGlzUmVwb3NpdG9y eSA9ICdAICcgKyBmb3JtYXR0ZWRDdXJyZW50SGFzaDsKKyAgICAgICAgICAgIH0gZWxzZSB7Cisg ICAgICAgICAgICAgICAgaWYgKHByZXZpb3VzUmV2aXNpb24pCisgICAgICAgICAgICAgICAgICAg IGxhYmVsRm9yVGhpc1JlcG9zaXRvcnkgPSByZXZpc2lvblByZWZpeCArIHByZXZpb3VzUmV2aXNp b24gKyByZXZpc2lvbkRlbGltaXRlciArIHJldmlzaW9uUHJlZml4ICsgY3VycmVudFJldmlzaW9u OworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgbGFiZWxGb3JUaGlz UmVwb3NpdG9yeSA9ICdAICcgKyByZXZpc2lvblByZWZpeCArIGN1cnJlbnRSZXZpc2lvbjsKKyAg ICAgICAgICAgIH0KIAogICAgICAgICAgICAgdmFyIHVybDsKICAgICAgICAgICAgIHZhciByZXBv c2l0b3J5ID0gcmVwb3NpdG9yaWVzW3JlcG9zaXRvcnlOYW1lXTsK