135081 2014-07-18 19:03:47 -0700 [iOS] ignore requests to set volume 2014-07-20 09:46:51 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio oldest_to_newest 1023424 0 eric.carlson 2014-07-18 19:03:47 -0700 The iOS media player should ignore requests to change volume. 1023425 1 235164 eric.carlson 2014-07-18 19:09:52 -0700 Created attachment 235164 Proposed patch 1023437 2 235164 commit-queue 2014-07-18 22:26:08 -0700 Comment on attachment 235164 Proposed patch Clearing flags on attachment: 235164 Committed r171259: <http://trac.webkit.org/changeset/171259> 1023438 3 commit-queue 2014-07-18 22:26:11 -0700 All reviewed patches have been landed. Closing bug. 1023497 4 235164 darin 2014-07-19 22:38:21 -0700 Comment on attachment 235164 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113 > +#if PLATFORM(IOS) > + return; > +#endif This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this. 1023530 5 eric.carlson 2014-07-20 09:46:51 -0700 (In reply to comment #4) > (From update of attachment 235164 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113 > > +#if PLATFORM(IOS) > > + return; > > +#endif > > This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this. Good point. Fixed in r171279: http://trac.webkit.org/changeset/171279 235164 2014-07-18 19:09:52 -0700 2014-07-19 22:38:21 -0700 Proposed patch patch_1.txt text/plain 1323 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTI1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA3LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGlnbm9yZSBy ZXF1ZXN0cyB0byBzZXQgdm9sdW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzUwODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpzZXRWb2x1bWUpOiBEbyBub3RoaW5nIG9u IGlPUy4KKwogMjAxNC0wNy0xOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgW2lPU10gVGFwcGluZyAiQWxsb3cgV2Vic2l0ZSIgb24gYSByZXN0cmljdGVkIHBhZ2Ug ZG9lcyBub3QgYnJpbmcgdXAgdGhlIGtleXBhZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1t CShyZXZpc2lvbiAxNzExMTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTA4LDYgKzExMDgsMTAgQEAgdm9pZCBNZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDOgogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6OnNldFZvbHVtZShmbG9hdCB2b2x1bWUpCiB7CisjaWYgUExBVEZPUk0oSU9TKQorICAg IHJldHVybjsKKyNlbmRpZgorCiAgICAgaWYgKCFtZXRhRGF0YUF2YWlsYWJsZSgpKQogICAgICAg ICByZXR1cm47CiAK