135079 2014-07-18 17:27:53 -0700 We don't provide an extension to the temp file used for uploads 2014-07-21 10:34:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ap oldest_to_newest 1023403 0 oliver 2014-07-18 17:27:53 -0700 We don't provide an extension to the temp file used for uploads 1023404 1 235158 oliver 2014-07-18 17:29:19 -0700 Created attachment 235158 Patch 1023468 2 235158 ap 2014-07-19 10:33:37 -0700 Comment on attachment 235158 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235158&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3780 > + // FIXME: The sandbox extensions should be sent with the DidChooseFilesForOpenPanel message. This > + // is gated on a way of passing SandboxExtension::Handles in a Vector. We have that, SandboxExtension::HandleArray. 1023469 3 235158 ap 2014-07-19 10:34:23 -0700 Comment on attachment 235158 Patch I think that we should use the HandleArray. 1023475 4 oliver 2014-07-19 13:17:03 -0700 (In reply to comment #3) > (From update of attachment 235158 [details]) > I think that we should use the HandleArray. This is a duplicate of the same code path that is used for DidChooseFilesForOpenPanel, this function is simply IOS specific. The core bug here is that both messages don't pass the extensions explicitly, and that should be fixed separately 1023483 5 ap 2014-07-19 14:35:00 -0700 Why should it be fixed separately? The fix should be straightforward, even simpler than the workaround that you are suggesting here. 1023512 6 oliver 2014-07-20 00:09:26 -0700 (In reply to comment #5) > Why should it be fixed separately? The fix should be straightforward, even simpler than the workaround that you are suggesting here. This code is a duplicate of the code below it, which is already well tested. The only difference is that this "new" code is in an iOS only code path that does not have this piece of logic. The "simpler" implementation requires changing the idl, and multiple methods to do a new and untested thing. 1023690 7 oliver 2014-07-21 10:09:39 -0700 Committed r171257: <http://trac.webkit.org/changeset/171257> 1023703 8 ap 2014-07-21 10:30:54 -0700 Seriously, committed an r-'ed patch? 1023706 9 ap 2014-07-21 10:34:14 -0700 Oliver pointed out that this was committed before r-; it's just the comment that was posted now. 235158 2014-07-18 17:29:19 -0700 2014-07-19 10:34:22 -0700 Patch bug-135079-20140718172903.patch text/plain 2118 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGQxMjliOWVhMmYwNzNm YWU3MmVjZWE4NGVjZWI2YjkxZmRkYWQ0NS4uZjliYjY3ZDgyZTUxZDk1M2I5NTBhZWFhNWJiNDY1 OWJlYjc5ZTVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTE4ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgV2UgZG9uJ3QgcHJvdmlkZSBh biBleHRlbnNpb24gdG8gdGhlIHRlbXAgZmlsZSB1c2VkIGZvciB1cGxvYWRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwNzkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgZGlkQ2hvb3Nl RmlsZXNGb3JPcGVuUGFuZWxXaXRoRGlzcGxheVN0cmluZ0FuZEljb24gdmVuZHMKKyAgICAgICAg ZXh0ZW5zaW9ucyBmb3IgdGhlIGZpbGVzIHBhc3NlZCB0byB0aGUgY29udGVudCBwcm9jZXNzLgor CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6ZGlkQ2hvb3NlRmlsZXNGb3JPcGVuUGFuZWxXaXRoRGlzcGxheVN0cmlu Z0FuZEljb24pOgorCiAyMDE0LTA3LTE4ICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogQ3Jhc2ggd2hlbiB0eXBpbmcgaW50byB0ZXh0 IGZpZWxkIHRoYXQgY2xlYXJzIGl0c2VsZiBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYWM5ZTcwZDljNTM0ZTQ1ZjQ5OTczNjA5ZTBhYjNkMWEy NzQ0MWU4Yy4uOTYyZGEzNzViNmJiY2E0MGQ0MDk3Y2YyZTU0ZTYyY2NlYTRiN2Y5NyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTM3NzUsNiArMzc3NSwx NiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkQ2hvb3NlRmlsZXNGb3JPcGVuUGFuZWxXaXRoRGlz cGxheVN0cmluZ0FuZEljb24oY29uc3QgVmVjdAogICAgIGlmICghaXNWYWxpZCgpKQogICAgICAg ICByZXR1cm47CiAKKyNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKQorICAgIC8vIEZJWE1F OiBUaGUgc2FuZGJveCBleHRlbnNpb25zIHNob3VsZCBiZSBzZW50IHdpdGggdGhlIERpZENob29z ZUZpbGVzRm9yT3BlblBhbmVsIG1lc3NhZ2UuIFRoaXMKKyAgICAvLyBpcyBnYXRlZCBvbiBhIHdh eSBvZiBwYXNzaW5nIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZXMgaW4gYSBWZWN0b3IuCisgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBmaWxlVVJMcy5zaXplKCk7ICsraSkgeworICAgICAgICBT YW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUgc2FuZGJveEV4dGVuc2lvbkhhbmRsZTsKKyAgICAgICAg U2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGZpbGVVUkxzW2ldLCBTYW5kYm94RXh0ZW5z aW9uOjpSZWFkT25seSwgc2FuZGJveEV4dGVuc2lvbkhhbmRsZSk7CisgICAgICAgIG1fcHJvY2Vz cy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6RXh0ZW5kU2FuZGJveEZvckZpbGVGcm9tT3BlblBh bmVsKHNhbmRib3hFeHRlbnNpb25IYW5kbGUpLCBtX3BhZ2VJRCk7CisgICAgfQorI2VuZGlmCisK ICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkRpZENob29zZUZpbGVzRm9y T3BlblBhbmVsV2l0aERpc3BsYXlTdHJpbmdBbmRJY29uKGZpbGVVUkxzLCBkaXNwbGF5U3RyaW5n LCBpY29uRGF0YSA/IGljb25EYXRhLT5kYXRhUmVmZXJlbmNlKCkgOiBJUEM6OkRhdGFSZWZlcmVu Y2UoKSksIG1fcGFnZUlEKTsKIAogICAgIG1fb3BlblBhbmVsUmVzdWx0TGlzdGVuZXItPmludmFs aWRhdGUoKTsK