135077 2014-07-18 16:04:35 -0700 _WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute. 2014-07-18 18:32:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca ap commit-queue mitz sam oldest_to_newest 1023379 0 yongjun_zhang 2014-07-18 16:04:35 -0700 Often, a link might not have title attribute. In that case, we should use the link element's innerText as a fallback. 1023382 1 yongjun_zhang 2014-07-18 16:06:12 -0700 <rdar://17373799> 1023383 2 235155 yongjun_zhang 2014-07-18 16:12:38 -0700 Created attachment 235155 Fallback to link element's innerHTML if its title attribute is empty. 1023384 3 yongjun_zhang 2014-07-18 16:13:56 -0700 (In reply to comment #2) > Created an attachment (id=235155) [details] > Fallback to link element's innerHTML if its title attribute is empty. typo, it should be innerText. 1023390 4 235155 mitz 2014-07-18 16:41:16 -0700 Comment on attachment 235155 Fallback to link element's innerHTML if its title attribute is empty. View in context: https://bugs.webkit.org/attachment.cgi?id=235155&action=review > Source/WebKit2/ChangeLog:6 > + When populate InteractionInformationAtPosition's title value, use a link element's innerText if it typo: populate->populating 1023400 5 235155 commit-queue 2014-07-18 17:22:19 -0700 Comment on attachment 235155 Fallback to link element's innerHTML if its title attribute is empty. Clearing flags on attachment: 235155 Committed r171253: <http://trac.webkit.org/changeset/171253> 1023401 6 commit-queue 2014-07-18 17:22:22 -0700 All reviewed patches have been landed. Closing bug. 1023420 7 ap 2014-07-18 18:27:45 -0700 Isn't this kind of business logic something that should be in the client? WebKit's job is to provide all the necessary information, not to lie about what the title is. 1023421 8 mitz 2014-07-18 18:32:13 -0700 (In reply to comment #7) > Isn't this kind of business logic something that should be in the client? WebKit's job is to provide all the necessary information, not to lie about what the title is. WebKit uses the title internally for its built-in Add to Reading List action. I do think we’ll need to review _WKActivatedElementInfo’s properties and their names if we make it a public class. 235155 2014-07-18 16:12:38 -0700 2014-07-18 17:22:19 -0700 Fallback to link element's innerHTML if its title attribute is empty. title_link.patch text/plain 1696 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTI0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTE4ICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgX1dLQWN0aXZhdGVk RWxlbWVudEluZm8udGl0bGUgc2hvdWxkIGZhbGxiYWNrIHRvIGlubmVyVGV4dCBpZiB0aGUgbGlu ayBkb2Vzbid0IGhhdmUgdGl0bGUgYXR0cmlidXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MDc3CisKKyAgICAgICAgV2hlbiBwb3B1bGF0ZSBJ bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbidzIHRpdGxlIHZhbHVlLCB1c2UgYSBsaW5r IGVsZW1lbnQncyBpbm5lclRleHQgaWYgaXQKKyAgICAgICAgZG9lc24ndCBoYXZlIHRpdGxlIGF0 dHJpYnV0ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6CisKIDIwMTQtMDctMTggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFVzZSBS ZXRhaW5QdHIgaW4gX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZpc2lv biAxNzEyNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBh Z2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4NjQsNiArMTg2NCw4IEBAIHZvaWQgV2ViUGFn ZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbihjb24KICAgICAgICAgICAgIGlmIChsaW5rRWxlbWVu dCkKICAgICAgICAgICAgICAgICBpbmZvLnVybCA9IFsoTlNVUkwgKilsaW5rRWxlbWVudC0+ZG9j dW1lbnQoKS5jb21wbGV0ZVVSTChzdHJpcExlYWRpbmdBbmRUcmFpbGluZ0hUTUxTcGFjZXMobGlu a0VsZW1lbnQtPmdldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmhyZWZBdHRyKSkpIGFic29sdXRlU3Ry aW5nXTsKICAgICAgICAgICAgIGluZm8udGl0bGUgPSBlbGVtZW50LT5mYXN0R2V0QXR0cmlidXRl KEhUTUxOYW1lczo6dGl0bGVBdHRyKS5zdHJpbmcoKTsKKyAgICAgICAgICAgIGlmIChsaW5rRWxl bWVudCAmJiBpbmZvLnRpdGxlLmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICBpbmZvLnRpdGxl ID0gZWxlbWVudC0+aW5uZXJUZXh0KCk7CiAgICAgICAgICAgICBpZiAoZWxlbWVudC0+cmVuZGVy ZXIoKSkKICAgICAgICAgICAgICAgICBpbmZvLmJvdW5kcyA9IGVsZW1lbnQtPnJlbmRlcmVyKCkt PmFic29sdXRlQm91bmRpbmdCb3hSZWN0KHRydWUpOwogICAgICAgICB9Cg==