135065 2014-07-18 13:26:05 -0700 [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset 2014-07-24 16:29:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 mcatanzaro webkit-unassigned cgarcia commit-queue mrobinson oldest_to_newest 1023335 0 mcatanzaro 2014-07-18 13:26:05 -0700 Looks like jhbuild-wrapper assumes that jhbuild sets ACLOCAL_FLAGS, but newer versions of jhbuild don't do this anymore. $ Tools/Scripts/build-webkit --gtk --cmakeargs="-DCMAKE_PREFIX_PATH=/home/mcatanzaro/jhbuild/install" which: no ninja in (/home/mcatanzaro/jhbuild/install/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mcatanzaro/.local/bin:/home/mcatanzaro/bin) which: no eclipse in (/home/mcatanzaro/jhbuild/install/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mcatanzaro/.local/bin:/home/mcatanzaro/bin) Traceback (most recent call last): File "/home/mcatanzaro/WebKit/Tools/jhbuild/jhbuild-wrapper", line 117, in <module> del os.environ['ACLOCAL_FLAGS'] File "/usr/lib64/python2.7/os.py", line 496, in __delitem__ del self.data[key] KeyError: 'ACLOCAL_FLAGS' 1023343 1 235144 mcatanzaro 2014-07-18 13:32:47 -0700 Created attachment 235144 Patch 1024660 2 235144 commit-queue 2014-07-24 16:29:23 -0700 Comment on attachment 235144 Patch Clearing flags on attachment: 235144 Committed r171552: <http://trac.webkit.org/changeset/171552> 1024661 3 commit-queue 2014-07-24 16:29:26 -0700 All reviewed patches have been landed. Closing bug. 235144 2014-07-18 13:32:47 -0700 2014-07-24 16:29:23 -0700 Patch bug-135065-20140718153231.patch text/plain 1325 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMjM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjNjYTA4MzVkOTM4YzAwM2I4NzNiNzE1ZTMxOWExY2My YWFmNTkxMC4uOTczNjM4NGNiNWQzN2UzY2ExOGU3MzA3NTA2YTFmMjQyMzU4MDg1NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA3LTE4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBidWlsZC13ZWJraXQgc2NyaXB0IGZhaWxzIHVuZGVyIGpoYnVp bGQgaWYgQUNMT0NBTF9GTEFHUyBpcyB1bnNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBqaGJ1aWxkL2poYnVpbGQtd3JhcHBlcjoKKyAgICAgICAg KGVuc3VyZV9qaGJ1aWxkKTogZG8gbm90IGFzc3VtZSBqaGJ1aWxkIHNldHMgQUNMT0NBTF9GTEFH UworCiAyMDE0LTA3LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAg ICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgc2hvdWxkIGJlIGFibGUgdG8gcnVuIGhlbHBlci1iYXNl ZCB0ZXN0cyBpbiByZW1vdGUgbW9kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9qaGJ1aWxk LXdyYXBwZXIgYi9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBlcgppbmRleCA3Nzc4MGI5MWE2 MWYwODRmYWYwYTQ3ZmJiYzU4YjVkOGI2NjZmODM1Li5iZjIyN2RmMmZhYTYyY2M3MDRiZWFiM2Nm MjUyYmJmMzk1NTE3MjUyIDEwMDc1NQotLS0gYS9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBl cgorKysgYi9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBlcgpAQCAtMTEzLDcgKzExMyw3IEBA IGRlZiBlbnN1cmVfamhidWlsZChwbGF0Zm9ybSk6CiAKICMgV29yay1hcm91bmQgdGhlIGZhY3Qg dGhhdCB3ZSBtYXkgZ2V0IGNhbGxlZCBmcm9tIGluc2lkZSB0aGUgamhidWlsZCBlbnZpcm9ubWVu dAogIyB3aGljaCB3aWxsIGNhdXNlIHByb2JsZW1zIGlmIHdlIGp1c3QgY2xlYW5lZCB0aGUgamhi dWlsZCBpbnN0YWxsIHJvb3QKLWlmIG9zLmVudmlyb24uaGFzX2tleSgnVU5ERVJfSkhCVUlMRCcp OgoraWYgb3MuZW52aXJvbi5oYXNfa2V5KCdVTkRFUl9KSEJVSUxEJykgYW5kIG9zLmVudmlyb24u aGFzX2tleSgnQUNMT0NBTF9GTEFHUycpOgogICAgIGRlbCBvcy5lbnZpcm9uWydBQ0xPQ0FMX0ZM QUdTJ10KIAogdHJ5Ogo=