135062 2014-07-18 12:26:18 -0700 [Cocoa] Use RetainPtr in _WKRemoteObjectInterface 2014-07-18 13:50:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned andersca commit-queue oldest_to_newest 1023314 0 joepeck 2014-07-18 12:26:18 -0700 Use RetainPtr in _WKRemoteObjectInterface instead of manually releasing ivars. 1023315 1 235137 joepeck 2014-07-18 12:27:33 -0700 Created attachment 235137 [PATCH] Proposed Fix 1023353 2 235137 commit-queue 2014-07-18 13:50:31 -0700 Comment on attachment 235137 [PATCH] Proposed Fix Clearing flags on attachment: 235137 Committed r171240: <http://trac.webkit.org/changeset/171240> 1023354 3 commit-queue 2014-07-18 13:50:34 -0700 All reviewed patches have been landed. Closing bug. 235137 2014-07-18 12:27:33 -0700 2014-07-18 13:50:31 -0700 [PATCH] Proposed Fix proposed.patch text/plain 3509 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyMmRlZjkyLi41M2RjOGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDctMTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbQ29jb2FdIFVzZSBSZXRhaW5QdHIgaW4gX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwNjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTd2l0Y2gg dG8gUmV0YWluUHRyIGluc3RlYWQgb2YgbWFudWFsIG1lbW9yeSBtYW5hZ2VtZW50IG9mIGl2YXJz LgorCisgICAgICAgICogU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RJbnRlcmZhY2Uu aDoKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5t bToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlIGluaXRXaXRoUHJvdG9jb2w6 aWRlbnRpZmllcjpdKToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlIGlkZW50 aWZpZXJdKToKKyAgICAgICAgKC1bX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlIGRlc2NyaXB0aW9u XSk6CisgICAgICAgICgtW19XS1JlbW90ZU9iamVjdEludGVyZmFjZSBkZWFsbG9jXSk6IERlbGV0 ZWQuCisKIDIwMTQtMDctMTcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAog ICAgICAgICBbUkVHUkVTU0lPTiBXSzJdVGhlIG1lbnUgYmFyIGRvZXMgbm90IHNob3cgdXAgd2hl biB0YXBwaW5nIG9uIHRoZSBjYXJldC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9BUEkvQ29jb2EvX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5oCmluZGV4IGQ0OWRkNWUu LjNhZjY3YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvX1dL UmVtb3RlT2JqZWN0SW50ZXJmYWNlLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9D b2NvYS9fV0tSZW1vdGVPYmplY3RJbnRlcmZhY2UuaApAQCAtMzYsOCArMzYsOCBAQCBXS19DTEFT U19BVkFJTEFCTEUoMTBfMTAsIDhfMCkKIAogLSAoaWQpaW5pdFdpdGhQcm90b2NvbDooUHJvdG9j b2wgKilwcm90b2NvbCBpZGVudGlmaWVyOihOU1N0cmluZyAqKWlkZW50aWZpZXI7CiAKLUBwcm9w ZXJ0eSAocmVhZG9ubHkpIFByb3RvY29sICpwcm90b2NvbDsKLUBwcm9wZXJ0eSAocmVhZG9ubHkp IE5TU3RyaW5nICppZGVudGlmaWVyOworQHByb3BlcnR5IChyZWFkb25seSwgbm9uYXRvbWljKSBQ cm90b2NvbCAqcHJvdG9jb2w7CitAcHJvcGVydHkgKHJlYWRvbmx5LCBub25hdG9taWMpIE5TU3Ry aW5nICppZGVudGlmaWVyOwogCiAtIChOU1NldCAqKWNsYXNzZXNGb3JTZWxlY3RvcjooU0VMKXNl bGVjdG9yIGFyZ3VtZW50SW5kZXg6KE5TVUludGVnZXIpYXJndW1lbnRJbmRleDsKIC0gKHZvaWQp c2V0Q2xhc3NlczooTlNTZXQgKiljbGFzc2VzIGZvclNlbGVjdG9yOihTRUwpc2VsZWN0b3IgYXJn dW1lbnRJbmRleDooTlNVSW50ZWdlcilhcmd1bWVudEluZGV4OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RJbnRlcmZhY2UubW0gYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5t bQppbmRleCA2NTAzMTcyLi44MzVmMWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdEludGVyZmFjZS5tbQpAQCAtNDIs NiArNDIsNyBAQCBjb25zdCBjaGFyICpfcHJvdG9jb2xfZ2V0TWV0aG9kVHlwZUVuY29kaW5nKFBy b3RvY29sICpwLCBTRUwgc2VsLCBCT09MIGlzUmVxdWlyZQogCiBAaW1wbGVtZW50YXRpb24gX1dL UmVtb3RlT2JqZWN0SW50ZXJmYWNlIHsKICAgICBIYXNoTWFwPFNFTCwgVmVjdG9yPFJldGFpblB0 cjxOU1NldD4+PiBfYWxsb3dlZEFyZ3VtZW50Q2xhc3NlczsKKyAgICBSZXRhaW5QdHI8TlNTdHJp bmc+IF9pZGVudGlmaWVyOwogfQogCiBzdGF0aWMgYm9vbCBpc0NvbnRhaW5lckNsYXNzKENsYXNz IG9iamVjdENsYXNzKQpAQCAtMTI5LDcgKzEzMCw3IEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVB bGxvd2VkQXJndW1lbnRDbGFzc2VzKF9XS1JlbW90ZU9iamVjdEludGVyZmFjZSAqaW50ZXJmYWNl CiAgICAgICAgIHJldHVybiBuaWw7CiAKICAgICBfcHJvdG9jb2wgPSBwcm90b2NvbDsKLSAgICBf aWRlbnRpZmllciA9IFtpZGVudGlmaWVyIGNvcHldOworICAgIF9pZGVudGlmaWVyID0gYWRvcHRO UyhbaWRlbnRpZmllciBjb3B5XSk7CiAKICAgICBpbml0aWFsaXplQWxsb3dlZEFyZ3VtZW50Q2xh c3NlcyhzZWxmKTsKIApAQCAtMTQxLDE1ICsxNDIsMTQgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6 ZUFsbG93ZWRBcmd1bWVudENsYXNzZXMoX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlICppbnRlcmZh Y2UKICAgICByZXR1cm4gW1tbc2VsZiBhbGxvY10gaW5pdFdpdGhQcm90b2NvbDpwcm90b2NvbCBp ZGVudGlmaWVyOk5TU3RyaW5nRnJvbVByb3RvY29sKHByb3RvY29sKV0gYXV0b3JlbGVhc2VdOwog fQogCi0tICh2b2lkKWRlYWxsb2MKKy0gKE5TU3RyaW5nICopaWRlbnRpZmllcgogewotICAgIFtf aWRlbnRpZmllciByZWxlYXNlXTsKLSAgICBbc3VwZXIgZGVhbGxvY107CisgICAgcmV0dXJuIF9p ZGVudGlmaWVyLmdldCgpOwogfQogCiAtIChOU1N0cmluZyAqKWRlc2NyaXB0aW9uCiB7Ci0gICAg cmV0dXJuIFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiPCVAOiAlcDsgcHJvdG9jb2wgPSBc IiVAXCI7IGlkZW50aWZpZXIgPSBcIiVAXCI+IiwgTlNTdHJpbmdGcm9tQ2xhc3Moc2VsZi5jbGFz cyksIHNlbGYsIF9pZGVudGlmaWVyLCBOU1N0cmluZ0Zyb21Qcm90b2NvbChfcHJvdG9jb2wpXTsK KyAgICByZXR1cm4gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCI8JUA6ICVwOyBwcm90b2Nv bCA9IFwiJUBcIjsgaWRlbnRpZmllciA9IFwiJUBcIj4iLCBOU1N0cmluZ0Zyb21DbGFzcyhzZWxm LmNsYXNzKSwgc2VsZiwgX2lkZW50aWZpZXIuZ2V0KCksIE5TU3RyaW5nRnJvbVByb3RvY29sKF9w cm90b2NvbCldOwogfQogCiBzdGF0aWMgUmV0YWluUHRyPE5TU2V0PiYgY2xhc3Nlc0ZvclNlbGVj dG9yQXJndW1lbnQoX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlICppbnRlcmZhY2UsIFNFTCBzZWxl Y3RvciwgTlNVSW50ZWdlciBhcmd1bWVudEluZGV4KQo=