135059 2014-07-18 12:05:56 -0700 Refactor run-jsc-stress-tests VM copying code to remove some abstractions 2014-07-18 15:09:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough clopez ggaren mark.lam mhahnenberg mmirman msaboff oliver sam oldest_to_newest 1023304 0 fpizlo 2014-07-18 12:05:56 -0700 Patch forthcoming. 1023306 1 235135 fpizlo 2014-07-18 12:08:44 -0700 Created attachment 235135 the patch 1023307 2 235135 mark.lam 2014-07-18 12:10:55 -0700 Comment on attachment 235135 the patch r=me 1023308 3 fpizlo 2014-07-18 12:14:13 -0700 Landed in http://trac.webkit.org/changeset/171233 1023362 4 clopez 2014-07-18 14:37:21 -0700 This broke run-jsc-stress-tests on both EFL and GTK: Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>' 1023363 5 fpizlo 2014-07-18 14:47:04 -0700 (In reply to comment #4) > This broke run-jsc-stress-tests on both EFL and GTK: > > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) > from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' > from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>' I see it, fix on the way. 1023366 6 fpizlo 2014-07-18 15:09:02 -0700 (In reply to comment #5) > (In reply to comment #4) > > This broke run-jsc-stress-tests on both EFL and GTK: > > > > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) > > from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' > > from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>' > > I see it, fix on the way. Fixed in http://trac.webkit.org/changeset/171245 235135 2014-07-18 12:08:44 -0700 2014-07-18 12:10:54 -0700 the patch blah.patch text/plain 4212 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MTIzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTA3LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVmYWN0b3IgcnVuLWpzYy1zdHJlc3MtdGVzdHMgVk0gY29weWluZyBjb2RlIHRv IHJlbW92ZSBzb21lIGFic3RyYWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIGlzIG1lYW50IHRvIG1ha2UgaXQgZWFzaWVy IGZvciBtZSB0byBleHRlbmQgdGhlIGNvcHlpbmcgZnVuY3Rpb25hbGl0eSB0byBjb3B5IHRoaW5n cyBvdGhlciB0aGFuCisgICAgICAgIHRoZSBmcmFtZXdvcmsuCisKKyAgICAgICAgKiBTY3JpcHRz L3J1bi1qc2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE0LTA3LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGNsb29wIGJ1aWxkLgpJbmRleDogVG9vbHMvU2Ny aXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1 bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAxNzEyMjgpCisrKyBUb29scy9TY3JpcHRzL3J1 bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzUsNyArMTM1LDcgQEAgZGVm IHVzYWdlCiAgICAgZXhpdCAxCiBlbmQKIAotanNjQXJnID0gIiIKK2pzY0FyZyA9IG5pbAogCiBH ZXRvcHRMb25nLm5ldyhbJy0taGVscCcsICctaCcsIEdldG9wdExvbmc6Ok5PX0FSR1VNRU5UXSwK ICAgICAgICAgICAgICAgIFsnLS1qc2MnLCAnLWonLCBHZXRvcHRMb25nOjpSRVFVSVJFRF9BUkdV TUVOVF0sCkBAIC0xODcsMTIgKzE4NywxNSBAQCBHZXRvcHRMb25nLm5ldyhbJy0taGVscCcsICct aCcsIEdldG9wdExvCiAgICAgZW5kCiB9CiAKLWlmIGpzY0FyZwotICAgIGlmICRjb3B5Ci0gICAg ICAgICRqc2NQYXRoID0gUGF0aG5hbWUubmV3KGpzY0FyZykucmVhbHBhdGgKLSAgICBlbHNlCi0g ICAgICAgICRqc2NQYXRoID0gUGF0aG5hbWUubmV3KGpzY0FyZykKLSAgICBlbmQKK3VubGVzcyBq c2NBcmcKKyAgICAkc3RkZXJyLnB1dHMgIkVycm9yOiBtdXN0IHNwZWNpZnkgLWpzYyA8cGF0aD4i CisgICAgZXhpdCAxCitlbmQKKworaWYgJGNvcHkKKyAgICAkanNjUGF0aCA9IFBhdGhuYW1lLm5l dyhqc2NBcmcpLnJlYWxwYXRoCitlbHNlCisgICAgJGpzY1BhdGggPSBQYXRobmFtZS5uZXcoanNj QXJnKQogZW5kCiAKICRwcm9ncmVzc01ldGVyID0gKCR2ZXJib3NpdHkgPT0gMCBhbmQgJHN0ZG91 dC50dHk/KQpAQCAtMjAyLDExICsyMDUsNiBAQCBpZiAkYnVuZGxlCiAgICAgJG91dHB1dERpciA9 ICRidW5kbGUKIGVuZAogCi11bmxlc3MgJGpzY1BhdGgKLSAgICAkc3RkZXJyLnB1dHMgIkVycm9y OiBtdXN0IHNwZWNpZnkgLWpzYyA8cGF0aD4iCi0gICAgZXhpdCAxCi1lbmQKLQogIyBUcnkgdG8g ZGV0ZXJtaW5lIGFyY2hpdGVjdHVyZS4gUmV0dXJuIG5pbCBvbiBmYWlsdXJlLgogZGVmIG1hY2hP QXJjaGl0ZWN0dXJlQ29kZQogICAgIGJlZ2luIApAQCAtMjgxLDQ2ICsyNzksNiBAQCBkZWYgZnJh bWV3b3JrRnJvbUpTQ1BhdGgoanNjUGF0aCkKICAgICBlbmQKIGVuZAogCi1kZWYgcHJlcGFyZUZy YW1ld29yayhqc2NQYXRoKQotICAgIGZyYW1ld29ya1BhdGggPSBmcmFtZXdvcmtGcm9tSlNDUGF0 aChqc2NQYXRoKQotICAgIGRlc3RpbmF0aW9uRnJhbWV3b3JrUGF0aCA9IFBhdGhuYW1lLm5ldygi LnZtIikgKyAiSmF2YVNjcmlwdENvcmUuZnJhbWV3b3JrIgotICAgICRqc2NQYXRoID0gZGVzdGlu YXRpb25GcmFtZXdvcmtQYXRoICsgIlJlc291cmNlcyIgKyAianNjIgotICAgICR0ZXN0aW5nRnJh bWV3b3JrUGF0aCA9IFBhdGhuYW1lLm5ldygiLi4iKSArIGRlc3RpbmF0aW9uRnJhbWV3b3JrUGF0 aAotCi0gICAgaWYgZnJhbWV3b3JrUGF0aAotICAgICAgICBzb3VyY2UgPSBmcmFtZXdvcmtQYXRo Ci0gICAgICAgIGRlc3RpbmF0aW9uID0gUGF0aG5hbWUubmV3KCIudm0iKQotICAgIGVsc2UKLSAg ICAgICAgc291cmNlID0ganNjUGF0aAotICAgICAgICBkZXN0aW5hdGlvbiA9ICRqc2NQYXRoCi0K LSAgICAgICAgRGlyLmNoZGlyKCRvdXRwdXREaXIpIHsKLSAgICAgICAgICAgIEZpbGVVdGlscy5t a2Rpcl9wICRqc2NQYXRoLmRpcm5hbWUKLSAgICAgICAgfQotICAgIGVuZAotCi0gICAgRGlyLmNo ZGlyKCRvdXRwdXREaXIpIHsKLSAgICAgICAgaWYgJGNvcHlWTQotICAgICAgICAgICAgRmlsZVV0 aWxzLmNwX3Igc291cmNlLCBkZXN0aW5hdGlvbgotICAgICAgICBlbHNlCi0gICAgICAgICAgICBi ZWdpbiAKLSAgICAgICAgICAgICAgICBGaWxlVXRpbHMubG5fcyBzb3VyY2UsIGRlc3RpbmF0aW9u Ci0gICAgICAgICAgICByZXNjdWUKLSAgICAgICAgICAgICAgICBGaWxlVXRpbHMuY3BfciBzb3Vy Y2UsIGRlc3RpbmF0aW9uCi0gICAgICAgICAgICBlbmQKLSAgICAgICAgZW5kCi0gICAgfQotZW5k Ci0KLWRlZiBjb3B5Vk1Ub0J1bmRsZQotICAgIHJhaXNlIGlmICRidW5kbGUKLQotICAgIHZtRGly ID0gJG91dHB1dERpciArICIudm0iCi0gICAgRmlsZVV0aWxzLm1rZGlyX3Agdm1EaXIKLSAgIAot ICAgIHByZXBhcmVGcmFtZXdvcmsoJGpzY1BhdGgpIAotZW5kCi0KIGRlZiBwYXRoVG9WTQogICAg IGRpciA9IFBhdGhuYW1lLm5ldygiLiIpCiAgICAgJGJlbmNobWFya0RpcmVjdG9yeS5lYWNoX2Zp bGVuYW1lIHsKQEAgLTEwNzAsNyArMTAyOCwzNyBAQCBkZWYgcHJlcGFyZUJ1bmRsZQogICAgIHJh aXNlIGlmICRidW5kbGUKIAogICAgIGlmICRjb3B5Ci0gICAgICAgIGNvcHlWTVRvQnVuZGxlCisg ICAgICAgIHZtRGlyID0gJG91dHB1dERpciArICIudm0iCisgICAgICAgIEZpbGVVdGlscy5ta2Rp cl9wIHZtRGlyCisgICAgICAgIAorICAgICAgICBmcmFtZXdvcmtQYXRoID0gZnJhbWV3b3JrRnJv bUpTQ1BhdGgoJGpzY1BhdGgpCisgICAgICAgIGRlc3RpbmF0aW9uRnJhbWV3b3JrUGF0aCA9IFBh dGhuYW1lLm5ldygiLnZtIikgKyAiSmF2YVNjcmlwdENvcmUuZnJhbWV3b3JrIgorICAgICAgICAk anNjUGF0aCA9IGRlc3RpbmF0aW9uRnJhbWV3b3JrUGF0aCArICJSZXNvdXJjZXMiICsgImpzYyIK KyAgICAgICAgJHRlc3RpbmdGcmFtZXdvcmtQYXRoID0gUGF0aG5hbWUubmV3KCIuLiIpICsgZGVz dGluYXRpb25GcmFtZXdvcmtQYXRoCisKKyAgICAgICAgaWYgZnJhbWV3b3JrUGF0aAorICAgICAg ICAgICAgc291cmNlID0gZnJhbWV3b3JrUGF0aAorICAgICAgICAgICAgZGVzdGluYXRpb24gPSBQ YXRobmFtZS5uZXcoIi52bSIpCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHNvdXJjZSA9IGpz Y1BhdGgKKyAgICAgICAgICAgIGRlc3RpbmF0aW9uID0gJGpzY1BhdGgKKworICAgICAgICAgICAg RGlyLmNoZGlyKCRvdXRwdXREaXIpIHsKKyAgICAgICAgICAgICAgICBGaWxlVXRpbHMubWtkaXJf cCAkanNjUGF0aC5kaXJuYW1lCisgICAgICAgICAgICB9CisgICAgICAgIGVuZAorCisgICAgICAg IERpci5jaGRpcigkb3V0cHV0RGlyKSB7CisgICAgICAgICAgICBpZiAkY29weVZNCisgICAgICAg ICAgICAgICAgRmlsZVV0aWxzLmNwX3Igc291cmNlLCBkZXN0aW5hdGlvbgorICAgICAgICAgICAg ZWxzZQorICAgICAgICAgICAgICAgIGJlZ2luIAorICAgICAgICAgICAgICAgICAgICBGaWxlVXRp bHMubG5fcyBzb3VyY2UsIGRlc3RpbmF0aW9uCisgICAgICAgICAgICAgICAgcmVzY3VlCisgICAg ICAgICAgICAgICAgICAgIEZpbGVVdGlscy5jcF9yIHNvdXJjZSwgZGVzdGluYXRpb24KKyAgICAg ICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIGVuZAorICAgICAgICB9CiAgICAgZWxzZQogICAg ICAgICBpZiAhJHJlbW90ZSBhbmQgISR0YXJiYWxsCiAgICAgICAgICAgICAkdGVzdGluZ0ZyYW1l d29ya1BhdGggPSBmcmFtZXdvcmtGcm9tSlNDUGF0aCgkanNjUGF0aCkucmVhbHBhdGgK