13505 2007-04-26 11:06:38 -0700 loses precision on x86_64 2007-04-26 22:32:09 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 0 schamane webkit-unassigned oldest_to_newest 12359 0 schamane 2007-04-26 11:06:38 -0700 ../../platform/graphics/cairo/GraphicsContextCairo.cpp:595: error: cast from ‘void*’ to ‘unsigned int’ loses precision On compiling gdk port on x86_64. 12361 1 14205 schamane 2007-04-26 11:08:04 -0700 Created attachment 14205 graphicscontextcairo-user_data-fix.patch Allocate float for user_set_ and _get_ data for opacity. 12367 2 alp 2007-04-26 11:56:38 -0700 A few thoughts. You should remove the comment about storing the opacity value directly now that this isn't the case. The ASSERT(opacity >= 0 && opacity <= 1) checks are no longer relevant either. Also, we try to use C++ style casts rather than C style. I think you can do direct assignment and leave casting to void* until later, avoiding the memcpy (which has mis-formatted whitespace in your patch). The final patch will need a ChangeLog entry -- see the 'prepare-ChangeLog' script. Thanks 12375 3 14205 mjs 2007-04-26 12:42:24 -0700 Comment on attachment 14205 graphicscontextcairo-user_data-fix.patch It's pretty inefficient to malloc the size of a single float; better to use a separate Vector<float> as a stack in the GraphicsContext. 12387 4 14212 alp 2007-04-26 14:49:19 -0700 Created attachment 14212 Use a stack of opacity values 12213 5 14212 mjs 2007-04-26 22:28:17 -0700 Comment on attachment 14212 Use a stack of opacity values Noce, that's actually less code even. r=me 12201 6 mrowe 2007-04-26 22:32:09 -0700 Landed in r21134. 14205 2007-04-26 11:08:04 -0700 2007-04-26 14:49:19 -0700 graphicscontextcairo-user_data-fix.patch graphicscontextcairo-user_data-fix.patch text/plain 1488 schamane SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fp cm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3Jh cGhpY3NDb250ZXh0Q2Fpcm8uY3BwCShyZXZpc2lvbiAyMTEwMCkKKysrIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01ODEsOCArNTgxLDEwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpiZWdpblRyYW5zcGFy ZW5jeUwKICAgICBjYWlyb19wdXNoX2dyb3VwKGNvbnRleHQpOwogICAgIC8vIFdlIGluc2VydCB0 aGUgb3BhY2l0eSBpbnRvIGEgQ2Fpcm8gc3VyZmFjZSBkYXRhIHNsb3QuCiAgICAgLy8gUmF0aGVy IHRoYW4gcGFzc2luZyBhIHBvaW50ZXIsIHdlIHN0b3JlIHRoZSBvcGFjaXR5IHZhbHVlIGRpcmVj dGx5LgotICAgIHZvaWQqIG9kYXRhID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oc3RhdGljX2Nh c3Q8dW5zaWduZWQgaW50PihvcGFjaXR5ICogVUlOVF9NQVgpKTsKLSAgICBjYWlyb19zdXJmYWNl X3NldF91c2VyX2RhdGEoY2Fpcm9fZ2V0X3RhcmdldChjb250ZXh0KSwgJm1fZGF0YS0+b3BhY2l0 eUtleSwgb2RhdGEsIE5VTEwpOworICAgIHZvaWQgKmZsb2F0X3B0ciA9IG1hbGxvYyhzaXplb2Yo ZmxvYXQpKTsKKyAgICBhc3NlcnQoZmxvYXRfcHRyKTsKKyAgICBtZW1jcHkgKGZsb2F0X3B0ciwg Jm9wYWNpdHksc2l6ZW9mIChmbG9hdCkpOworICAgIGNhaXJvX3N1cmZhY2Vfc2V0X3VzZXJfZGF0 YShjYWlyb19nZXRfdGFyZ2V0KGNvbnRleHQpLCAmbV9kYXRhLT5vcGFjaXR5S2V5LCBmbG9hdF9w dHIsIE5VTEwpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZW5kVHJhbnNwYXJlbmN5TGF5 ZXIoKQpAQCAtNTkxLDggKzU5MywxMCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZW5kVHJhbnNw YXJlbmN5TGF5CiAgICAgICAgIHJldHVybjsKIAogICAgIGNhaXJvX3QqIGNvbnRleHQgPSBtX2Rh dGEtPmNvbnRleHQ7Ci0gICAgdm9pZCogb2RhdGEgPSBjYWlyb19zdXJmYWNlX2dldF91c2VyX2Rh dGEoY2Fpcm9fZ2V0X3RhcmdldChjb250ZXh0KSwgJm1fZGF0YS0+b3BhY2l0eUtleSk7Ci0gICAg ZmxvYXQgb3BhY2l0eSA9IHN0YXRpY19jYXN0PGZsb2F0PihyZWludGVycHJldF9jYXN0PHVuc2ln bmVkIGludD4ob2RhdGEpKSAvIFVJTlRfTUFYOworICAgIAorICAgIGZsb2F0KiBvZGF0YSA9IChm bG9hdCopY2Fpcm9fc3VyZmFjZV9nZXRfdXNlcl9kYXRhKGNhaXJvX2dldF90YXJnZXQoY29udGV4 dCksICZtX2RhdGEtPm9wYWNpdHlLZXkpOworICAgIGZsb2F0IG9wYWNpdHkgPSAqb2RhdGE7Cisg ICAgZnJlZShvZGF0YSk7CiAKICAgICBBU1NFUlQob3BhY2l0eSA+PSAwICYmIG9wYWNpdHkgPD0g MSk7CiAK 14212 2007-04-26 14:49:19 -0700 2007-04-26 22:28:17 -0700 Use a stack of opacity values opacity-stack.patch text/plain 2432 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTEyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDQtMjYgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTA1CisgICAgICAgIGxvc2VzIHByZWNp c2lvbiBvbiB4ODZfNjQKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6 YmVnaW5UcmFuc3BhcmVuY3lMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQ6OmVuZFRyYW5zcGFyZW5jeUxheWVyKToKKyAgICAgICAgVXNlIGEgc3RhY2sgb2Ygb3BhY2l0 eSB2YWx1ZXMgaW5zdGVhZCBvZiBDYWlybyB1c2VyIGRhdGEuCisKIDIwMDctMDQtMjYgIE1pdHog UGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IGh5YXR0Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJv LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcAkocmV2aXNpb24gMjExMjIpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjUsNyArNjUsNyBAQCBwdWJsaWM6CiAgICAgfkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJp dmF0ZSgpOwogCiAgICAgY2Fpcm9fdCogY29udGV4dDsKLSAgICBjYWlyb191c2VyX2RhdGFfa2V5 X3Qgb3BhY2l0eUtleTsKKyAgICBWZWN0b3I8ZmxvYXQ+IGxheWVyczsKIH07CiAKIHN0YXRpYyBp bmxpbmUgdm9pZCBzZXRDb2xvcihjYWlyb190KiBjciwgY29uc3QgQ29sb3ImIGNvbCkKQEAgLTU3 NCwxNSArNTc0LDEwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpiZWdpblRyYW5zcGFyZW5jeUwK ICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBBU1NF UlQob3BhY2l0eSA+PSAwICYmIG9wYWNpdHkgPD0gMSk7Ci0KICAgICBjYWlyb190KiBjb250ZXh0 ID0gbV9kYXRhLT5jb250ZXh0OwogICAgIGNhaXJvX3NhdmUoY29udGV4dCk7CiAgICAgY2Fpcm9f cHVzaF9ncm91cChjb250ZXh0KTsKLSAgICAvLyBXZSBpbnNlcnQgdGhlIG9wYWNpdHkgaW50byBh IENhaXJvIHN1cmZhY2UgZGF0YSBzbG90LgotICAgIC8vIFJhdGhlciB0aGFuIHBhc3NpbmcgYSBw b2ludGVyLCB3ZSBzdG9yZSB0aGUgb3BhY2l0eSB2YWx1ZSBkaXJlY3RseS4KLSAgICB2b2lkKiBv ZGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHN0YXRpY19jYXN0PHVuc2lnbmVkIGludD4o b3BhY2l0eSAqIFVJTlRfTUFYKSk7Ci0gICAgY2Fpcm9fc3VyZmFjZV9zZXRfdXNlcl9kYXRhKGNh aXJvX2dldF90YXJnZXQoY29udGV4dCksICZtX2RhdGEtPm9wYWNpdHlLZXksIG9kYXRhLCBOVUxM KTsKKyAgICBtX2RhdGEtPmxheWVycy5hcHBlbmQob3BhY2l0eSk7CiB9CiAKIHZvaWQgR3JhcGhp Y3NDb250ZXh0OjplbmRUcmFuc3BhcmVuY3lMYXllcigpCkBAIC01OTEsMTMgKzU4NiwxMCBAQCB2 b2lkIEdyYXBoaWNzQ29udGV4dDo6ZW5kVHJhbnNwYXJlbmN5TGF5CiAgICAgICAgIHJldHVybjsK IAogICAgIGNhaXJvX3QqIGNvbnRleHQgPSBtX2RhdGEtPmNvbnRleHQ7Ci0gICAgdm9pZCogb2Rh dGEgPSBjYWlyb19zdXJmYWNlX2dldF91c2VyX2RhdGEoY2Fpcm9fZ2V0X3RhcmdldChjb250ZXh0 KSwgJm1fZGF0YS0+b3BhY2l0eUtleSk7Ci0gICAgZmxvYXQgb3BhY2l0eSA9IHN0YXRpY19jYXN0 PGZsb2F0PihyZWludGVycHJldF9jYXN0PHVuc2lnbmVkIGludD4ob2RhdGEpKSAvIFVJTlRfTUFY OwotCi0gICAgQVNTRVJUKG9wYWNpdHkgPj0gMCAmJiBvcGFjaXR5IDw9IDEpOwogCiAgICAgY2Fp cm9fcG9wX2dyb3VwX3RvX3NvdXJjZShjb250ZXh0KTsKLSAgICBjYWlyb19wYWludF93aXRoX2Fs cGhhKGNvbnRleHQsIG9wYWNpdHkpOworICAgIGNhaXJvX3BhaW50X3dpdGhfYWxwaGEoY29udGV4 dCwgbV9kYXRhLT5sYXllcnMubGFzdCgpKTsKKyAgICBtX2RhdGEtPmxheWVycy5yZW1vdmVMYXN0 KCk7CiAgICAgY2Fpcm9fcmVzdG9yZShjb250ZXh0KTsKIH0KIAo=