135037 2014-07-17 18:25:20 -0700 iOS WK2: visibleBounds should return the unobscured content rect 2014-07-17 19:08:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1023166 0 enrica 2014-07-17 18:25:20 -0700 This is needed to properly clip the position of the menu bar. <rdar://problem/15980307> 1023167 1 235106 enrica 2014-07-17 18:28:09 -0700 Created attachment 235106 Patch 1023177 2 enrica 2014-07-17 18:58:20 -0700 After discussing this with Ben, we agreed that this is not the right thing to do here. 1023178 3 enrica 2014-07-17 18:58:54 -0700 After discussing this with Ben, we agreed that this is not the right thing to do here. 1023182 4 235106 benjamin 2014-07-17 19:08:35 -0700 Comment on attachment 235106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235106&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:365 > +- (CGRect)visibleBounds > +{ > + return [self unobscuredContentRect]; > +} Can you add a comment explaining how "visibleBounds" is used by UIKit? I think the name is quite bad, but we don't have much freedom here since this is part of the UIView's interface. 235106 2014-07-17 18:28:09 -0700 2014-07-17 19:08:35 -0700 Patch clipcallout.txt text/plain 1452 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTIwOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTE3ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIFdLMjogdmlzaWJsZUJv dW5kcyBzaG91bGQgcmV0dXJuIHRoZSB1bm9ic2N1cmVkIGNvbnRlbnQgcmVjdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTAzNworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTU5ODAzMDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgdG8gY2xpcCB0aGUgcG9zaXRpb25pbmcg b2YgdGhlIG1lbnUgYmFyCisgICAgICAgIGluIGVkaXRhYmxlIGZpZWxkcy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IHZpc2libGVCb3VuZHNdKToKKwogMjAxNC0wNy0xNyAgQmVuamFtaW4gUG91 bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXVtXSzJdIEZpeCB0aGUg dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyBzeW5jaHJvbml6YXRpb24gZm9yIGxvYWQgYWZ0ZXIg cjE3MTE1NApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE3MTIwMykKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNTksNiArMzU5LDExIEBAIC0gKENHUmVjdCl1bm9ic2N1cmVkQ29udGVu dFJlY3QKICAgICByZXR1cm4gX3BhZ2UtPnVub2JzY3VyZWRDb250ZW50UmVjdCgpOwogfQogCist IChDR1JlY3QpdmlzaWJsZUJvdW5kcworeworICAgIHJldHVybiBbc2VsZiB1bm9ic2N1cmVkQ29u dGVudFJlY3RdOworfQorCiAtICh2b2lkKW9ic2VydmVWYWx1ZUZvcktleVBhdGg6KE5TU3RyaW5n ICopa2V5UGF0aCBvZk9iamVjdDooaWQpb2JqZWN0IGNoYW5nZTooTlNEaWN0aW9uYXJ5ICopY2hh bmdlIGNvbnRleHQ6KHZvaWQgKiljb250ZXh0CiB7CiAgICAgQVNTRVJUKFtrZXlQYXRoIGlzRXF1 YWxUb1N0cmluZzpAInRyYW5zZm9ybSJdKTsK