13503 2007-04-26 10:51:08 -0700 invalidateContainingBlockPrefWidths is 15% of the nesting PLT (O(n^2)) 2014-04-24 16:44:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 12354 0 hyatt 2007-04-26 10:51:08 -0700 When inlines nest deeply it's better to include them in the dirty chain (like layout does) just so we don't exhibit O(n^2) containingBlock() crawl-up behavior. 12358 1 14204 hyatt 2007-04-26 11:06:04 -0700 Created attachment 14204 Patch to address the problem. Takes this method completely off the profile. 12366 2 hyatt 2007-04-26 11:50:40 -0700 Fixed. 1003832 3 darin 2014-04-24 16:44:52 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 14204 2007-04-26 11:06:04 -0700 2007-04-26 11:48:57 -0700 Patch to address the problem. patch.txt text/plain 3292 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTE0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMDQt MjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBmb3IgYnVn IDEzNTAzLCBpbnZhbGlkYXRlQ29udGFpbmluZ0Jsb2NrUHJlZldpZHRocyBpcyAxNSUgb2YgdGhl CisgICAgICAgIG5lc3RpbmcgUExULiAgQXZvaWQgTyhuXjIpIGJlaGF2aW9yIGJ5IGluY2x1ZGlu ZyBpbmxpbmVzIGluIHRoZSBtaW5tYXgKKyAgICAgICAgZGlydHkgY2hhaW4uCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgPz8/CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmNhbGNJbmxpbmVQcmVmV2lkdGhzKToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck9iamVjdDo6c2V0UHJlZldpZHRoc0RpcnR5KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ck9iamVjdDo6aW52YWxpZGF0ZUNvbnRhaW5lclByZWZXaWR0aHMpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuaDoKKwogMjAwNy0wNC0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvUmVuZGVyQmxv Y2suY3BwCShyZXZpc2lvbiAyMTEwOCkKKysrIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM1MTMsNiArMzUxMyw4IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNhbGNJ bmxpbmVQcmVmV2lkdGhzKCkKIAogICAgICAgICAgICAgICAgICAgICBpbmxpbmVNaW4gKz0gY2hp bGRNaW47CiAgICAgICAgICAgICAgICAgICAgIGlubGluZU1heCArPSBjaGlsZE1heDsKKyAgICAg ICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgICAgIGNoaWxkLT5zZXRQcmVmV2lkdGhz RGlydHkoZmFsc2UpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBlbHNlIHsK ICAgICAgICAgICAgICAgICAgICAgLy8gSW5saW5lIHJlcGxhY2VkIGVsdHMgYWRkIGluIHRoZWly IG1hcmdpbnMgdG8gdGhlaXIgbWluL21heCB2YWx1ZXMuCkluZGV4OiByZW5kZXJpbmcvUmVuZGVy T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2 aXNpb24gMjExMDgpCisrKyByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjYwLDE5ICs2NjAsMjEgQEAgdm9pZCBSZW5kZXJPYmplY3Q6OnNldFByZWZXaWR0aHNE aXJ0eShibwogICAgIGJvb2wgYWxyZWFkeURpcnR5ID0gbV9wcmVmV2lkdGhzRGlydHk7CiAgICAg bV9wcmVmV2lkdGhzRGlydHkgPSBiOwogICAgIGlmIChiICYmICFhbHJlYWR5RGlydHkgJiYgbWFy a1BhcmVudHMgJiYgKHN0eWxlKCktPnBvc2l0aW9uKCkgIT0gRml4ZWRQb3NpdGlvbiAmJiBzdHls ZSgpLT5wb3NpdGlvbigpICE9IEFic29sdXRlUG9zaXRpb24pKQotICAgICAgICBpbnZhbGlkYXRl Q29udGFpbmluZ0Jsb2NrUHJlZldpZHRocygpOworICAgICAgICBpbnZhbGlkYXRlQ29udGFpbmVy UHJlZldpZHRocygpOwogfQogCi12b2lkIFJlbmRlck9iamVjdDo6aW52YWxpZGF0ZUNvbnRhaW5p bmdCbG9ja1ByZWZXaWR0aHMoKQordm9pZCBSZW5kZXJPYmplY3Q6OmludmFsaWRhdGVDb250YWlu ZXJQcmVmV2lkdGhzKCkKIHsKLSAgICBSZW5kZXJPYmplY3QqIG8gPSBjb250YWluaW5nQmxvY2so KTsKKyAgICAvLyBJbiBvcmRlciB0byBhdm9pZCBwYXRob2xvZ2ljYWwgYmVoYXZpb3Igd2hlbiBp bmxpbmVzIGFyZSBkZWVwbHkgbmVzdGVkLCB3ZSBkbyBpbmNsdWRlIHRoZW0KKyAgICAvLyBpbiB0 aGUgY2hhaW4gdGhhdCB3ZSBtYXJrIGRpcnR5IChldmVuIHRob3VnaCB0aGV5J3JlIGtpbmQgb2Yg aXJyZWxldmFudCkuCisgICAgUmVuZGVyT2JqZWN0KiBvID0gaXNUYWJsZUNlbGwoKSA/IGNvbnRh aW5pbmdCbG9jaygpIDogY29udGFpbmVyKCk7CiAgICAgd2hpbGUgKG8gJiYgIW8tPm1fcHJlZldp ZHRoc0RpcnR5KSB7CiAgICAgICAgIG8tPm1fcHJlZldpZHRoc0RpcnR5ID0gdHJ1ZTsKICAgICAg ICAgaWYgKG8tPnN0eWxlKCktPnBvc2l0aW9uKCkgPT0gRml4ZWRQb3NpdGlvbiB8fCBvLT5zdHls ZSgpLT5wb3NpdGlvbigpID09IEFic29sdXRlUG9zaXRpb24pCiAgICAgICAgICAgICAvLyBBIHBv c2l0aW9uZWQgb2JqZWN0IGhhcyBubyBlZmZlY3Qgb24gdGhlIG1pbi9tYXggd2lkdGggb2YgaXRz IGNvbnRhaW5pbmcgYmxvY2sgZXZlci4KICAgICAgICAgICAgIC8vIFdlIGNhbiBvcHRpbWl6ZSB0 aGlzIGNhc2UgYW5kIG5vdCBnbyB1cCBhbnkgZnVydGhlci4KICAgICAgICAgICAgIGJyZWFrOwot ICAgICAgICBvID0gby0+Y29udGFpbmluZ0Jsb2NrKCk7CisgICAgICAgIG8gPSBvLT5pc1RhYmxl Q2VsbCgpID8gby0+Y29udGFpbmluZ0Jsb2NrKCkgOiBvLT5jb250YWluZXIoKTsKICAgICB9CiB9 CiAKSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmgJKHJldmlzaW9uIDIxMTA4KQorKysgcmVuZGVyaW5nL1JlbmRlck9i amVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNzIsNyArMzcyLDcgQEAgcHVibGljOgogICAgIHZv aWQgc2V0Q2hpbGROZWVkc0xheW91dChib29sIGIsIGJvb2wgbWFya1BhcmVudHMgPSB0cnVlKTsK IAogICAgIHZvaWQgc2V0UHJlZldpZHRoc0RpcnR5KGJvb2wsIGJvb2wgbWFya1BhcmVudHMgPSB0 cnVlKTsKLSAgICB2b2lkIGludmFsaWRhdGVDb250YWluaW5nQmxvY2tQcmVmV2lkdGhzKCk7Cisg ICAgdm9pZCBpbnZhbGlkYXRlQ29udGFpbmVyUHJlZldpZHRocygpOwogICAgIAogICAgIHZvaWQg c2V0TmVlZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCkKICAgICB7Cg==