135023 2014-07-17 13:58:02 -0700 [REGRESSION WK2]The menu bar does not show up when tapping on the caret 2014-07-17 15:02:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified NEW InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1023089 0 enrica 2014-07-17 13:58:02 -0700 Tapping on an input field that has focus, should toggle the menu bar. <rdar://problem/17617282> 1023114 1 235093 enrica 2014-07-17 14:44:54 -0700 Created attachment 235093 Patch 1023117 2 235093 benjamin 2014-07-17 15:02:14 -0700 Comment on attachment 235093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235093&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:739 > + VisiblePosition first(createLegacyEditingPosition(root, 0)); > + VisiblePosition last(createLegacyEditingPosition(root, root->childNodeCount())); > + result.hasContent = first != last; This isn't exactly cheap. ContainerNode::childNodeCount() alone can dirty a ton of memory. I would prefer something that fails on the first node instead of going through all of them. 235093 2014-07-17 14:44:54 -0700 2014-07-17 15:02:14 -0700 Patch hasContent.txt text/plain 4754 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTE5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA3LTE3ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1JFR1JFU1NJT04gV0syXVRo ZSBtZW51IGJhciBkb2VzIG5vdCBzaG93IHVwIHdoZW4gdGFwcGluZyBvbiB0aGUgY2FyZXQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwMjMKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3NjE3MjgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdLQ29udGVudFZpZXcgbmVlZHMgdG8gaW1wbGVtZW50 IGhhc0NvbnRlbnQgdG8gY29ycmVjdGx5IHNob3cKKyAgICAgICAgdGhlIGFwcHJvcHJpYXRlIG1l bnUgYmFyIGNvbnRlbnQuIFRoZSBwYXRjaCBhZGRzIHRoaXMgaW5mb3JtYXRpb24KKyAgICAgICAg dG8gdGhlIEVkaXRvclN0YXRlLgorCisgICAgICAgICogU2hhcmVkL0VkaXRvclN0YXRlLmNwcDoK KyAgICAgICAgKFdlYktpdDo6RWRpdG9yU3RhdGU6OmVuY29kZSk6CisgICAgICAgIChXZWJLaXQ6 OkVkaXRvclN0YXRlOjpkZWNvZGUpOgorICAgICAgICAqIFNoYXJlZC9FZGl0b3JTdGF0ZS5oOgor ICAgICAgICAoV2ViS2l0OjpFZGl0b3JTdGF0ZTo6RWRpdG9yU3RhdGUpOgorICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IGhhc0NvbnRlbnRdKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmVkaXRvclN0YXRlKToKKwogMjAx NC0wNy0xNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAg ICBTb21ldGltZXMgcHVyZ2VhYmxlIChvciBlbXB0eSEpIHRpbGVzIGFyZSBzaG93biBvbiBzY3Jl ZW4gd2hlbiByZXN1bWluZyB0aGUgYXBwCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRWRp dG9yU3RhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9FZGl0b3JT dGF0ZS5jcHAJKHJldmlzaW9uIDE3MTE1OCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9FZGl0 b3JTdGF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYgKzQ4LDcgQEAgdm9pZCBFZGl0b3JT dGF0ZTo6ZW5jb2RlKElQQzo6QXJndW1lbnRFbgogCiAjaWYgUExBVEZPUk0oSU9TKQogICAgIGVu Y29kZXIgPDwgaXNSZXBsYWNlQWxsb3dlZDsKKyAgICBlbmNvZGVyIDw8IGhhc0NvbnRlbnQ7CiAg ICAgZW5jb2RlciA8PCBjaGFyYWN0ZXJBZnRlclNlbGVjdGlvbjsKICAgICBlbmNvZGVyIDw8IGNo YXJhY3RlckJlZm9yZVNlbGVjdGlvbjsKICAgICBlbmNvZGVyIDw8IHR3b0NoYXJhY3RlckJlZm9y ZVNlbGVjdGlvbjsKQEAgLTk2LDYgKzk3LDggQEAgYm9vbCBFZGl0b3JTdGF0ZTo6ZGVjb2RlKElQ Qzo6QXJndW1lbnREZQogI2lmIFBMQVRGT1JNKElPUykKICAgICBpZiAoIWRlY29kZXIuZGVjb2Rl KHJlc3VsdC5pc1JlcGxhY2VBbGxvd2VkKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlm ICghZGVjb2Rlci5kZWNvZGUocmVzdWx0Lmhhc0NvbnRlbnQpKQorICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuY2hhcmFjdGVyQWZ0ZXJTZWxlY3Rp b24pKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1 bHQuY2hhcmFjdGVyQmVmb3JlU2VsZWN0aW9uKSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9FZGl0b3JTdGF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9FZGl0 b3JTdGF0ZS5oCShyZXZpc2lvbiAxNzExNTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRWRp dG9yU3RhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsNyBAQCBzdHJ1Y3QgRWRpdG9y U3RhdGUgewogICAgICAgICAsIGhhc0NvbXBvc2l0aW9uKGZhbHNlKQogI2lmIFBMQVRGT1JNKElP UykKICAgICAgICAgLCBpc1JlcGxhY2VBbGxvd2VkKGZhbHNlKQorICAgICAgICAsIGhhc0NvbnRl bnQoZmFsc2UpCiAgICAgICAgICwgY2hhcmFjdGVyQWZ0ZXJTZWxlY3Rpb24oMCkKICAgICAgICAg LCBjaGFyYWN0ZXJCZWZvcmVTZWxlY3Rpb24oMCkKICAgICAgICAgLCB0d29DaGFyYWN0ZXJCZWZv cmVTZWxlY3Rpb24oMCkKQEAgLTc2LDYgKzc3LDcgQEAgc3RydWN0IEVkaXRvclN0YXRlIHsKIAog I2lmIFBMQVRGT1JNKElPUykKICAgICBib29sIGlzUmVwbGFjZUFsbG93ZWQ7CisgICAgYm9vbCBo YXNDb250ZW50OwogICAgIFVDaGFyMzIgY2hhcmFjdGVyQWZ0ZXJTZWxlY3Rpb247CiAgICAgVUNo YXIzMiBjaGFyYWN0ZXJCZWZvcmVTZWxlY3Rpb247CiAgICAgVUNoYXIzMiB0d29DaGFyYWN0ZXJC ZWZvcmVTZWxlY3Rpb247CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTcxMTU5KQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0JKHdvcmtpbmcgY29weSkKQEAgLTI0MzgsNyArMjQzOCw3IEBAIC0gKHZvaWQpc2V0TWFya2Vk VGV4dDooTlNTdHJpbmcgKil0ZXh0CiAKIC0gKEJPT0wpaGFzQ29udGVudAogewotICAgIHJldHVy biBZRVM7CisgICAgcmV0dXJuIF9wYWdlLT5lZGl0b3JTdGF0ZSgpLmhhc0NvbnRlbnQ7CiB9CiAK IC0gKHZvaWQpc2VsZWN0QWxsCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAxNzExNTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczMCw4ICs3 MzAsMTUgQEAgRWRpdG9yU3RhdGUgV2ViUGFnZTo6ZWRpdG9yU3RhdGUoKSBjb25zdAogICAgICAg ICAvLyBGSVhNRTogVGhlIGZvbGxvd2luZyBjaGVjayBzaG91bGQgdGFrZSBpbnRvIGFjY291bnQg d3JpdGluZyBkaXJlY3Rpb24uCiAgICAgICAgIHJlc3VsdC5pc1JlcGxhY2VBbGxvd2VkID0gcmVz dWx0LmlzQ29udGVudEVkaXRhYmxlICYmIGF0Qm91bmRhcnlPZkdyYW51bGFyaXR5KHNlbGVjdGlv bi5zdGFydCgpLCBXb3JkR3JhbnVsYXJpdHksIERpcmVjdGlvbkZvcndhcmQpOwogICAgICAgICBy ZXN1bHQud29yZEF0U2VsZWN0aW9uID0gcGxhaW5UZXh0UmVwbGFjaW5nTm9CcmVha1NwYWNlKHdv cmRSYW5nZUZyb21Qb3NpdGlvbihzZWxlY3Rpb24uc3RhcnQoKSkuZ2V0KCkpOwotICAgICAgICBp ZiAoc2VsZWN0aW9uLmlzQ29udGVudEVkaXRhYmxlKCkpCisgICAgICAgIGlmIChzZWxlY3Rpb24u aXNDb250ZW50RWRpdGFibGUoKSkgewogICAgICAgICAgICAgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0 aW9uKHNlbGVjdGlvbi5zdGFydCgpLCByZXN1bHQuY2hhcmFjdGVyQWZ0ZXJTZWxlY3Rpb24sIHJl c3VsdC5jaGFyYWN0ZXJCZWZvcmVTZWxlY3Rpb24sIHJlc3VsdC50d29DaGFyYWN0ZXJCZWZvcmVT ZWxlY3Rpb24pOworICAgICAgICAgICAgRWxlbWVudCogcm9vdCA9IHNlbGVjdGlvbi5yb290RWRp dGFibGVFbGVtZW50KCk7CisgICAgICAgICAgICBpZiAocm9vdCAmJiByb290LT5oYXNDaGlsZE5v ZGVzKCkpIHsKKyAgICAgICAgICAgICAgICBWaXNpYmxlUG9zaXRpb24gZmlyc3QoY3JlYXRlTGVn YWN5RWRpdGluZ1Bvc2l0aW9uKHJvb3QsIDApKTsKKyAgICAgICAgICAgICAgICBWaXNpYmxlUG9z aXRpb24gbGFzdChjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24ocm9vdCwgcm9vdC0+Y2hpbGRO b2RlQ291bnQoKSkpOworICAgICAgICAgICAgICAgIHJlc3VsdC5oYXNDb250ZW50ID0gZmlyc3Qg IT0gbGFzdDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQogICAgIH0gZWxzZSBpZiAoc2VsZWN0 aW9uLmlzUmFuZ2UoKSkgewogICAgICAgICByZXN1bHQuY2FyZXRSZWN0QXRTdGFydCA9IHZpZXct PmNvbnRlbnRzVG9Sb290VmlldyhWaXNpYmxlUG9zaXRpb24oc2VsZWN0aW9uLnN0YXJ0KCkpLmFi c29sdXRlQ2FyZXRCb3VuZHMoKSk7CiAgICAgICAgIHJlc3VsdC5jYXJldFJlY3RBdEVuZCA9IHZp ZXctPmNvbnRlbnRzVG9Sb290VmlldyhWaXNpYmxlUG9zaXRpb24oc2VsZWN0aW9uLmVuZCgpKS5h YnNvbHV0ZUNhcmV0Qm91bmRzKCkpOwo=