135020 2014-07-17 12:37:13 -0700 [Mac] Full screen video not always animating in the correct Space 2014-07-17 20:29:48 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham ggaren jer.noble webkit-bug-importer oldest_to_newest 1023069 0 bfulgham 2014-07-17 12:37:13 -0700 Entering full-screen video playback mode can get locked to the original space used by the application. Instead, we should make sure our full screen window is part of the current space before entering full screen mode. 1023071 1 bfulgham 2014-07-17 12:42:20 -0700 <rdar://problem/17542310> 1023072 2 bfulgham 2014-07-17 12:47:14 -0700 The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen mode. Subsequent fullscreen transitions will always start from this Space, even if you move the WebKit-hosted application to a different Space. We can help the display system know when we've moved to a new Space by calling NSWindow's "orderBack" method on the fullscreen window prior to starting the transition to fullscreen mode. This method call hooks the window into the current Space so everything works properly. 1023073 3 235085 bfulgham 2014-07-17 12:48:24 -0700 Created attachment 235085 Patch 1023076 4 235085 ggaren 2014-07-17 13:25:44 -0700 Comment on attachment 235085 Patch If we orderBack, will the fullscreen animation be occluded in some way by front-more windows? Why not orderWindow:relativeTo: the WebView's window? 1023077 5 ggaren 2014-07-17 13:26:06 -0700 (or orderFront) 1023086 6 jer.noble 2014-07-17 13:54:22 -0700 (In reply to comment #4) > (From update of attachment 235085 [details]) > If we orderBack, will the fullscreen animation be occluded in some way by front-more windows? Why not orderWindow:relativeTo: the WebView's window? We actually still do makeKeyAndOrderFront: as soon as the animation begins. So this just orders the window on screen slightly earlier. 1023094 7 bfulgham 2014-07-17 14:07:02 -0700 (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 235085 [details] [details]) > > If we orderBack, will the fullscreen animation be occluded in some way by front-more windows? Why not orderWindow:relativeTo: the WebView's window? > > We actually still do makeKeyAndOrderFront: as soon as the animation begins. So this just orders the window on screen slightly earlier. Right. We are just trying to get the Window tied to the right Space when we are prepping to begin the animation. If we do it too late, the animation is tied to the wrong Space and we get bad behavior. "orderBack" avoids any weird flashing of the fullscreen Window before we are ready for it to be seen. 1023097 8 235085 dino 2014-07-17 14:14:31 -0700 Comment on attachment 235085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235085&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:270 > + [self.window orderBack: self]; // Make sure the full screen window is part of the correct Space Nit: . 1023110 9 bfulgham 2014-07-17 14:28:19 -0700 Committed r171197: <http://trac.webkit.org/changeset/171197> 1023190 10 235085 darin 2014-07-17 20:29:48 -0700 Comment on attachment 235085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235085&action=review >> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:270 >> + [self.window orderBack: self]; // Make sure the full screen window is part of the correct Space > > Nit: . No space after the colon. 235085 2014-07-17 12:48:24 -0700 2014-07-17 20:29:48 -0700 Patch bug-135020-20140717124807.patch text/plain 2051 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTE5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA3LTE3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIEZ1bGwgc2NyZWVu IHZpZGVvIG5vdCBhbHdheXMgYW5pbWF0aW5nIGluIHRoZSBjb3JyZWN0IFNwYWNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwMjAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE3NTQyMzEwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgVGhlIGZ1bGxzY3JlZW4gd2luZG93IGNhbiAicmVtZW1iZXIiIHRo ZSBTcGFjZSBpdCB3YXMgcGFydCBvZiB0aGUgZmlyc3QgdGltZSB5b3UgZW50ZXIgZnVsbHNjcmVl bgorICAgICAgIG1vZGUuIFN1YnNlcXVlbnQgZnVsbHNjcmVlbiB0cmFuc2l0aW9ucyB3aWxsIGFs d2F5cyBzdGFydCBmcm9tIHRoaXMgU3BhY2UsIGV2ZW4gaWYgeW91IG1vdmUKKyAgICAgICB0aGUg V2ViS2l0LWhvc3RlZCBhcHBsaWNhdGlvbiB0byBhIGRpZmZlcmVudCBTcGFjZS4KKworICAgICAg IFdlIGNhbiBoZWxwIHRoZSBkaXNwbGF5IHN5c3RlbSBrbm93IHdoZW4gd2UndmUgbW92ZWQgdG8g YSBuZXcgU3BhY2UgYnkgY2FsbGluZyBOU1dpbmRvdydzCisgICAgICAgJ29yZGVyQmFjaycgbWV0 aG9kIG9uIHRoZSBmdWxsc2NyZWVuIHdpbmRvdyBwcmlvciB0byBzdGFydGluZyB0aGUgdHJhbnNp dGlvbiB0byBmdWxsc2NyZWVuIG1vZGUuCisgICAgICAgVGhpcyBtZXRob2QgY2FsbCBob29rcyB0 aGUgd2luZG93IGludG8gdGhlIGN1cnJlbnQgU3BhY2Ugc28gZXZlcnl0aGluZyB3b3JrcyBwcm9w ZXJseS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJv bGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBiZWdhbkVu dGVyRnVsbFNjcmVlbldpdGhJbml0aWFsRnJhbWU6ZmluYWxGcmFtZTpdKTogQWRkIHRoZQorICAg ICAgICBuZXcgZnVsbHNjcmVlbiB3aW5kb3cgdG8gdGhlIGN1cnJlbnQgU3BhY2UgYmVmb3JlIHN0 YXJ0aW5nIHRyYW5zaXRpb24gdG8gZnVsbHNjcmVlbi4KKwogMjAxNC0wNy0xNyAgVGltIEhvcnRv biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBTb21ldGltZXMgcHVyZ2Vh YmxlIChvciBlbXB0eSEpIHRpbGVzIGFyZSBzaG93biBvbiBzY3JlZW4gd2hlbiByZXN1bWluZyB0 aGUgYXBwCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldp bmRvd0NvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzExMjMpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2Nyw2ICsyNjcsNyBAQCAtICh2b2lkKWJlZ2FuRW50 ZXJGdWxsU2NyZWVuV2l0aEluaXRpYWxGCiAgICAgaWYgKCFfYmFja2dyb3VuZFdpbmRvdykKICAg ICAgICAgX2JhY2tncm91bmRXaW5kb3cgPSBjcmVhdGVCYWNrZ3JvdW5kRnVsbHNjcmVlbldpbmRv dyhOU1plcm9SZWN0KTsKIAorICAgIFtzZWxmLndpbmRvdyBvcmRlckJhY2s6IHNlbGZdOyAvLyBN YWtlIHN1cmUgdGhlIGZ1bGwgc2NyZWVuIHdpbmRvdyBpcyBwYXJ0IG9mIHRoZSBjb3JyZWN0IFNw YWNlCiAgICAgW1tzZWxmIHdpbmRvd10gZW50ZXJGdWxsU2NyZWVuTW9kZTpzZWxmXTsKIH0KIAo=