135012 2014-07-17 01:00:41 -0700 Remove the unused variable in SubresourceLoader::willSendRequest() 2024-02-24 15:29:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 keonil.jeong webkit-unassigned ahmad.saleem792 ap commit-queue japhet koivisto mitz oldest_to_newest 1022981 0 keonil.jeong 2014-07-17 01:00:41 -0700 In SubresourceLoader::willSendRequest(), the previousURL variable is no more necessary. 1022982 1 235057 keonil.jeong 2014-07-17 01:30:04 -0700 Created attachment 235057 Patch 1022983 2 commit-queue 2014-07-17 01:31:59 -0700 Attachment 235057 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 1022984 3 235058 keonil.jeong 2014-07-17 01:39:59 -0700 Created attachment 235058 Patch 1023223 4 keonil.jeong 2014-07-18 01:25:33 -0700 the fail of window build is not related to this patch. 1025831 5 235781 keonil.jeong 2014-07-30 17:09:04 -0700 Created attachment 235781 Patch 1026433 6 235781 mitz 2014-08-01 21:22:10 -0700 Comment on attachment 235781 Patch I found that the last use of this variable was removed in <http://trac.webkit.org/r145735>. 2016656 7 ahmad.saleem792 2024-02-24 15:29:00 -0800 This didn't landed but I couldn't find the variable as well: (SubresourceLoader::willSendRequestInternal) https://searchfox.org/wubkat/rev/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6/Source/WebCore/loader/SubresourceLoader.cpp#207 235057 2014-07-17 01:30:04 -0700 2014-07-17 01:39:53 -0700 Patch bug-135012-20140717172949.patch text/plain 1418 keonil.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg4Mjk4ZTg2MDllMjcx ZTNiMWUxM2E2NTdjMGMxZmNmZGZlOTEzNC4uZWU1YmE3MjgwMGRiODYwOWMzOWZiN2Y3OTUyNDg3 YTg2ZjA0MDBkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTE3ICBLZW9u aWwgSmVvbmcgIDxrZW9uaWwuamVvbmdAZ21haWwuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgdmFyaWFibGUgaW4gU3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwMTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg KE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRSZXF1ZXN0KToKKwogMjAx NC0wNy0xNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAg ICBDU1MgSklUOiBDbGVhbiB1cCByZXR1cm4gcGF0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9T dWJyZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggZjFmY2VhY2FhMTZlZDQzNDM4YWM3NDQ0ZDQxYzZh ZTRlMjI5OTcxMS4uN2NiODAwZDc0NzBmOGM5MWFkYWU4MzA0OWNhZTVmM2VlNmJhMDU4YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xNDUsOCAr MTQ1LDYgQEAgYm9vbCBTdWJyZXNvdXJjZUxvYWRlcjo6aXNTdWJyZXNvdXJjZUxvYWRlcigpCiAK IHZvaWQgU3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZVJlcXVlc3Qm IG5ld1JlcXVlc3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpCiB7 Ci0gICAgLy8gU3RvcmUgdGhlIHByZXZpb3VzIFVSTCBiZWNhdXNlIHRoZSBjYWxsIHRvIFJlc291 cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3Qgd2lsbCBtb2RpZnkgaXQuCi0gICAgVVJMIHByZXZp b3VzVVJMID0gcmVxdWVzdCgpLnVybCgpOwogICAgIFJlZjxTdWJyZXNvdXJjZUxvYWRlcj4gcHJv dGVjdCgqdGhpcyk7CiAKICAgICBBU1NFUlQoIW5ld1JlcXVlc3QuaXNOdWxsKCkpOwo= 235058 2014-07-17 01:39:59 -0700 2014-07-30 17:08:57 -0700 Patch bug-135012-20140717173944.patch text/plain 1474 keonil.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg4Mjk4ZTg2MDllMjcx ZTNiMWUxM2E2NTdjMGMxZmNmZGZlOTEzNC4uYjNjZDdiNzkwMGM4YzRkZDE4ZGUwNmQ2MmY2NDNi NGM5ZTcyY2Y4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTE3ICBLZW9u aWwgSmVvbmcgIDxrZW9uaWwuamVvbmdAZ21haWwuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgdmFyaWFibGUgaW4gU3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUwMTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJldmlvdXNV UkwgdmFyaWFibGUgaXMgbm90IHVzZWQgaW4gU3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVx dWVzdCgpLgorCisgICAgICAgICogbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QpOgorCiAyMDE0 LTA3LTE3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAg IENTUyBKSVQ6IENsZWFuIHVwIHJldHVybiBwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1 YnJlc291cmNlTG9hZGVyLmNwcAppbmRleCBmMWZjZWFjYWExNmVkNDM0MzhhYzc0NDRkNDFjNmFl NGUyMjk5NzExLi43Y2I4MDBkNzQ3MGY4YzkxYWRhZTgzMDQ5Y2FlNWYzZWU2YmEwNThiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKQEAgLTE0NSw4ICsx NDUsNiBAQCBib29sIFN1YnJlc291cmNlTG9hZGVyOjppc1N1YnJlc291cmNlTG9hZGVyKCkKIAog dm9pZCBTdWJyZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYg bmV3UmVxdWVzdCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSkKIHsK LSAgICAvLyBTdG9yZSB0aGUgcHJldmlvdXMgVVJMIGJlY2F1c2UgdGhlIGNhbGwgdG8gUmVzb3Vy Y2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCB3aWxsIG1vZGlmeSBpdC4KLSAgICBVUkwgcHJldmlv dXNVUkwgPSByZXF1ZXN0KCkudXJsKCk7CiAgICAgUmVmPFN1YnJlc291cmNlTG9hZGVyPiBwcm90 ZWN0KCp0aGlzKTsKIAogICAgIEFTU0VSVCghbmV3UmVxdWVzdC5pc051bGwoKSk7Cg== 235781 2014-07-30 17:09:04 -0700 2014-08-01 21:22:09 -0700 Patch bug-135012-20140731090852.patch text/plain 1688 keonil.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUzOTgxMWIwOTE4ZWE1 NDY0MmJmMzY0MDEyMzJlOTk3YzI1NmUxNy4uYTI5Yzc0M2M2YTM2ZTk0YjE1YzU2N2FlMjFjZTUy NTAwNDVjOTEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA3LTMwICBLZW9u aWwgSmVvbmcgIDxrZW9uaWwuamVvbmdAZ21haWwuY29tPgorCisgICAgICAgIFJlbW92ZSB0aGUg dW51c2VkIHZhcmlhYmxlIGluIFN1YnJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MDEyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByZXZp b3VzVVJMIHZhcmlhYmxlIGlzIG5vIG1vcmUgdXNlZCBpbiBTdWJyZXNvdXJjZUxvYWRlcjo6d2ls bFNlbmRSZXF1ZXN0KCkuCisgICAgICAgIFRoaXMgcGF0Y2gganVzdCByZW1vdmVzIHRoZSB1bnVz ZWQgdmFyaWFibGUgYW5kIGNvbW1lbnRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNl IHRoaXMgcGF0Y2ggZG9lcyBub3QgYWZmZWN0IGFueSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBs b2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3VicmVzb3Vy Y2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCk6CisKIDIwMTQtMDctMjkgIFByYXRpayBTb2xhbmtp ICA8cHNvbGFua2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJFR1JFU1NJT04ocjE3MTUy Nik6IFBERiBkb2N1bWVudHMgZmFpbCB0byBsb2FkIGluIFdlYktpdDEgd2l0aCBkaXNrIGltYWdl IGNhY2hpbmcgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJl c291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRl ci5jcHAKaW5kZXggZjFmY2VhY2FhMTZlZDQzNDM4YWM3NDQ0ZDQxYzZhZTRlMjI5OTcxMS4uN2Ni ODAwZDc0NzBmOGM5MWFkYWU4MzA0OWNhZTVmM2VlNmJhMDU4YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xNDUsOCArMTQ1LDYgQEAgYm9vbCBT dWJyZXNvdXJjZUxvYWRlcjo6aXNTdWJyZXNvdXJjZUxvYWRlcigpCiAKIHZvaWQgU3VicmVzb3Vy Y2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmIG5ld1JlcXVlc3QsIGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpCiB7Ci0gICAgLy8gU3RvcmUg dGhlIHByZXZpb3VzIFVSTCBiZWNhdXNlIHRoZSBjYWxsIHRvIFJlc291cmNlTG9hZGVyOjp3aWxs U2VuZFJlcXVlc3Qgd2lsbCBtb2RpZnkgaXQuCi0gICAgVVJMIHByZXZpb3VzVVJMID0gcmVxdWVz dCgpLnVybCgpOwogICAgIFJlZjxTdWJyZXNvdXJjZUxvYWRlcj4gcHJvdGVjdCgqdGhpcyk7CiAK ICAgICBBU1NFUlQoIW5ld1JlcXVlc3QuaXNOdWxsKCkpOwo=