135007 2014-07-16 20:43:04 -0700 sputnik/Implementation_Diagnostics/S12.6.4_D1.html depends on undefined behavior 2014-07-18 13:27:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 1022950 0 mhahnenberg 2014-07-16 20:43:04 -0700 EcmaScript 5.1 specifies that during for-in enumeration newly added properties may or may not be visited during the current enumeration. Specifically, in section 12.6.4 the spec states: "If new properties are added to the object being enumerated during enumeration, the newly added properties are not guaranteed to be visited in the active enumeration." The sputnik/Implementation_Diagnostics/S12.6.4_D1.html layout test is from before sputnik was added to the test262 suite. I believe it has since been removed, so it would probably be okay to remove it from our layout test suite. 1022951 1 235049 mhahnenberg 2014-07-16 20:48:42 -0700 Created attachment 235049 Patch 1022953 2 235049 fpizlo 2014-07-16 20:56:17 -0700 Comment on attachment 235049 Patch Is it part of test262? 1022957 3 mhahnenberg 2014-07-16 21:14:18 -0700 (In reply to comment #2) > (From update of attachment 235049 [details]) > Is it part of test262? I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass. 1022958 4 mhahnenberg 2014-07-16 21:14:54 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 235049 [details] [details]) > > Is it part of test262? > > I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass. I guess it might never have been added to test262 though... 1023336 5 mhahnenberg 2014-07-18 13:27:10 -0700 Fix landed in http://trac.webkit.org/changeset/171189. 1023337 6 235049 mhahnenberg 2014-07-18 13:27:30 -0700 Comment on attachment 235049 Patch Clearing review flag. 235049 2014-07-16 20:48:42 -0700 2014-07-18 13:27:29 -0700 Patch bug-135007-20140716204825.patch text/plain 4931 mhahnenberg SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3MTE3MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA3LTE2ICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgc3B1dG5pay9JbXBsZW1lbnRhdGlv bl9EaWFnbm9zdGljcy9TMTIuNi40X0QxLmh0bWwgZGVwZW5kcyBvbiB1bmRlZmluZWQgYmVoYXZp b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTAw NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVjbWFT Y3JpcHQgNS4xIHNwZWNpZmllcyB0aGF0IGR1cmluZyBmb3ItaW4gZW51bWVyYXRpb24gbmV3bHkg YWRkZWQgcHJvcGVydGllcyBtYXkgb3IgbWF5IG5vdCBiZSAKKyAgICAgICAgdmlzaXRlZCBkdXJp bmcgdGhlIGN1cnJlbnQgZW51bWVyYXRpb24uIFNwZWNpZmljYWxseSwgaW4gc2VjdGlvbiAxMi42 LjQgdGhlIHNwZWMgc3RhdGVzOgorCisgICAgICAgICJJZiBuZXcgcHJvcGVydGllcyBhcmUgYWRk ZWQgdG8gdGhlIG9iamVjdCBiZWluZyBlbnVtZXJhdGVkIGR1cmluZyBlbnVtZXJhdGlvbiwgdGhl IG5ld2x5IGFkZGVkIHByb3BlcnRpZXMgCisgICAgICAgIGFyZSBub3QgZ3VhcmFudGVlZCB0byBi ZSB2aXNpdGVkIGluIHRoZSBhY3RpdmUgZW51bWVyYXRpb24uIgorCisgICAgICAgIFRoZSBzcHV0 bmlrL0ltcGxlbWVudGF0aW9uX0RpYWdub3N0aWNzL1MxMi42LjRfRDEuaHRtbCBsYXlvdXQgdGVz dCBpcyBmcm9tIGJlZm9yZSBzcHV0bmlrIHdhcyBhZGRlZCAKKyAgICAgICAgdG8gdGhlIHRlc3Qy NjIgc3VpdGUuIEkgYmVsaWV2ZSBpdCBoYXMgc2luY2UgYmVlbiByZW1vdmVkLCBzbyBpdCB3b3Vs ZCBwcm9iYWJseSBiZSBva2F5IHRvIHJlbW92ZSBpdCAKKyAgICAgICAgZnJvbSBvdXIgbGF5b3V0 IHRlc3Qgc3VpdGUuCisKKyAgICAgICAgKiBzcHV0bmlrL0ltcGxlbWVudGF0aW9uX0RpYWdub3N0 aWNzL1MxMi42LjRfRDEtZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIHNwdXRuaWsv SW1wbGVtZW50YXRpb25fRGlhZ25vc3RpY3MvUzEyLjYuNF9EMS5odG1sOiBSZW1vdmVkLgorCiAy MDE0LTA3LTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgW2Z0 bG9wdF0gREZHIHNob3VsZCBiZSBhYmxlIHRvIGRvIEdDU0UgaW4gU1NBIGFuZCB0aGlzIHNob3Vs ZCBiZSB1bmlmaWVkIHdpdGggdGhlIENTRSBpbiBDUFMsIGFuZCBib3RoIG9mIHRoZXNlIHRoaW5n cyBzaG91bGQgdXNlIGFic3RyYWN0IGhlYXBzIGZvciByZWFzb25pbmcgYWJvdXQgZWZmZWN0cwpJ bmRleDogTGF5b3V0VGVzdHMvc3B1dG5pay9JbXBsZW1lbnRhdGlvbl9EaWFnbm9zdGljcy9TMTIu Ni40X0QxLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zcHV0bmlrL0lt cGxlbWVudGF0aW9uX0RpYWdub3N0aWNzL1MxMi42LjRfRDEtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAxNzExNjMpCisrKyBMYXlvdXRUZXN0cy9zcHV0bmlrL0ltcGxlbWVudGF0aW9uX0RpYWdub3N0 aWNzL1MxMi42LjRfRDEtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzAsMCBA QAotUzEyLjYuNF9EMQotCi1GQUlMIFNwdXRuaWtFcnJvcjogIzE6IHRoZSBuZXdseSBhZGRlZCBw cm9wZXJ0aWVzIHRvIGJlIHZpc2l0ZWQgaW4gdGhlIGFjdGl2ZSBlbnVtZXJhdGlvbgotCi1URVNU IENPTVBMRVRFCi0KSW5kZXg6IExheW91dFRlc3RzL3NwdXRuaWsvSW1wbGVtZW50YXRpb25fRGlh Z25vc3RpY3MvUzEyLjYuNF9EMS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3NwdXRu aWsvSW1wbGVtZW50YXRpb25fRGlhZ25vc3RpY3MvUzEyLjYuNF9EMS5odG1sCShyZXZpc2lvbiAx NzExNjMpCisrKyBMYXlvdXRUZXN0cy9zcHV0bmlrL0ltcGxlbWVudGF0aW9uX0RpYWdub3N0aWNz L1MxMi42LjRfRDEuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwxMzAgKzAsMCBAQAotPGh0bWw+ Ci08aGVhZD4KLTxtZXRhIGNoYXJzZXQ9J3V0Zi04Jz4KLTxzdHlsZT4KLS5wYXNzIHsKLSAgICBm b250LXdlaWdodDogYm9sZDsKLSAgICBjb2xvcjogZ3JlZW47Ci19Ci0uZmFpbCB7Ci0gICAgZm9u dC13ZWlnaHQ6IGJvbGQ7Ci0gICAgY29sb3I6IHJlZDsKLX0KLTwvc3R5bGU+Ci0KLTxzY3JpcHQ+ Ci1pZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0K LWZ1bmN0aW9uIFNwdXRuaWtFcnJvcihtZXNzYWdlKQotewotICAgIHRoaXMubWVzc2FnZSA9IG1l c3NhZ2U7Ci19Ci0KLVNwdXRuaWtFcnJvci5wcm90b3R5cGUudG9TdHJpbmcgPSBmdW5jdGlvbiAo KQotewotICAgIHJldHVybiAnU3B1dG5pa0Vycm9yOiAnICsgdGhpcy5tZXNzYWdlOwotfTsKLQot dmFyIHNwdXRuaWtFeGNlcHRpb247Ci0KLWZ1bmN0aW9uIHRlc3RQcmludChtc2cpCi17Ci0gICAg dmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7Ci0gICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5hcHBlbmRDaGlsZChzcGFuKTsgLy8gaW5zZXJ0IGl0 IGZpcnN0IHNvIFhIVE1MIGtub3dzIHRoZSBuYW1lc3BhY2UgCi0gICAgc3Bhbi5pbm5lckhUTUwg PSBtc2cgKyAnPGJyIC8+JzsKLX0KLQotZnVuY3Rpb24gZXNjYXBlSFRNTCh0ZXh0KQotewotICAg IHJldHVybiB0ZXh0LnRvU3RyaW5nKCkucmVwbGFjZSgvJi9nLCAiJmFtcDsiKS5yZXBsYWNlKC88 L2csICImbHQ7Iik7Ci19Ci0KLWZ1bmN0aW9uIHByaW50VGVzdFBhc3NlZChtc2cpCi17Ci0gICAg dGVzdFByaW50KCc8c3Bhbj48c3BhbiBjbGFzcz0icGFzcyI+UEFTUzwvc3Bhbj4gJyArIGVzY2Fw ZUhUTUwobXNnKSArICc8L3NwYW4+Jyk7Ci19Ci0KLWZ1bmN0aW9uIHByaW50VGVzdEZhaWxlZCht c2cpCi17Ci0gICAgdGVzdFByaW50KCc8c3Bhbj48c3BhbiBjbGFzcz0iZmFpbCI+RkFJTDwvc3Bh bj4gJyArIGVzY2FwZUhUTUwobXNnKSArICc8L3NwYW4+Jyk7Ci19Ci0KLWZ1bmN0aW9uIHRlc3RG YWlsZWQobXNnKQotewotICAgIHRocm93IG5ldyBTcHV0bmlrRXJyb3IobXNnKTsKLX0KLQotdmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwotPC9zY3JpcHQ+Ci0KLTwvaGVhZD4KLTxib2R5 PgotPHA+UzEyLjYuNF9EMTwvcD4KLTxkaXYgaWQ9J2NvbnNvbGUnPjwvZGl2PgotPHNjcmlwdD4K LXRyeSB7Ci0KLS8qKgotKiBAbmFtZTogUzEyLjYuNF9EMTsKLSogQHNlY3Rpb246IDEyLjYuNDsK LSogQGFzc2VydGlvbjogSWYgbmV3IHByb3BlcnRpZXMgYXJlIGFkZGVkIHRvIHRoZSBvYmplY3Qg YmVpbmcKLSogZW51bWVyYXRlZCBkdXJpbmcgZW51bWVyYXRpb24sIHRoZSBuZXdseSBhZGRlZCBw cm9wZXJ0aWVzIHRvIGJlIHZpc2l0ZWQgaW4gdGhlIGFjdGl2ZQotKiBlbnVtZXJhdGlvbjsKLSov Ci0KLV9fb2JqPXthYToxLGJhOjIsY2E6M307Ci1fX3NvdXJjZT17c3JhOjksc3JiOjgsc3JjOjd9 OwotCi1fX2FjY3VtPSIiOwotCi1mb3IgKF9fa2V5IGluIF9fb2JqKXsKLQkKLQlfX2FjY3VtKz0o X19rZXkrX19vYmpbX19rZXldKTsKLQkKLQlhZGQyaGFzaChfX29iaixfX3NvdXJjZSk7Ci0JCi19 Ci0KLQotLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCi0vL0NIRUNLIzEKLWlmICghKAotKF9fYWNjdW0u aW5kZXhPZigiYWExIikhPT0tMSkmJgotKF9fYWNjdW0uaW5kZXhPZigiYmEyIikhPT0tMSkmJgot KF9fYWNjdW0uaW5kZXhPZigiY2EzIikhPT0tMSkmJgotKF9fYWNjdW0uaW5kZXhPZigic3JhOSIp IT09LTEpJiYKLShfX2FjY3VtLmluZGV4T2YoInNyYjgiKSE9PS0xKSYmCi0oX19hY2N1bS5pbmRl eE9mKCJzcmM3IikhPT0tMSkKLSkpIHsKLQl0ZXN0RmFpbGVkKCcjMTogdGhlIG5ld2x5IGFkZGVk IHByb3BlcnRpZXMgdG8gYmUgdmlzaXRlZCBpbiB0aGUgYWN0aXZlIGVudW1lcmF0aW9uJyk7Ci19 Ci0vLwotLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCi0KLWZ1bmN0aW9uIGFkZDJoYXNoKGhhc2hfbWFw X3RhcmdldCwgaGFzaF9tYXBfYmVfYWRkZWQpewotICAgIGlmIChhZGRlZCkgcmV0dXJuOwotCWZv ciAoa2V5IGluIGhhc2hfbWFwX2JlX2FkZGVkKXsKLQkJCWhhc2hfbWFwX3RhcmdldFtrZXldID0g aGFzaF9tYXBfYmVfYWRkZWRba2V5XTsKLQl9Ci0JdmFyIGFkZGVkID0gdHJ1ZTsKLX0KLQotfSBj YXRjaCAoZXgpIHsKLSAgICBzcHV0bmlrRXhjZXB0aW9uID0gZXg7Ci19Ci0KLXZhciBzdWNjZXNz ZnVsbHlQYXJzZWQgPSB0cnVlOwotPC9zY3JpcHQ+Ci0KLTxzY3JpcHQ+Ci1pZiAoIXN1Y2Nlc3Nm dWxseVBhcnNlZCkKLSAgICBwcmludFRlc3RGYWlsZWQoJ3N1Y2Nlc3NmdWxseVBhcnNlZCBpcyBu b3Qgc2V0Jyk7Ci1lbHNlIGlmIChzcHV0bmlrRXhjZXB0aW9uKQotICAgIHByaW50VGVzdEZhaWxl ZChzcHV0bmlrRXhjZXB0aW9uKTsKLWVsc2UKLSAgICBwcmludFRlc3RQYXNzZWQoIiIpOwotdGVz dFByaW50KCc8YnIgLz48c3BhbiBjbGFzcz0icGFzcyI+VEVTVCBDT01QTEVURTwvc3Bhbj4nKTsK LTwvc2NyaXB0PgotPC9ib2R5PgotPC9odG1sPgo=