135001 2014-07-16 18:31:41 -0700 Web Inspector: TextContentView calls the wrong super function in shown() 2014-07-17 13:34:50 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 saam webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1022905 0 saam 2014-07-16 18:31:41 -0700 TextContentView calls ResourceContentView.shown instead of ContentView.shown. It should call ContentView.shown because ContentView is its prototype. 1022906 1 webkit-bug-importer 2014-07-16 18:31:54 -0700 <rdar://problem/17705592> 1022907 2 235042 saam 2014-07-16 18:35:04 -0700 Created attachment 235042 patch This fixes the problem. (Currently, calling the wrong prototype function has no effect, because neither function does anything. But this may not hold in the future). 1022948 3 235042 timothy 2014-07-16 20:35:36 -0700 Comment on attachment 235042 patch Nice catch! 1022955 4 235042 commit-queue 2014-07-16 21:08:07 -0700 Comment on attachment 235042 patch Clearing flags on attachment: 235042 Committed r171172: <http://trac.webkit.org/changeset/171172> 1022956 5 commit-queue 2014-07-16 21:08:10 -0700 All reviewed patches have been landed. Closing bug. 1023041 6 235042 joepeck 2014-07-17 10:42:32 -0700 Comment on attachment 235042 patch Err, the hidden function needs to be updated as well. 1023048 7 saam 2014-07-17 11:17:02 -0700 (In reply to comment #6) > (From update of attachment 235042 [details]) > Err, the hidden function needs to be updated as well. Ahh I didn't even see that. I'll submit that as a patch too. 1023053 8 235078 saam 2014-07-17 11:22:45 -0700 Created attachment 235078 patch Corollary patch for the hidden() function. 1023079 9 235078 joepeck 2014-07-17 13:34:50 -0700 Comment on attachment 235078 patch Unfortunately this needs a ChangeLog. So perhaps a new bugzilla bug is the right thing to do. 235042 2014-07-16 18:35:04 -0700 2014-07-17 11:22:45 -0700 patch inspector-patch.diff text/plain 1460 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxMTYzKQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTA3LTE2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IFRleHRDb250ZW50VmlldyBjYWxscyB0aGUgd3Jvbmcgc3VwZXIgZnVu Y3Rpb24gaW4gc2hvd24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1MDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIFRleHRDb250ZW50VmlldyBjYWxscyBSZXNvdXJjZUNvbnRlbnRWaWV3LnNob3duIGlu c3RlYWQgb2YgQ29udGVudFZpZXcuc2hvd24uCisgICAgICAgIEl0IHNob3VsZCBjYWxsIENvbnRl bnRWaWV3LnNob3duIGJlY2F1c2UgQ29udGVudFZpZXcgaXMgaXRzIHByb3RvdHlwZS4KKworCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UZXh0Q29udGVudFZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuVGV4dENvbnRlbnRWaWV3LnByb3RvdHlwZS5zaG93bik6CisKIDIwMTQt MDUtMDggIEpvbm8gV2VsbHMgIDxqb25vd2VsbHNAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IENvbnNvbGUgZXJyb3Igd2hlbiBsYXVuY2hpbmcgV2ViIEluc3BlY3RvciAiTW9k ZSBodG1sbWl4ZWQgZmFpbGVkIHRvIGFkdmFuY2Ugc3RyZWFtIgpJbmRleDogU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dENvbnRlbnRWaWV3LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRDb250 ZW50Vmlldy5qcwkocmV2aXNpb24gMTcxMDg3KQorKysgU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGV4dENvbnRlbnRWaWV3LmpzCSh3b3JraW5nIGNvcHkpCkBAIC03 MCw3ICs3MCw3IEBAIFdlYkluc3BlY3Rvci5UZXh0Q29udGVudFZpZXcucHJvdG90eXBlID0KIAog ICAgIHNob3duOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICBXZWJJbnNwZWN0b3IuUmVzb3Vy Y2VDb250ZW50Vmlldy5wcm90b3R5cGUuc2hvd24uY2FsbCh0aGlzKTsKKyAgICAgICAgV2ViSW5z cGVjdG9yLkNvbnRlbnRWaWV3LnByb3RvdHlwZS5zaG93bi5jYWxsKHRoaXMpOwogCiAgICAgICAg IHRoaXMuX3RleHRFZGl0b3Iuc2hvd24oKTsKICAgICB9LAo= 235078 2014-07-17 11:22:45 -0700 2014-07-17 13:34:50 -0700 patch inspector-patch.diff text/plain 571 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRDb250 ZW50Vmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UZXh0Q29udGVudFZpZXcuanMJKHJldmlzaW9uIDE3MTA4NykKKysrIFNvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRDb250ZW50Vmlldy5qcwko d29ya2luZyBjb3B5KQpAQCAtNzcsNyArNzcsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dENvbnRlbnRW aWV3LnByb3RvdHlwZSA9CiAKICAgICBoaWRkZW46IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAg IFdlYkluc3BlY3Rvci5SZXNvdXJjZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5oaWRkZW4uY2FsbCh0 aGlzKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LnByb3RvdHlwZS5oaWRkZW4u Y2FsbCh0aGlzKTsKIAogICAgICAgICB0aGlzLl90ZXh0RWRpdG9yLmhpZGRlbigpOwogICAgIH0s Cg==