134993 2014-07-16 16:30:15 -0700 [iOS] Update order file paths for WebKit and WebKit2 2014-07-16 20:18:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer andersca commit-queue dbates dfarler joepeck mitz mrowe psolanki thorton oldest_to_newest 1022863 0 ddkilzer 2014-07-16 16:30:15 -0700 Need to update the order files for WebKit and WebKit2 for iOS. 1022864 1 ddkilzer 2014-07-16 16:30:32 -0700 <rdar://problem/17557776> 1022871 2 235036 ddkilzer 2014-07-16 17:08:40 -0700 Created attachment 235036 Patch v1 1022909 3 235036 commit-queue 2014-07-16 18:38:27 -0700 Comment on attachment 235036 Patch v1 Clearing flags on attachment: 235036 Committed r171164: <http://trac.webkit.org/changeset/171164> 1022910 4 commit-queue 2014-07-16 18:38:30 -0700 All reviewed patches have been landed. Closing bug. 1022912 5 mitz 2014-07-16 18:40:38 -0700 Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework. 1022942 6 ddkilzer 2014-07-16 20:18:56 -0700 (In reply to comment #5) > Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework. The only reason I can think of doing it in the Base.xcconfig is that it's easy to override (to no order file) for Debug/Release builds. However, I don't know of any downsides to specifying an order file in Debug/Release, unless it makes link times significantly longer. I filed Bug 135006. 235036 2014-07-16 17:08:40 -0700 2014-07-16 18:38:26 -0700 Patch v1 bug-134993-20140716170812.patch text/plain 2967 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMWVhY2YwYzRi NWU1OTFkNTUzNjQzMDAxMTI0YzQ1ZGE5NGMxYmM0Yy4uYWRlYTZlNTI0Zjk2MGIyMDdlNWE3ZDE5 ZjlhNjU4ZTQzZDZkM2I3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0 LTA3LTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW2lP U10gVXBkYXRlIG9yZGVyIGZpbGUgcGF0aHMgZm9yIFdlYktpdCBhbmQgV2ViS2l0MgorICAgICAg ICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzQ5OTM+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NzU1Nzc3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIENvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6IFJlbmFtZSBXZWJLaXQub3JkZXIgdG8K KyAgICAgICAgV2ViS2l0TGVnYWN5Lm9yZGVyLgorCiAyMDE0LTA3LTE0ICBCZWFyIFRyYXZpcyAg PGJldHJhdmlzQGFkb2JlLmNvbT4KIAogICAgICAgICBbRmVhdHVyZSBRdWVyaWVzXSBFbmFibGUg RmVhdHVyZSBRdWVyaWVzIG9uIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY1OGExYTE1MTQ4NWNhMWMxMzk4 OTIwOWJlN2VkNjFmZTgyOTZlOGIuLmJmMmJiYWU5OTU0MmU5ODI4ZDQ0Yjc3MjQyNDc2N2RjMzVl N2JlNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wNy0xNiAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFVwZGF0ZSBvcmRlciBm aWxlIHBhdGhzIGZvciBXZWJLaXQgYW5kIFdlYktpdDIKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQu b3JnL2IvMTM0OTkzPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc1NTc3NzY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9u cy9CYXNlLnhjY29uZmlnOiBBZGQgb3JkZXIgZmlsZSBmb3IgaU9TCisgICAgICAgIG5hbWVkIFdl YktpdC5vcmRlci4KKwogMjAxNC0wNy0xNSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04oV0syIGlPUyk6IFNhZmFyaSBoYW5ncyB3aGVuIHN3 aXRjaGluZyBmb2N1cyBmcm9tIGEgZmllbGQgdXNpbmcgdGhlIFRhYiBrZXkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvU291cmNl L1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCA1NTc4NDkzMDM4 YWU3MDdjMzNkNDRkMGFiZDY5ZTE2NGNhMDA5N2JiLi4zNTI2M2ZmZmMwMWVkOGJmMDM0MGVkYWQy ZjQxYzMxMzQxZjc3NjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0 aW9ucy9CYXNlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25z L0Jhc2UueGNjb25maWcKQEAgLTEwMiw3ICsxMDIsNyBAQCBTVFJJUF9JTlNUQUxMRURfUFJPRFVD VF9kZWJ1ZyA9IE5POwogREVBRF9DT0RFX1NUUklQUElORyA9IFlFUzsKIAogU0VDVE9SREVSX0ZM QUdTID0gJChTRUNUT1JERVJfRkxBR1NfJChQTEFURk9STV9OQU1FKSk7Ci1TRUNUT1JERVJfRkxB R1NfaXBob25lb3MgPSAtV2wsLW9yZGVyX2ZpbGUsJChTREtST09UKS9BcHBsZUludGVybmFsL09y ZGVyRmlsZXMvV2ViS2l0Lm9yZGVyOworU0VDVE9SREVSX0ZMQUdTX2lwaG9uZW9zID0gLVdsLC1v cmRlcl9maWxlLCQoU0RLUk9PVCkvQXBwbGVJbnRlcm5hbC9PcmRlckZpbGVzL1dlYktpdExlZ2Fj eS5vcmRlcjsKIFNFQ1RPUkRFUl9GTEFHU19tYWNvc3ggPSAtV2wsLW9yZGVyX2ZpbGUsbWFjL1dl YktpdC5vcmRlcjsKIAogU0RLUk9PVCA9IG1hY29zeC5pbnRlcm5hbDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcgYi9Tb3VyY2UvV2ViS2l0 Mi9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IDg2MzkwZGU4NDgyY2M5NWQ2ZjYw NjI3MDdkMjcwMjkwZGE0ZmExN2YuLjEyYWViZTAxOTFkYjQxZmU4YmRhZWEzZjY2ZTY3NzU3NzQ2 NWY1ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNj b25maWcKKysrIGIvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwpA QCAtOTksNyArOTksOSBAQCBDT1BZX1BIQVNFX1NUUklQID0gTk87CiAvLyBidWlsZGluZyB0aGUg TWlHIGJpbmRpbmdzIGZvciBXZWJLaXRQbHVnaW5DbGllbnQgZXZlbiB3aGVuIHRoZSBmdW5jdGlv bnMgdGhhdCB0aGUgYmluZGluZ3Mgd3JhcCBhcmUgbm90IGJ1aWx0LgogREVBRF9DT0RFX1NUUklQ UElORyA9IFlFUzsKIAotU0VDVE9SREVSX0ZMQUdTID0gLVdsLC1vcmRlcl9maWxlLG1hYy9XZWJL aXQyLm9yZGVyOworU0VDVE9SREVSX0ZMQUdTID0gJChTRUNUT1JERVJfRkxBR1NfJChQTEFURk9S TV9OQU1FKSk7CitTRUNUT1JERVJfRkxBR1NfaXBob25lb3MgPSAtV2wsLW9yZGVyX2ZpbGUsJChT REtST09UKS9BcHBsZUludGVybmFsL09yZGVyRmlsZXMvV2ViS2l0Lm9yZGVyOworU0VDVE9SREVS X0ZMQUdTX21hY29zeCA9IC1XbCwtb3JkZXJfZmlsZSxtYWMvV2ViS2l0Mi5vcmRlcjsKIAogSU5T VEFMTF9QQVRIID0gJChJTlNUQUxMX1BBVEhfUFJFRklYKSQoSU5TVEFMTF9QQVRIX0FDVFVBTCk7 CiAK