134990 2014-07-16 14:23:55 -0700 Need FTL implementation of SkipTopScope 2014-07-29 14:52:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmirman mmirman commit-queue fpizlo ggaren mmirman oldest_to_newest 1022825 0 mmirman 2014-07-16 14:23:55 -0700 patch forthcoming. 1022826 1 235021 mmirman 2014-07-16 14:28:17 -0700 Created attachment 235021 [ftlopt] Added SkipTopScope coverage to FTL Can't test it yet though. 1022827 2 commit-queue 2014-07-16 14:29:59 -0700 Attachment 235021 did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3394: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3404: Missing space after , [whitespace/comma] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1022833 3 235021 ggaren 2014-07-16 14:37:45 -0700 Comment on attachment 235021 [ftlopt] Added SkipTopScope coverage to FTL View in context: https://bugs.webkit.org/attachment.cgi?id=235021&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3421 > + m_out.isZero64( m_out.load64(addressFor(machineActivationRegister))) No space after the paren here. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3423 > + , unsure(isNull) > + , unsure(notNull)); These two can probably go on the same line. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3431 > + setJSValue(m_out.phi(m_out.intPtr, top,next)); Space after "top". 1022836 4 235024 mmirman 2014-07-16 15:00:17 -0700 Created attachment 235024 [ftlopt] Added SkipTopScope coverage to FTL Fixed style 1025562 5 mmirman 2014-07-29 14:52:58 -0700 Landed in http://trac.webkit.org/changeset/171767 235021 2014-07-16 14:28:17 -0700 2014-07-16 15:00:17 -0700 [ftlopt] Added SkipTopScope coverage to FTL 0001-ftlopt-Added-SkipTopScope-coverage-to-FTL.patch text/plain 3184 mmirman RnJvbSAxNTRmZDM2ZWVmYmY4ZmFlZmE4M2M1ZmJhZWRhNzI4YTJlMWU1MzBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IE1pcm1hbiA8bW1pcm1hbkBhcHBsZS5jb20+CkRh dGU6IE1vbiwgMTQgSnVsIDIwMTQgMTQ6Mjg6MDggLTA3MDAKU3ViamVjdDogW1BBVENIXSBbZnRs b3B0XSBBZGRlZCBTa2lwVG9wU2NvcGUgY292ZXJhZ2UgdG8gRlRMCgoKZGlmZiAtLWdpdCBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKaW5kZXggMTI1NjUwOS4uODQxZmIwYyAxMDA2NDQKLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxNC0wNy0xNCAgTWF0dGhldyBNaXJtYW4gIDxtbWlybWFuQGFwcGxlLmNvbT4K KworICAgICAgICBbZnRsb3B0XSBBZGRlZCBTa2lwVG9wU2NvcGUgY292ZXJhZ2UgdG8gRlRMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ5OTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ0bC9GVExD YXBhYmlsaXRpZXMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNhbkNvbXBpbGUpOiAgQWRkZWQg Y2FzZSBmb3IgU2tpcFRvcFNjb3BlCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZU5vZGUpOiBBZGRl ZCBjYXNlIGZvciBTa2lwVG9wU2NvcGUKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExW TTo6Y29tcGlsZVNraXBUb3BTY29wZSk6IEFkZGVkLgorCiAyMDE0LTA3LTEzICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0IHVuaW50 ZW5kZWQgY2hhbmdlIGluIHIxNzEwNTEuCmRpZmYgLS1naXQgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ2Fw YWJpbGl0aWVzLmNwcAppbmRleCAxMGI1ODFhLi5kOGZkOWRlIDEwMDY0NAotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKQEAgLTk5LDYgKzk5LDcgQEAgaW5saW5lIENh cGFiaWxpdHlMZXZlbCBjYW5Db21waWxlKE5vZGUqIG5vZGUpCiAgICAgY2FzZSBMb29wSGludDoK ICAgICBjYXNlIEdldE15U2NvcGU6CiAgICAgY2FzZSBTa2lwU2NvcGU6CisgICAgY2FzZSBTa2lw VG9wU2NvcGU6CiAgICAgY2FzZSBHZXRDbG9zdXJlUmVnaXN0ZXJzOgogICAgIGNhc2UgR2V0Q2xv c3VyZVZhcjoKICAgICBjYXNlIFB1dENsb3N1cmVWYXI6CmRpZmYgLS1naXQgU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKaW5kZXggNTNlZDYyOC4uOTIxYzY2NyAxMDA2NDQK LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcApAQCAtNTkyLDYg KzU5Miw5IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgU2tpcFNjb3BlOgogICAgICAgICAgICAg Y29tcGlsZVNraXBTY29wZSgpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgU2tp cFRvcFNjb3BlOgorICAgICAgICAgICAgY29tcGlsZVNraXBUb3BTY29wZSgpOworICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIGNhc2UgR2V0Q2xvc3VyZVJlZ2lzdGVyczoKICAgICAgICAgICAg IGNvbXBpbGVHZXRDbG9zdXJlUmVnaXN0ZXJzKCk7CiAgICAgICAgICAgICBicmVhazsKQEAgLTM0 MDMsNiArMzQwNiwzMiBAQCBwcml2YXRlOgogICAgICAgICBzZXRKU1ZhbHVlKG1fb3V0LmxvYWRQ dHIobG93Q2VsbChtX25vZGUtPmNoaWxkMSgpKSwgbV9oZWFwcy5KU1Njb3BlX25leHQpKTsKICAg ICB9CiAgICAgCisKKyAgICB2b2lkIGNvbXBpbGVTa2lwVG9wU2NvcGUoKQorICAgIHsKKyAgICAg ICAgTFZhbHVlIHNjb3BlID0gbG93Q2VsbChtX25vZGUtPmNoaWxkMSgpKTsKKworICAgICAgICBM QmFzaWNCbG9jayBpc051bGwgPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkFjdGl2YXRpb24gcmVn aXN0ZXIgaXMgbnVsbCIpKTsKKyAgICAgICAgTEJhc2ljQmxvY2sgbm90TnVsbCA9IEZUTF9ORVdf QkxPQ0sobV9vdXQsICgiQWN0aXZhdGlvbiByZWdpc3RlciBpcyBub3QgbnVsbCIpKTsKKworICAg ICAgICBWaXJ0dWFsUmVnaXN0ZXIgbWFjaGluZUFjdGl2YXRpb25SZWdpc3RlciA9IG1fZ3JhcGgu bWFjaGluZUFjdGl2YXRpb25SZWdpc3RlcigpOworCisgICAgICAgIFZhbHVlRnJvbUJsb2NrIHRv cCA9IG1fb3V0LmFuY2hvcihzY29wZSk7CisgICAgICAgIG1fb3V0LmJyYW5jaCgKKyAgICAgICAg ICAgIG1fb3V0LmlzWmVybzY0KCBtX291dC5sb2FkNjQoYWRkcmVzc0ZvcihtYWNoaW5lQWN0aXZh dGlvblJlZ2lzdGVyKSkpCisgICAgICAgICAgICAsIHVuc3VyZShpc051bGwpCisgICAgICAgICAg ICAsIHVuc3VyZShub3ROdWxsKSk7CisKKyAgICAgICAgTEJhc2ljQmxvY2sgbGFzdE5leHQgPSBt X291dC5hcHBlbmRUbyhpc051bGwsIG5vdE51bGwpOworICAgICAgICBWYWx1ZUZyb21CbG9jayBu ZXh0ID0gbV9vdXQuYW5jaG9yKG1fb3V0LmxvYWRQdHIoc2NvcGUsIG1faGVhcHMuSlNTY29wZV9u ZXh0KSk7CisKKyAgICAgICAgbV9vdXQuanVtcChub3ROdWxsKTsKKyAgICAgICAgbV9vdXQuYXBw ZW5kVG8obm90TnVsbCwgbGFzdE5leHQpOworCisgICAgICAgIHNldEpTVmFsdWUobV9vdXQucGhp KG1fb3V0LmludFB0ciwgdG9wLG5leHQpKTsKKyAgICB9CisgICAgCisKICAgICB2b2lkIGNvbXBp bGVHZXRDbG9zdXJlUmVnaXN0ZXJzKCkKICAgICB7CiAgICAgICAgIGlmIChXcml0ZUJhcnJpZXJC YXNlPFVua25vd24+KiByZWdpc3RlcnMgPSBtX2dyYXBoLnRyeUdldFJlZ2lzdGVycyhtX25vZGUt PmNoaWxkMSgpLm5vZGUoKSkpIHsKLS0gCjEuOC4zLjEgKEFwcGxlIEdpdC00NikKCg== 235024 2014-07-16 15:00:17 -0700 2014-07-29 13:32:03 -0700 [ftlopt] Added SkipTopScope coverage to FTL 0001-ftlopt-Added-SkipTopScope-coverage-to-FTL.patch text/plain 3156 mmirman RnJvbSA3NTJlOWNmNmE4YTgxMTNlYjE0NDg0MTJhNjgzMmQwOTJhOWQ0MzA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IE1pcm1hbiA8bW1pcm1hbkBhcHBsZS5jb20+CkRh dGU6IE1vbiwgMTQgSnVsIDIwMTQgMTQ6Mjg6MDggLTA3MDAKU3ViamVjdDogW1BBVENIXSBbZnRs b3B0XSBBZGRlZCBTa2lwVG9wU2NvcGUgY292ZXJhZ2UgdG8gRlRMCgoKZGlmZiAtLWdpdCBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKaW5kZXggMTI1NjUwOS4uODQxZmIwYyAxMDA2NDQKLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxNC0wNy0xNCAgTWF0dGhldyBNaXJtYW4gIDxtbWlybWFuQGFwcGxlLmNvbT4K KworICAgICAgICBbZnRsb3B0XSBBZGRlZCBTa2lwVG9wU2NvcGUgY292ZXJhZ2UgdG8gRlRMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ5OTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ0bC9GVExD YXBhYmlsaXRpZXMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNhbkNvbXBpbGUpOiAgQWRkZWQg Y2FzZSBmb3IgU2tpcFRvcFNjb3BlCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZU5vZGUpOiBBZGRl ZCBjYXNlIGZvciBTa2lwVG9wU2NvcGUKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExW TTo6Y29tcGlsZVNraXBUb3BTY29wZSk6IEFkZGVkLgorCiAyMDE0LTA3LTEzICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0IHVuaW50 ZW5kZWQgY2hhbmdlIGluIHIxNzEwNTEuCmRpZmYgLS1naXQgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ2Fw YWJpbGl0aWVzLmNwcAppbmRleCAxMGI1ODFhLi5kOGZkOWRlIDEwMDY0NAotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKQEAgLTk5LDYgKzk5LDcgQEAgaW5saW5lIENh cGFiaWxpdHlMZXZlbCBjYW5Db21waWxlKE5vZGUqIG5vZGUpCiAgICAgY2FzZSBMb29wSGludDoK ICAgICBjYXNlIEdldE15U2NvcGU6CiAgICAgY2FzZSBTa2lwU2NvcGU6CisgICAgY2FzZSBTa2lw VG9wU2NvcGU6CiAgICAgY2FzZSBHZXRDbG9zdXJlUmVnaXN0ZXJzOgogICAgIGNhc2UgR2V0Q2xv c3VyZVZhcjoKICAgICBjYXNlIFB1dENsb3N1cmVWYXI6CmRpZmYgLS1naXQgU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKaW5kZXggNTNlZDYyOC4uYTQ2OWQ2ZCAxMDA2NDQK LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcApAQCAtNTkyLDYg KzU5Miw5IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgU2tpcFNjb3BlOgogICAgICAgICAgICAg Y29tcGlsZVNraXBTY29wZSgpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgU2tp cFRvcFNjb3BlOgorICAgICAgICAgICAgY29tcGlsZVNraXBUb3BTY29wZSgpOworICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIGNhc2UgR2V0Q2xvc3VyZVJlZ2lzdGVyczoKICAgICAgICAgICAg IGNvbXBpbGVHZXRDbG9zdXJlUmVnaXN0ZXJzKCk7CiAgICAgICAgICAgICBicmVhazsKQEAgLTM0 MDMsNiArMzQwNiwzMCBAQCBwcml2YXRlOgogICAgICAgICBzZXRKU1ZhbHVlKG1fb3V0LmxvYWRQ dHIobG93Q2VsbChtX25vZGUtPmNoaWxkMSgpKSwgbV9oZWFwcy5KU1Njb3BlX25leHQpKTsKICAg ICB9CiAgICAgCisKKyAgICB2b2lkIGNvbXBpbGVTa2lwVG9wU2NvcGUoKQorICAgIHsKKyAgICAg ICAgTFZhbHVlIHNjb3BlID0gbG93Q2VsbChtX25vZGUtPmNoaWxkMSgpKTsKKworICAgICAgICBM QmFzaWNCbG9jayBpc051bGwgPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkFjdGl2YXRpb24gcmVn aXN0ZXIgaXMgbnVsbCIpKTsKKyAgICAgICAgTEJhc2ljQmxvY2sgbm90TnVsbCA9IEZUTF9ORVdf QkxPQ0sobV9vdXQsICgiQWN0aXZhdGlvbiByZWdpc3RlciBpcyBub3QgbnVsbCIpKTsKKworICAg ICAgICBWaXJ0dWFsUmVnaXN0ZXIgbWFjaGluZUFjdGl2YXRpb25SZWdpc3RlciA9IG1fZ3JhcGgu bWFjaGluZUFjdGl2YXRpb25SZWdpc3RlcigpOworCisgICAgICAgIFZhbHVlRnJvbUJsb2NrIHRv cCA9IG1fb3V0LmFuY2hvcihzY29wZSk7CisgICAgICAgIG1fb3V0LmJyYW5jaCgKKyAgICAgICAg ICAgIG1fb3V0LmlzWmVybzY0KG1fb3V0LmxvYWQ2NChhZGRyZXNzRm9yKG1hY2hpbmVBY3RpdmF0 aW9uUmVnaXN0ZXIpKSksIHVuc3VyZShpc051bGwpLCB1bnN1cmUobm90TnVsbCkpOworCisgICAg ICAgIExCYXNpY0Jsb2NrIGxhc3ROZXh0ID0gbV9vdXQuYXBwZW5kVG8oaXNOdWxsLCBub3ROdWxs KTsKKyAgICAgICAgVmFsdWVGcm9tQmxvY2sgbmV4dCA9IG1fb3V0LmFuY2hvcihtX291dC5sb2Fk UHRyKHNjb3BlLCBtX2hlYXBzLkpTU2NvcGVfbmV4dCkpOworCisgICAgICAgIG1fb3V0Lmp1bXAo bm90TnVsbCk7CisgICAgICAgIG1fb3V0LmFwcGVuZFRvKG5vdE51bGwsIGxhc3ROZXh0KTsKKwor ICAgICAgICBzZXRKU1ZhbHVlKG1fb3V0LnBoaShtX291dC5pbnRQdHIsIHRvcCwgbmV4dCkpOwor ICAgIH0KKyAgICAKKwogICAgIHZvaWQgY29tcGlsZUdldENsb3N1cmVSZWdpc3RlcnMoKQogICAg IHsKICAgICAgICAgaWYgKFdyaXRlQmFycmllckJhc2U8VW5rbm93bj4qIHJlZ2lzdGVycyA9IG1f Z3JhcGgudHJ5R2V0UmVnaXN0ZXJzKG1fbm9kZS0+Y2hpbGQxKCkubm9kZSgpKSkgewotLSAKMS44 LjMuMSAoQXBwbGUgR2l0LTQ2KQoK