134983 2014-07-16 10:06:59 -0700 [Mac] replace AVPlayerItem on the main thread 2014-07-16 16:12:16 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio oldest_to_newest 1022755 0 eric.carlson 2014-07-16 10:06:59 -0700 When starting up or pausing/resuming data loading, always replace the AVPlayerItem on the main thread. 1022756 1 eric.carlson 2014-07-16 10:07:26 -0700 <rdar://problem/17507145> 1022839 2 235026 eric.carlson 2014-07-16 15:11:15 -0700 Created attachment 235026 Proposed patch 1022858 3 235026 commit-queue 2014-07-16 16:12:13 -0700 Comment on attachment 235026 Proposed patch Clearing flags on attachment: 235026 Committed r171157: <http://trac.webkit.org/changeset/171157> 1022859 4 commit-queue 2014-07-16 16:12:16 -0700 All reviewed patches have been landed. Closing bug. 235026 2014-07-16 15:11:15 -0700 2014-07-16 16:12:12 -0700 Proposed patch patch_2.txt text/plain 4408 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTE0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA3LTE2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHJlcGxhY2Ug QVZQbGF5ZXJJdGVtIG9uIHRoZSBtYWluIHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0OTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGZpeGVzIGEgcHJvYmxl bSB3aXRoIGEgdGhyZWFkIGNvbmZpZ3VyYXRpb24gbm90IHByZXNlbnQgaW4gdGhlCisgICAgICAg IHRlc3QgZW52aXJvbm1lbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLmg6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakM6OnNldEFWUGxheWVySXRlbSk6IE5ldywgd2hlbiBjYWxsZWQgb2Zm IG9mIAorICAgICAgICAgICAgdGhlIG1haW4gdGhyZWFkLCBkaXNwYXRjaCB0byB0aGUgbWFpbiB0 aHJlYWQgYmVmb3JlIHNldHRpbmcgQVZQbGF5ZXJJdGVtLgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6Y3JlYXRlQVZQbGF5ZXIpOiBDYWxsIHNl dEFWUGxheWVySXRlbS4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91 bmRhdGlvbk9iakM6OmNyZWF0ZUFWUGxheWVySXRlbSk6IERpdHRvLgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6c2V0U2hvdWxkQnVmZmVyRGF0 YSk6IERpdHRvLgorCiAyMDE0LTA3LTE2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBzdm46ZXhlY3V0YWJsZSBwcm9wZXJ0eSBlcnJvbmVvdXNs eSBhZGRlZCBpbiA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTcxMTQ0PiBzb21l aG93LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMuaAkocmV2aXNpb24gMTcxMTE1KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMDUsNiArMjA1 LDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc3luY1RleHRUcmFja0JvdW5kcygpIG92 ZXJyaWRlOwogI2VuZGlmCiAKKyAgICB2b2lkIHNldEFWUGxheWVySXRlbShBVlBsYXllckl0ZW0g Kik7CisKICAgICB2b2lkIGNyZWF0ZUltYWdlR2VuZXJhdG9yKCk7CiAgICAgdm9pZCBkZXN0cm95 SW1hZ2VHZW5lcmF0b3IoKTsKICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gY3JlYXRlSW1hZ2VG b3JUaW1lSW5SZWN0KGZsb2F0LCBjb25zdCBJbnRSZWN0Jik7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVB VkZvdW5kYXRpb25PYmpDLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakMubW0JKHJldmlzaW9uIDE3MTExNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwNiw2ICsxMDYsNyBAQCBAaW50ZXJmYWNlIEFWVVJM QXNzZXQgKFdlYktpdEV4dGVuc2lvbnMpCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkp IE5TVVJMICpyZXNvbHZlZFVSTDsKIEBlbmQKIAordHlwZWRlZiBBVlBsYXllciBBVlBsYXllclR5 cGU7CiB0eXBlZGVmIEFWUGxheWVySXRlbSBBVlBsYXllckl0ZW1UeXBlOwogdHlwZWRlZiBBVk1l dGFkYXRhSXRlbSBBVk1ldGFkYXRhSXRlbVR5cGU7CiAKQEAgLTc2Myw2ICs3NjQsMjMgQEAgdm9p ZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOgogICAgIHNldERlbGF5Q2FsbGJh Y2tzKGZhbHNlKTsKIH0KIAordm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD OjpzZXRBVlBsYXllckl0ZW0oQVZQbGF5ZXJJdGVtVHlwZSAqaXRlbSkKK3sKKyAgICBpZiAoIW1f YXZQbGF5ZXIpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChwdGhyZWFkX21haW5fbnAoKSkg eworICAgICAgICBbbV9hdlBsYXllciByZXBsYWNlQ3VycmVudEl0ZW1XaXRoUGxheWVySXRlbTpp dGVtXTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIFJldGFpblB0cjxBVlBsYXllclR5 cGU+IHN0cm9uZ1BsYXllciA9IG1fYXZQbGF5ZXIuZ2V0KCk7CisgICAgUmV0YWluUHRyPEFWUGxh eWVySXRlbVR5cGU+IHN0cm9uZ0l0ZW0gPSBpdGVtOworICAgIGRpc3BhdGNoX2FzeW5jKGRpc3Bh dGNoX2dldF9tYWluX3F1ZXVlKCksIFtzdHJvbmdQbGF5ZXIsIHN0cm9uZ0l0ZW1dIHsKKyAgICAg ICAgW3N0cm9uZ1BsYXllciByZXBsYWNlQ3VycmVudEl0ZW1XaXRoUGxheWVySXRlbTpzdHJvbmdJ dGVtLmdldCgpXTsKKyAgICB9KTsKK30KKwogdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDOjpjcmVhdGVBVlBsYXllcigpCiB7CiAgICAgaWYgKG1fYXZQbGF5ZXIpCkBAIC03 OTEsNyArODA5LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOgog ICAgICAgICBjcmVhdGVBVlBsYXllckxheWVyKCk7CiAKICAgICBpZiAobV9hdlBsYXllckl0ZW0p Ci0gICAgICAgIFttX2F2UGxheWVyLmdldCgpIHJlcGxhY2VDdXJyZW50SXRlbVdpdGhQbGF5ZXJJ dGVtOm1fYXZQbGF5ZXJJdGVtLmdldCgpXTsKKyAgICAgICAgc2V0QVZQbGF5ZXJJdGVtKG1fYXZQ bGF5ZXJJdGVtLmdldCgpKTsKIAogICAgIHNldERlbGF5Q2FsbGJhY2tzKGZhbHNlKTsKIH0KQEAg LTgxNSw3ICs4MzMsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 CiAgICAgICAgIFttX2F2UGxheWVySXRlbS5nZXQoKSBhZGRPYnNlcnZlcjptX29iamNPYnNlcnZl ci5nZXQoKSBmb3JLZXlQYXRoOmtleU5hbWUgb3B0aW9uczpvcHRpb25zIGNvbnRleHQ6KHZvaWQg KilNZWRpYVBsYXllckFWRm91bmRhdGlvbk9ic2VydmF0aW9uQ29udGV4dFBsYXllckl0ZW1dOwog CiAgICAgaWYgKG1fYXZQbGF5ZXIpCi0gICAgICAgIFttX2F2UGxheWVyLmdldCgpIHJlcGxhY2VD dXJyZW50SXRlbVdpdGhQbGF5ZXJJdGVtOm1fYXZQbGF5ZXJJdGVtLmdldCgpXTsKKyAgICAgICAg c2V0QVZQbGF5ZXJJdGVtKG1fYXZQbGF5ZXJJdGVtLmdldCgpKTsKIAogI2lmIFBMQVRGT1JNKElP UykKICAgICBBdG9taWNTdHJpbmcgdmFsdWU7CkBAIC0yMzk4LDEwICsyNDE2LDcgQEAgdm9pZCBN ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOgogICAgIGlmICghbV9hdlBsYXllcikK ICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG1fc2hvdWxkQnVmZmVyRGF0YSkKLSAgICAgICAg W21fYXZQbGF5ZXIuZ2V0KCkgcmVwbGFjZUN1cnJlbnRJdGVtV2l0aFBsYXllckl0ZW06bV9hdlBs YXllckl0ZW0uZ2V0KCldOwotICAgIGVsc2UKLSAgICAgICAgW21fYXZQbGF5ZXIuZ2V0KCkgcmVw bGFjZUN1cnJlbnRJdGVtV2l0aFBsYXllckl0ZW06bmlsXTsKKyAgICBzZXRBVlBsYXllckl0ZW0o c2hvdWxkQnVmZmVyID8gbV9hdlBsYXllckl0ZW0uZ2V0KCkgOiBuaWwpOwogfQogCiAjaWYgRU5B QkxFKERBVEFDVUVfVkFMVUUpCg==