<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134979</bug_id>
          
          <creation_ts>2014-07-16 09:31:19 -0700</creation_ts>
          <short_desc>REGRESSION(r171004): [GTK] 6 Layout test on media/track/track* fail</short_desc>
          <delta_ts>2023-01-25 19:32:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>calvaris</cc>
    
    <cc>changseok</cc>
    
    <cc>chavarria1991</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1022740</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-07-16 09:31:19 -0700</bug_when>
    <thetext>Revision r171004 &lt;http://trac.webkit.org/r171004&gt; has caused 6 failures on the media/track layout tests on the GTK port:


Regressions: Unexpected text-only failures (6)
  media/track/track-cue-mutable-text.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-mutable-text-pretty-diff.html
  media/track/track-cue-nothing-to-render.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-nothing-to-render-pretty-diff.html
  media/track/track-cue-rendering-mode-changed.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-mode-changed-pretty-diff.html
  media/track/track-cue-rendering-rtl.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-rtl-pretty-diff.html
  media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-snap-to-lines-not-set-pretty-diff.html
  media/track/track-kind.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-kind-pretty-diff.html

I double-checked that r171004 caused this: I tested to revert r171004 locally and the tests pass as expected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1022745</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-07-16 09:34:30 -0700</bug_when>
    <thetext>We probably need to add something like this to the generic &quot;MediaControls.css&quot; file: &lt;http://trac.webkit.org/changeset/171004/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css&gt;

This additional &lt;div&gt; around the &lt;span&gt; might also be breaking the test you cited. You probably need to modify the test slightly so that it grabs the innerText from the right element.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1022932</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-07-16 20:08:41 -0700</bug_when>
    <thetext>I have marked this test as failing on the GTK TestExpectations on r171169 &lt;http://trac.webkit.org/r171169&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1085102</commentid>
    <comment_count>3</comment_count>
    <who name="Marcos Chavarría Teijeiro (irc: chavaone)">chavarria1991</who>
    <bug_when>2015-04-14 04:25:20 -0700</bug_when>
    <thetext>The layout test media/track/track-cue-rendering-mode-changed.html is flaky now and it timeouts sometimes.

Updating GTK test expectations on bug 143701.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1162608</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-02-06 07:55:53 -0800</bug_when>
    <thetext>Seems that media/track/track-kind.html was fixed by r195511. The other media track tests are still broken.

Calvaris, ChangeSeok, this seems related to your recent work; is this something you&apos;d be interested in looking into?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1163391</commentid>
    <comment_count>5</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2016-02-09 21:43:10 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Seems that media/track/track-kind.html was fixed by r195511. The other media
&gt; track tests are still broken.
&gt; 
&gt; Calvaris, ChangeSeok, this seems related to your recent work; is this
&gt; something you&apos;d be interested in looking into?

No idea, let me look into it when I am available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1928426</commentid>
    <comment_count>6</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-01-25 19:32:07 -0800</bug_when>
    <thetext>There are no references to this bug in any TestExpectations. It&apos;s probable this bug was solved at some point but it wasn&apos;t marked as closed. I&apos;m closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>