<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134976</bug_id>
          
          <creation_ts>2014-07-16 08:50:40 -0700</creation_ts>
          <short_desc>REGRESSION(r171033) [GTK] media/media-controls-invalid-url.html and media/video-fast-seek.html fail</short_desc>
          <delta_ts>2023-01-25 19:35:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>calvaris</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>jer.noble</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>Ms2ger</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1022732</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-07-16 08:50:40 -0700</bug_when>
    <thetext>Revision r171033 &lt;http://trac.webkit.org/r171033&gt; has caused the 2 following tests to fail on the GTK port:

  media/media-controls-invalid-url.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r171040%20%281383%29/media/media-controls-invalid-url-pretty-diff.html
  media/video-fast-seek.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r171040%20%281383%29/media/video-fast-seek-pretty-diff.html


It also has caused the following diff on the test http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html : http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r171040%20%281383%29/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-pretty-diff.html 
But I understand this last one only needs to be rebaselined.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1022930</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-07-16 20:07:37 -0700</bug_when>
    <thetext>I double checked this: I tested to locally revert r171033 and this two test pass again.

I have marked this two test as failing on the GTK TestExpectations, as also rebaselined the test http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html on r171169 &lt;http://trac.webkit.org/r171169&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1240835</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-16 18:33:10 -0700</bug_when>
    <thetext>media/media-controls-invalid-url.html is now timing out as well. Updating expectations accordingly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340568</commentid>
    <comment_count>3</comment_count>
    <who name="Ms2ger (he/him; ⌚ UTC+1/+2)">Ms2ger</who>
    <bug_when>2017-08-21 04:45:07 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #0)
&gt; Revision r171033 &lt;http://trac.webkit.org/r171033&gt; has caused the 2 following
&gt; tests to fail on the GTK port:
&gt; 
&gt;   media/media-controls-invalid-url.html [ Failure ]

Current result:

This tests that media element controls are reset to their default state when the src is changed to an invalid url.

This test only runs in DRT!


EVENT(canplaythrough)
EXPECTED (getTimeLineValue() == &apos;0&apos;) OK
EVENT(seeked)
EXPECTED (getTimeLineValue() == &apos;1&apos;) OK
EVENT(error)
EXPECTED (getTimeLineValue() == &apos;0&apos;), OBSERVED &apos;1&apos; FAIL
END OF TEST


Two problems here:

- We don&apos;t update the displayed duration after an error event.
- Even if we did update it from the error handler, the failing check runs before mediaControls&apos;s error handler. (A setTimeout(0) in the test would probably be enough to fix that, though.)

Also note that the test fails the same way on mac: bug 67716.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340569</commentid>
    <comment_count>4</comment_count>
      <attachid>318627</attachid>
    <who name="Ms2ger (he/him; ⌚ UTC+1/+2)">Ms2ger</who>
    <bug_when>2017-08-21 04:46:54 -0700</bug_when>
    <thetext>Created attachment 318627
Reduced test case for media-controls-invalid-url.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1340664</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2017-08-21 11:38:44 -0700</bug_when>
    <thetext>(In reply to Ms2ger from comment #3)
&gt; 
&gt; Two problems here:
&gt; 
&gt; - We don&apos;t update the displayed duration after an error event.
&gt; - Even if we did update it from the error handler, the failing check runs
&gt; before mediaControls&apos;s error handler. (A setTimeout(0) in the test would
&gt; probably be enough to fix that, though.)
&gt; 
&gt; Also note that the test fails the same way on mac: bug 67716.

This test now passes on macOS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1928425</commentid>
    <comment_count>6</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-01-25 19:32:00 -0800</bug_when>
    <thetext>There are no references to this bug in any TestExpectations. It&apos;s probable this bug was solved at some point but it wasn&apos;t marked as closed. I&apos;m closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1928455</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-01-25 19:35:04 -0800</bug_when>
    <thetext>&lt;rdar://problem/104678737&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>318627</attachid>
            <date>2017-08-21 04:46:54 -0700</date>
            <delta_ts>2017-08-21 04:46:54 -0700</delta_ts>
            <desc>Reduced test case for media-controls-invalid-url.html</desc>
            <filename>test.html</filename>
            <type>text/html</type>
            <size>270</size>
            <attacher name="Ms2ger (he/him; ⌚ UTC+1/+2)">Ms2ger</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+Cjx2aWRlbyBzcmM9aHR0cDovL3czYy10ZXN0Lm9yZy9tZWRpYS9ncmVl
bi1hdC0xNS5tcDQgY29udHJvbHMgaGVpZ2h0PTEwMCB3aWR0aD01MDA+PC92aWRlbz4KPHNjcmlw
dD4KdmFyIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoInZpZGVvIilbMF07
CnZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoImNhbnBsYXl0aHJvdWdoIiwgZnVuY3Rpb24oKSB7CiAg
dmlkZW8uc3JjID0gIi9pbnZhbGlkLm1vdiI7Cn0pOwo8L3NjcmlwdD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>