134972 2014-07-16 07:21:01 -0700 REGRESSION(r170529): [GTK] Performance test Animation/balls:FrameRate got ~10% worse 2014-07-22 08:02:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22gtk%22%2C%22Animation%2Fballs%3AFrameRate%22%5D%5D&days=44 P2 Normal --- 1 clopez clopez andrunko cgarcia commit-queue gustavo jdapena mrobinson pnormand rego yoon zan oldest_to_newest 1022716 0 clopez 2014-07-16 07:21:01 -0700 On Platform GTK the revision r170529 <http://trac.webkit.org/r170529> caused a performance regression around ~10% on the test Animation/balls. You can check the performance graph at https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22gtk%22%2C%22Animation%2Fballs%3AFrameRate%22%5D%5D&days=44 (we identified r170529 as the commit causing the regression on the interval r170529-r170540 after a manual bisect) The overall performance is still very poor in this test: Around 5 FPS. Comparing with the other ports: EFL gets around ~10FPS, and MAC ports around ~30FPS. Zan Dobersek (CC'ed) identified an issue with the GTK port and this test: DrawingArea is not entering the accelerated compositing codepaths. He tried to force-enable the accelerated compositing path, and the animations in the benchmark became much more fluent, but the test is still only reporting ~10FPS. Then he tried to revert r170529 and the FPS jumped to 20FPS. So, it seems that r170529 is causing a significative performance regression on this test. You can run the test as follows: Tools/Scripts/run-perf-tests --release -2 Animation/balls.html If you want to see the animation: USE_NATIVE_XDISPLAY=1 Tools/Scripts/run-perf-tests --release -2 Animation/balls.html 1022721 1 clopez 2014-07-16 07:59:06 -0700 BTW, the test is self-contained. You can run it in any browser by opening: http://trac.webkit.org/export/171143/trunk/PerformanceTests/Animation/balls.html or file://${path-to-webkit}/PerformanceTests/Animation/balls.html 1022734 2 andrunko 2014-07-16 09:02:32 -0700 See https://bugs.webkit.org/show_bug.cgi?id=134109#c8. 1023935 3 235283 clopez 2014-07-22 04:29:27 -0700 Created attachment 235283 Patch 1023954 4 235283 commit-queue 2014-07-22 08:02:38 -0700 Comment on attachment 235283 Patch Clearing flags on attachment: 235283 Committed r171343: <http://trac.webkit.org/changeset/171343> 1023955 5 commit-queue 2014-07-22 08:02:44 -0700 All reviewed patches have been landed. Closing bug. 235283 2014-07-22 04:29:27 -0700 2014-07-22 08:02:36 -0700 Patch bug-134972-20140722132911.patch text/plain 1614 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRiODFkNDMwMzE2MjFi MWVlYzkwMGVlN2ZiMGM1ZWEyOTBlZDlkMi4uNmUzMDJjN2M1NTM4ZDE0ODhkNzlmMGRjZGVlNjIz YjE4YjdmMjM1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTIyICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIFJvbGxvdXQgcjE3MDUyOSBkdWUgdG8gfjEwJSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIG9u IHRoZQorICAgICAgICBwZXJmIHRlc3QgQW5pbWF0aW9uL2JhbGxzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0OTcyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorICAg ICAgICAiSW5jcmVhc2UgcHJpb3JpdHkgb24gU2hhcmVkVGltZXIgc291cmNlLiIKKyAgICAgICAg aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvcjE3MDUyOQorCiAyMDE0LTA3LTIyICBBZHJpYW4gUGVy ZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0g W0dUS10gV2ViS2l0IGRvZXMgbm90IGJ1aWxkIHdpdGggR1N0cmVhbWVyIDEuNApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TaGFyZWRUaW1lckd0ay5jcHAKaW5kZXggNzdhY2I5OGY0 Zjg0MWM0NmIxOTI5NjdkMDRhYjllYjk0ODk0ZGFjOC4uZWM5MGZkNDMyZGRjNjU3NTgzNTE2MjE1 NjFlOTJkOGM4NzVjNzFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1NoYXJlZFRpbWVyR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hh cmVkVGltZXJHdGsuY3BwCkBAIC00OCw3ICs0OCw3IEBAIHZvaWQgc2V0U2hhcmVkVGltZXJGaXJl SW50ZXJ2YWwoZG91YmxlIGludGVydmFsKQogICAgIEFTU0VSVChzaGFyZWRUaW1lckZpcmVkRnVu Y3Rpb24pOwogCiAgICAgZ1NoYXJlZFRpbWVyLnNjaGVkdWxlQWZ0ZXJEZWxheSgiW1dlYktpdF0g c2hhcmVkVGltZXJUaW1lb3V0Q2FsbGJhY2siLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oc2hhcmVk VGltZXJGaXJlZEZ1bmN0aW9uKSwKLSAgICAgICAgc3RkOjpjaHJvbm86OmR1cmF0aW9uX2Nhc3Q8 c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcz4oc3RkOjpjaHJvbm86OmR1cmF0aW9uPGRvdWJsZT4o aW50ZXJ2YWwpKSwgR19QUklPUklUWV9ERUZBVUxUKTsKKyAgICAgICAgc3RkOjpjaHJvbm86OmR1 cmF0aW9uX2Nhc3Q8c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcz4oc3RkOjpjaHJvbm86OmR1cmF0 aW9uPGRvdWJsZT4oaW50ZXJ2YWwpKSwgR0RLX1BSSU9SSVRZX1JFRFJBVyk7CiB9CiAKIHZvaWQg c3RvcFNoYXJlZFRpbWVyKCkK