134967 2014-07-16 02:32:36 -0700 Change style check path with EFL WK2's path in checker_unittest.py 2014-07-16 04:21:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue glenn gyuyoung.kim oldest_to_newest 1022683 0 gyuyoung.kim 2014-07-16 02:32:36 -0700 There is a style check failure in webkitpy tests due to the EFL WK1 path. [859/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed: Traceback (most recent call last): File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier "readability/naming") File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck self.assertFalse(config.should_check(category, path), message) AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h". 1022684 1 234985 gyuyoung.kim 2014-07-16 02:33:31 -0700 Created attachment 234985 Patch 1022693 2 234989 gyuyoung.kim 2014-07-16 03:02:24 -0700 Created attachment 234989 Patch 1022703 3 234989 ossy 2014-07-16 03:45:12 -0700 Comment on attachment 234989 Patch rs=me 1022707 4 234989 commit-queue 2014-07-16 04:21:12 -0700 Comment on attachment 234989 Patch Clearing flags on attachment: 234989 Committed r171142: <http://trac.webkit.org/changeset/171142> 1022708 5 commit-queue 2014-07-16 04:21:17 -0700 All reviewed patches have been landed. Closing bug. 234985 2014-07-16 02:33:31 -0700 2014-07-16 03:02:14 -0700 Patch bug-134967-20140716183315.patch text/plain 1533 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTM2ZTE2Nzc4YWZjMjU4Mzk2NDYwZDIxNGMwMjBmZWRl YzJiODVhYy4uZjA4YzA4NTE5MWFmMTAzMGIyNzBlMGFlMDI3MzAwMWIzNmFlNmU1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA3LTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgQ2hhbmdlIHN0eWxlIGNoZWNrIHBhdGggd2l0aCBFRkwgV0syJ3MgcGF0aCBp biBjaGVja2VyX3VuaXR0ZXN0LnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzQ5NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5w eTogQ2hhbmdlIGV3a192aWV3LmggcGF0aC4KKyAgICAgICAgKEdsb2JhbFZhcmlhYmxlc1Rlc3Qu dGVzdF9wYXRoX3J1bGVzX3NwZWNpZmllcik6CisKIDIwMTQtMDctMTUgIFJ5dWFuIENob2kgIDxy eXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFJlbW92ZSBFRkwgV0sxIGRp cmVjdG9yeSBmcm9tIHRoZSBjaGVja2VyLnB5CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkKaW5kZXggZjNmM2M2MDQxNzRjZjFmNjk1NTU3MzQ2 NjMwODY2ZDM4MzNmM2VmZS4uYjEzMDc3NjlmYzZjZGIyYmE1NjMxZGQ1OGZjYzFmNWY2MjMxNTVj OSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVz dC5weQpAQCAtMjIxLDcgKzIyMSw3IEBAIGNsYXNzIEdsb2JhbFZhcmlhYmxlc1Rlc3QodW5pdHRl c3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9uYW1pbmci KQogICAgICAgICBhc3NlcnROb0NoZWNrKCJUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJl bmRlclRyZWUuY3BwIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbnVsbCIp Ci0gICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5o IiwKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3ZpZXcuaCIsCiAgICAgICAgICAgICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWlu ZyIpCiAgICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikK 234989 2014-07-16 03:02:24 -0700 2014-07-16 04:21:12 -0700 Patch bug-134967-20140716190207.patch text/plain 1533 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTM2ZTE2Nzc4YWZjMjU4Mzk2NDYwZDIxNGMwMjBmZWRl YzJiODVhYy4uZjA4YzA4NTE5MWFmMTAzMGIyNzBlMGFlMDI3MzAwMWIzNmFlNmU1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA3LTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgQ2hhbmdlIHN0eWxlIGNoZWNrIHBhdGggd2l0aCBFRkwgV0syJ3MgcGF0aCBp biBjaGVja2VyX3VuaXR0ZXN0LnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzQ5NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5w eTogQ2hhbmdlIGV3a192aWV3LmggcGF0aC4KKyAgICAgICAgKEdsb2JhbFZhcmlhYmxlc1Rlc3Qu dGVzdF9wYXRoX3J1bGVzX3NwZWNpZmllcik6CisKIDIwMTQtMDctMTUgIFJ5dWFuIENob2kgIDxy eXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFJlbW92ZSBFRkwgV0sxIGRp cmVjdG9yeSBmcm9tIHRoZSBjaGVja2VyLnB5CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkKaW5kZXggZjNmM2M2MDQxNzRjZjFmNjk1NTU3MzQ2 NjMwODY2ZDM4MzNmM2VmZS4uYjEzMDc3NjlmYzZjZGIyYmE1NjMxZGQ1OGZjYzFmNWY2MjMxNTVj OSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVz dC5weQpAQCAtMjIxLDcgKzIyMSw3IEBAIGNsYXNzIEdsb2JhbFZhcmlhYmxlc1Rlc3QodW5pdHRl c3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9uYW1pbmci KQogICAgICAgICBhc3NlcnROb0NoZWNrKCJUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJl bmRlclRyZWUuY3BwIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbnVsbCIp Ci0gICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5o IiwKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3ZpZXcuaCIsCiAgICAgICAgICAgICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWlu ZyIpCiAgICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikK