134961 2014-07-15 19:43:43 -0700 [iOS] Fix touches inside accelerated overflow:scroll 2014-07-16 18:11:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1022637 0 simon.fraser 2014-07-15 19:43:43 -0700 [iOS] Fix touches inside accelerated overflow:scroll 1022639 1 234976 simon.fraser 2014-07-15 19:47:55 -0700 Created attachment 234976 Patch 1022640 2 simon.fraser 2014-07-15 19:48:21 -0700 <rdar://problem/16088789> 1022641 3 234976 benjamin 2014-07-15 19:55:06 -0700 Comment on attachment 234976 Patch I am not a fan, but it is not the right time for changing the architecture. 1022642 4 simon.fraser 2014-07-15 19:58:57 -0700 https://trac.webkit.org/r171132 1022889 5 234976 darin 2014-07-16 18:02:55 -0700 Comment on attachment 234976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234976&action=review > Source/WebCore/rendering/RenderBox.cpp:2113 > +static inline bool shouldAppyContainersClipAndOffset(const RenderLayerModelObject* repaintContainer, RenderBox* containerBox) Typo here: "Appy" instead of "Apply". 1022895 6 simon.fraser 2014-07-16 18:11:08 -0700 Fixed in https://trac.webkit.org/r171163 234976 2014-07-15 19:47:55 -0700 2014-07-16 18:02:55 -0700 Patch bug-134961-20140715194737.patch text/plain 3663 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU3M2E2ZDI5ZDA4ZDg1 YzgyMTIxY2NjMWY0ZjA3NGExMTI2MGU1Mi4uY2Y2NTc2ZjQ5ZDU1MzljZTU1ZTEzM2NhYzA2YjQ0 OTNjYjdjODhiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE0LTA3LTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIEZpeCB0 b3VjaGVzIGluc2lkZSBhY2NlbGVyYXRlZCBvdmVyZmxvdzpzY3JvbGwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDk2MQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTYwODg3ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2hlbiBpbmRpdmlkdWFsIGVsZW1lbnRzIGluc2lkZSBhbiBvdmVyZmxvdzpz Y3JvbGwgd2l0aCAtd2Via2l0LW92ZXJmbG93LXNjcm9sbGluZzogdG91Y2gKKyAgICAgICAgaGFk IHRvdWNoIGV2ZW50IGxpc3RlbmVycywgd2Ugd291bGQgZmFpbCB0byB0YWtlIHRoZSBzY3JvbGwg b2Zmc2V0IGludG8gYWNjb3VudCB3aGVuCisgICAgICAgIGJ1aWxkaW5nIHRoZSB0b3VjaCBldmVu dCByZWdpb24sIGNhdXNpbmcgdG91Y2hlcyBvbiB0aG9zZSBlbGVtZW50cyB0byBmYWlsIGFmdGVy IHNjcm9sbGluZy4KKyAgICAgICAgCisgICAgICAgIFRvdWNoIGV2ZW50IHJlZ2lvbiBidWlsZGlu ZyB1c2VzIFJlbmRlck9iamVjdDo6YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCksIGFuZCB0 aGF0CisgICAgICAgIGNvZGUgcGF0aCB0cmllcyB0byBmaXggdXAgcmVwYWludCByZWN0cyB0byB3 b3JrIGNvcnJlY3RseSBpbiBjb21wb3NpdGVkIG92ZXJmbG93OnNjcm9sbC4KKyAgICAgICAgSG93 ZXZlciwgdGhhdCBicm9rZSB0aGUgdG91Y2ggcmVnaW9uIGNvbXB1dGF0aW9uLgorICAgICAgICAK KyAgICAgICAgRml4IGJ5IG9ubHkgaWdub3JpbmcgdGhlIHNjcm9sbCBvZmZzZXQgZm9yIGNhbGxz IHRvIGNvbXB1dGVSZWN0Rm9yUmVwYWludCgpIHdoaWNoCisgICAgICAgIGhhdmUgYSBub24tbnVs bCByZXBhaW50Q29udGFpbmVyICh3aGljaCBpbmRpY2F0ZXMgdGhhdCB3ZSdyZSBkb2luZyBhIHJl cGFpbnQgaW4gdGhlCisgICAgICAgIGNvbXBvc2l0aW5nIGxheWVyKSwgYW5kIGZvciB3aGljaCB0 aGUgcmVwYWludENvbnRhaW5lciBpcyB0aGUgY29udGFpbmluZyBibG9jaworICAgICAgICB3aGlj aCBpcyB1c2luZyBjb21wb3NpdGVkIHNjcm9sbGluZy4gVGhpcyByZXN0b3JlcyBjb3JyZWN0IGJl aGF2aW9yIHRvIHRoZSBldmVudCByZWdpb24KKyAgICAgICAgY29kZSB3aGljaCBhbHdheXMgY2Fs bHMgdGhpcyB3aXRoIGEgbnVsbCByZXBhaW50Q29udGFpbmVyLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRBcHB5Q29udGFpbmVy c0NsaXBBbmRPZmZzZXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpjb21wdXRlUmVj dEZvclJlcGFpbnQpOgorCisyMDE0LTA3LTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgorCiAgICAgICAgIFtpT1NdIEZpeCBpc3N1ZXMgZHJhd2luZyBzdWJzYW1wbGVk IGltYWdlIGVsZW1lbnRzIGFuZCBDU1MgaW1hZ2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ5NDQKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3 NjM0MDk1PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBkOTE5YjFh MDgyNmIxNmI2Mjg3OTZjYTVlYWY5YzM0Zjk5MWQ0MTM3Li5iMTFiZmRmZGI5YzI4ZmJhZmY3MjFi ZmRiOGQ3ODlkNDJhODg4ZTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cApAQCAtMjExMCw2ICsyMTEwLDE4IEBAIExheW91dFJlY3QgUmVuZGVyQm94OjpjbGlwcGVkT3Zl cmZsb3dSZWN0Rm9yUmVwYWludChjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0CiAgICAgcmV0 dXJuIHI7CiB9CiAKK3N0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRBcHB5Q29udGFpbmVyc0NsaXBB bmRPZmZzZXQoY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5lciwg UmVuZGVyQm94KiBjb250YWluZXJCb3gpCit7CisjaWYgUExBVEZPUk0oSU9TKQorICAgIGlmICgh cmVwYWludENvbnRhaW5lciB8fCByZXBhaW50Q29udGFpbmVyICE9IGNvbnRhaW5lckJveCkKKyAg ICAgICAgcmV0dXJuIHRydWU7CisKKyAgICByZXR1cm4gIWNvbnRhaW5lckJveC0+aGFzTGF5ZXIo KSB8fCAhY29udGFpbmVyQm94LT5sYXllcigpLT51c2VzQ29tcG9zaXRlZFNjcm9sbGluZygpOwor I2Vsc2UKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorfQorCiB2b2lkIFJlbmRlckJveDo6Y29t cHV0ZVJlY3RGb3JSZXBhaW50KGNvbnN0IFJlbmRlckxheWVyTW9kZWxPYmplY3QqIHJlcGFpbnRD b250YWluZXIsIExheW91dFJlY3QmIHJlY3QsIGJvb2wgZml4ZWQpIGNvbnN0CiB7CiAgICAgLy8g VGhlIHJlY3Qgd2UgY29tcHV0ZSBhdCBlYWNoIHN0ZXAgaXMgc2hpZnRlZCBieSBvdXIgeC95IG9m ZnNldCBpbiB0aGUgcGFyZW50IGNvbnRhaW5lcidzIGNvb3JkaW5hdGUgc3BhY2UuCkBAIC0yMjAw LDE1ICsyMjEyLDExIEBAIHZvaWQgUmVuZGVyQm94Ojpjb21wdXRlUmVjdEZvclJlcGFpbnQoY29u c3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogcmVwYWludENvbnRhCiAgICAgcmVjdC5zZXRMb2Nh dGlvbih0b3BMZWZ0KTsKICAgICBpZiAoby0+aGFzT3ZlcmZsb3dDbGlwKCkpIHsKICAgICAgICAg UmVuZGVyQm94KiBjb250YWluZXJCb3ggPSB0b1JlbmRlckJveChvKTsKLSNpZiBQTEFURk9STShJ T1MpCi0gICAgICAgIGlmICghY29udGFpbmVyQm94LT5sYXllcigpIHx8ICFjb250YWluZXJCb3gt PmxheWVyKCktPnVzZXNDb21wb3NpdGVkU2Nyb2xsaW5nKCkpIHsKLSNlbmRpZgotICAgICAgICBj b250YWluZXJCb3gtPmFwcGx5Q2FjaGVkQ2xpcEFuZFNjcm9sbE9mZnNldEZvclJlcGFpbnQocmVj dCk7Ci0gICAgICAgIGlmIChyZWN0LmlzRW1wdHkoKSkKLSAgICAgICAgICAgIHJldHVybjsKLSNp ZiBQTEFURk9STShJT1MpCi0gICAgICAgIH0gCi0jZW5kaWYKKyAgICAgICAgaWYgKHNob3VsZEFw cHlDb250YWluZXJzQ2xpcEFuZE9mZnNldChyZXBhaW50Q29udGFpbmVyLCBjb250YWluZXJCb3gp KSB7CisgICAgICAgICAgICBjb250YWluZXJCb3gtPmFwcGx5Q2FjaGVkQ2xpcEFuZFNjcm9sbE9m ZnNldEZvclJlcGFpbnQocmVjdCk7CisgICAgICAgICAgICBpZiAocmVjdC5pc0VtcHR5KCkpCisg ICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKGNvbnRh aW5lclNraXBwZWQpIHsK