<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134957</bug_id>
          
          <creation_ts>2014-07-15 18:52:48 -0700</creation_ts>
          <short_desc>Adding myself to contributors.json breaks a webkitpy test.</short_desc>
          <delta_ts>2014-07-15 18:54:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1022622</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-07-15 18:52:48 -0700</bug_when>
    <thetext>I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter.

However, doing it breaks a test of webkitpy:

$ Tools/Scripts/test-webkitpy
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

Checking imports .../home/clopez/webkit/webkit
[809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed:                                                             
  Traceback (most recent call last):
    File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py&quot;, line 56, in test_whois
      whois.execute(&quot;tom&quot;, [&quot;lopez&quot;], None, None))
  AssertionError: &apos;tom: lopez is &quot;Xan Lopez&quot; &lt;xan.lopez@gmail.com&gt; (:xan) (r). Why do you ask?&apos; != u&apos;tom: I\&apos;m not sure who you mean?  &quot;Carlos Alberto Lopez Perez&quot; &lt;clopez@igalia.com&gt; (:clopez) (c) or &quot;Xan Lopez&quot; &lt;xan.lopez@gmail.com&gt; (:xan) (r) could be \&apos;lopez\&apos;.&apos;
  
Ran 1424 tests in 3.843s                                                                              
FAILED (failures=1, errors=0)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>