134928 2014-07-15 10:38:22 -0700 ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks 2014-07-15 12:12:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 1022506 0 mhahnenberg 2014-07-15 10:38:22 -0700 Executable::forEachCodeBlock doesn't check for null CodeBlocks in the ProgramExecutable and EvalExecutable cases, so if the CodeBlock has been cleared from either of these Executables we'll crash when dereferencing null inside whatever functor was passed. 1022508 1 234937 mhahnenberg 2014-07-15 10:40:23 -0700 Created attachment 234937 Patch 1022514 2 234937 kling 2014-07-15 11:02:03 -0700 Comment on attachment 234937 Patch r=me 1022534 3 234937 commit-queue 2014-07-15 12:12:24 -0700 Comment on attachment 234937 Patch Clearing flags on attachment: 234937 Committed r171108: <http://trac.webkit.org/changeset/171108> 1022535 4 commit-queue 2014-07-15 12:12:27 -0700 All reviewed patches have been landed. Closing bug. 234937 2014-07-15 10:40:23 -0700 2014-07-15 12:12:24 -0700 Patch bug-134928-20140715104007.patch text/plain 1786 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxMTA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA3LTE1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU2NyaXB0RXhlY3V0YWJsZTo6Zm9yRWFjaENvZGVCbG9jayBjYW4gZGVyZWZlcmVu Y2UgbnVsbCBDb2RlQmxvY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzQ5MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpTY3JpcHRF eGVjdXRhYmxlOjpmb3JFYWNoQ29kZUJsb2NrKTogQ2hlY2sgZm9yIG51bGwgQ29kZUJsb2NrcyBi ZWZvcmUgY2FsbGluZyBmb3JFYWNoUmVsYXRlZENvZGVCbG9jay4KKwogMjAxNC0wNy0xNSAgRXZh IEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAg ICAgIEJ1aWxkZml4IGlmIExMSU5UX1NMT1dfUEFUSF9UUkFDSU5HIGlzIGVuYWJsZWQKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJKHJldmlzaW9uIDE3 MTEwNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkod29y a2luZyBjb3B5KQpAQCAtMTI4MiwxMiArMTI4MiwxNCBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgRnVu Y3Rvcj4gaW5saW5lIHZvaWQgCiB7CiAgICAgc3dpdGNoICh0eXBlKCkpIHsKICAgICBjYXNlIFBy b2dyYW1FeGVjdXRhYmxlVHlwZTogewotICAgICAgICBqc0Nhc3Q8UHJvZ3JhbUV4ZWN1dGFibGUq Pih0aGlzKS0+bV9wcm9ncmFtQ29kZUJsb2NrLT5mb3JFYWNoUmVsYXRlZENvZGVCbG9jayhzdGQ6 OmZvcndhcmQ8RnVuY3Rvcj4oZnVuY3RvcikpOworICAgICAgICBpZiAoQ29kZUJsb2NrKiBjb2Rl QmxvY2sgPSBqc0Nhc3Q8UHJvZ3JhbUV4ZWN1dGFibGUqPih0aGlzKS0+bV9wcm9ncmFtQ29kZUJs b2NrLmdldCgpKQorICAgICAgICAgICAgY29kZUJsb2NrLT5mb3JFYWNoUmVsYXRlZENvZGVCbG9j ayhzdGQ6OmZvcndhcmQ8RnVuY3Rvcj4oZnVuY3RvcikpOwogICAgICAgICBicmVhazsKICAgICB9 CiAgICAgICAgIAogICAgIGNhc2UgRXZhbEV4ZWN1dGFibGVUeXBlOiB7Ci0gICAgICAgIGpzQ2Fz dDxFdmFsRXhlY3V0YWJsZSo+KHRoaXMpLT5tX2V2YWxDb2RlQmxvY2stPmZvckVhY2hSZWxhdGVk Q29kZUJsb2NrKHN0ZDo6Zm9yd2FyZDxGdW5jdG9yPihmdW5jdG9yKSk7CisgICAgICAgIGlmIChD b2RlQmxvY2sqIGNvZGVCbG9jayA9IGpzQ2FzdDxFdmFsRXhlY3V0YWJsZSo+KHRoaXMpLT5tX2V2 YWxDb2RlQmxvY2suZ2V0KCkpCisgICAgICAgICAgICBjb2RlQmxvY2stPmZvckVhY2hSZWxhdGVk Q29kZUJsb2NrKHN0ZDo6Zm9yd2FyZDxGdW5jdG9yPihmdW5jdG9yKSk7CiAgICAgICAgIGJyZWFr OwogICAgIH0KICAgICAgICAgCg==