134909 2014-07-14 16:06:57 -0700 Fix crash on WebVideoFullscreenManagerProxy construction. 2014-07-14 19:15:50 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson glenn jer.noble philipj sergio oldest_to_newest 1022344 0 jeremyj-wk 2014-07-14 16:06:57 -0700 Fix crash on WebVideoFullscreenManagerProxy construction. 1022346 1 234886 jeremyj-wk 2014-07-14 16:12:05 -0700 Created attachment 234886 Patch 1022366 2 234894 jeremyj-wk 2014-07-14 17:04:50 -0700 Created attachment 234894 Patch 1022377 3 234898 jeremyj-wk 2014-07-14 17:45:32 -0700 Created attachment 234898 Patch 1022378 4 jeremyj-wk 2014-07-14 17:46:40 -0700 Fix crash introduced by: https://bugs.webkit.org/show_bug.cgi?id=134890 1022396 5 234898 commit-queue 2014-07-14 19:15:46 -0700 Comment on attachment 234898 Patch Clearing flags on attachment: 234898 Committed r171099: <http://trac.webkit.org/changeset/171099> 1022397 6 commit-queue 2014-07-14 19:15:50 -0700 All reviewed patches have been landed. Closing bug. 234886 2014-07-14 16:12:05 -0700 2014-07-14 17:04:47 -0700 Patch bug-134909-20140714161147.patch text/plain 1996 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcwNTFjYjlhMjZlMTRk YzhmZDFhYTZjZWU3NzBhNGNmNmU0NDJjNy4uZmYxYjBlMDU4ODg1N2ZjNjE4MjkzNWI2NzEzZWU4 NzMxNmY0OGQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA3LTE0ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggY3Jhc2ggb24gV2Vi VmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5IGNvbnN0cnVjdGlvbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDkwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBkaXNw YXRjaCB0byBtYWluIHF1ZXVlIHNpbmNlIGl0IGNhbiBoYXBwZW4gZHVyaW5nIGNvbnN0cnVjdGlv bi4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdC5tbToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXRX ZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbCk6IHJlbW92ZSBkaXNwYXRjaF9hc3luYworCisyMDE0LTA3 LTE0ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdCBzaG91bGQgb25seSBjYWxsIHRoZSBVSSBmcm9tIG1h aW4gdGhyZWFkLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM0ODkwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCA3ODU3YmQwZDFl MjZiNzM3NGYxZThhOWE3OGI4OTI5MTVmZDYwYTU1Li5lYmIwMTQxZTljM2VhNGRmOWM4Y2UzYjBm ZWE4ZDFlOWE4ZjdlNjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC01ODUs MTQgKzU4NSw3IEBAIFdlYkFWUGxheWVyQ29udHJvbGxlciAqV2ViVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQ6OnBsYXllckNvbnRyb2xsZXIoKQogdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdDo6c2V0V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWwoV2ViVmlkZW9GdWxsc2Ny ZWVuTW9kZWwqIG1vZGVsKQogewogICAgIG1fdmlkZW9GdWxsc2NyZWVuTW9kZWwgPSBtb2RlbDsK LSAgICBfX2Jsb2NrIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdD4gcHJv dGVjdCh0aGlzKTsKLSAgICAKLSAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9x dWV1ZSgpLCBeewotICAgICAgICBpZiAobV9wbGF5ZXJDb250cm9sbGVyKQotICAgICAgICAgICAg cGxheWVyQ29udHJvbGxlcigpLmRlbGVnYXRlID0gbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbDsKLSAg ICAgICAgCi0gICAgICAgIHByb3RlY3QuY2xlYXIoKTsKLSAgICB9KTsKKyAgICBbbV9wbGF5ZXJD b250cm9sbGVyIHNldERlbGVnYXRlOm1fdmlkZW9GdWxsc2NyZWVuTW9kZWxdOwogfQogCiB2b2lk IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXRXZWJWaWRlb0Z1bGxzY3JlZW5D aGFuZ2VPYnNlcnZlcihXZWJWaWRlb0Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciogb2JzZXJ2ZXIp Cg== 234894 2014-07-14 17:04:50 -0700 2014-07-14 17:45:29 -0700 Patch bug-134909-20140714170433.patch text/plain 1996 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcwNTFjYjlhMjZlMTRk YzhmZDFhYTZjZWU3NzBhNGNmNmU0NDJjNy4uZmYxYjBlMDU4ODg1N2ZjNjE4MjkzNWI2NzEzZWU4 NzMxNmY0OGQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA3LTE0ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggY3Jhc2ggb24gV2Vi VmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5IGNvbnN0cnVjdGlvbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDkwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBkaXNw YXRjaCB0byBtYWluIHF1ZXVlIHNpbmNlIGl0IGNhbiBoYXBwZW4gZHVyaW5nIGNvbnN0cnVjdGlv bi4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdC5tbToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXRX ZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbCk6IHJlbW92ZSBkaXNwYXRjaF9hc3luYworCisyMDE0LTA3 LTE0ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdCBzaG91bGQgb25seSBjYWxsIHRoZSBVSSBmcm9tIG1h aW4gdGhyZWFkLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM0ODkwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCA3ODU3YmQwZDFl MjZiNzM3NGYxZThhOWE3OGI4OTI5MTVmZDYwYTU1Li5lYmIwMTQxZTljM2VhNGRmOWM4Y2UzYjBm ZWE4ZDFlOWE4ZjdlNjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC01ODUs MTQgKzU4NSw3IEBAIFdlYkFWUGxheWVyQ29udHJvbGxlciAqV2ViVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQ6OnBsYXllckNvbnRyb2xsZXIoKQogdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdDo6c2V0V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWwoV2ViVmlkZW9GdWxsc2Ny ZWVuTW9kZWwqIG1vZGVsKQogewogICAgIG1fdmlkZW9GdWxsc2NyZWVuTW9kZWwgPSBtb2RlbDsK LSAgICBfX2Jsb2NrIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdD4gcHJv dGVjdCh0aGlzKTsKLSAgICAKLSAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9x dWV1ZSgpLCBeewotICAgICAgICBpZiAobV9wbGF5ZXJDb250cm9sbGVyKQotICAgICAgICAgICAg cGxheWVyQ29udHJvbGxlcigpLmRlbGVnYXRlID0gbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbDsKLSAg ICAgICAgCi0gICAgICAgIHByb3RlY3QuY2xlYXIoKTsKLSAgICB9KTsKKyAgICBbbV9wbGF5ZXJD b250cm9sbGVyIHNldERlbGVnYXRlOm1fdmlkZW9GdWxsc2NyZWVuTW9kZWxdOwogfQogCiB2b2lk IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXRXZWJWaWRlb0Z1bGxzY3JlZW5D aGFuZ2VPYnNlcnZlcihXZWJWaWRlb0Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciogb2JzZXJ2ZXIp Cg== 234898 2014-07-14 17:45:32 -0700 2014-07-14 19:15:46 -0700 Patch bug-134909-20140714174515.patch text/plain 2002 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcwNTFjYjlhMjZlMTRk YzhmZDFhYTZjZWU3NzBhNGNmNmU0NDJjNy4uODYyNDdlOTg5ZWYxZmQyZGYwMDlkYjE4Y2FlYzEy MWY1ZDMxYTkxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA3LTE0ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggY3Jhc2ggb24gV2Vi VmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5IGNvbnN0cnVjdGlvbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDkwOQorCisgICAgICAgIFVucmV2 aWV3ZWQgZml4IGNyYXNoIGZyb20gcjE3MTA4OQorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2Fy eSBkaXNwYXRjaCB0byBtYWluIHF1ZXVlIHNpbmNlIGl0IGNhbiBoYXBwZW4gZHVyaW5nIGNvbnN0 cnVjdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdC5tbToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 OjpzZXRXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbCk6IHJlbW92ZSBkaXNwYXRjaF9hc3luYworCisy MDE0LTA3LTE0ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdCBzaG91bGQgb25seSBjYWxsIHRoZSBVSSBm cm9tIG1haW4gdGhyZWFkLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM0ODkwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCA3ODU3 YmQwZDFlMjZiNzM3NGYxZThhOWE3OGI4OTI5MTVmZDYwYTU1Li5lYmIwMTQxZTljM2VhNGRmOWM4 Y2UzYjBmZWE4ZDFlOWE4ZjdlNjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBA IC01ODUsMTQgKzU4NSw3IEBAIFdlYkFWUGxheWVyQ29udHJvbGxlciAqV2ViVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ6OnBsYXllckNvbnRyb2xsZXIoKQogdm9pZCBXZWJWaWRlb0Z1bGxz Y3JlZW5JbnRlcmZhY2VBVktpdDo6c2V0V2ViVmlkZW9GdWxsc2NyZWVuTW9kZWwoV2ViVmlkZW9G dWxsc2NyZWVuTW9kZWwqIG1vZGVsKQogewogICAgIG1fdmlkZW9GdWxsc2NyZWVuTW9kZWwgPSBt b2RlbDsKLSAgICBfX2Jsb2NrIFJlZlB0cjxXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktp dD4gcHJvdGVjdCh0aGlzKTsKLSAgICAKLSAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRf bWFpbl9xdWV1ZSgpLCBeewotICAgICAgICBpZiAobV9wbGF5ZXJDb250cm9sbGVyKQotICAgICAg ICAgICAgcGxheWVyQ29udHJvbGxlcigpLmRlbGVnYXRlID0gbV92aWRlb0Z1bGxzY3JlZW5Nb2Rl bDsKLSAgICAgICAgCi0gICAgICAgIHByb3RlY3QuY2xlYXIoKTsKLSAgICB9KTsKKyAgICBbbV9w bGF5ZXJDb250cm9sbGVyIHNldERlbGVnYXRlOm1fdmlkZW9GdWxsc2NyZWVuTW9kZWxdOwogfQog CiB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXRXZWJWaWRlb0Z1bGxz Y3JlZW5DaGFuZ2VPYnNlcnZlcihXZWJWaWRlb0Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlciogb2Jz ZXJ2ZXIpCg==