134898 2014-07-14 13:49:24 -0700 [iOS] Some HLS videos play as inline audio-only content 2014-07-14 14:22:48 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED InRadar P1 Normal --- 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1022299 0 bfulgham 2014-07-14 13:49:24 -0700 If video playback starts in low-bandwidth, audio-only mode, certain media players do not show the playback controls. We need to proper advertise that the media element is in "audio" mode, and make sure we do not improperly switch to the inline media element style. 1022301 1 bfulgham 2014-07-14 13:54:17 -0700 <rdar://problem/17629379> 1022302 2 234877 bfulgham 2014-07-14 13:55:05 -0700 Created attachment 234877 Patch 1022311 3 bfulgham 2014-07-14 14:22:48 -0700 Committed r171081: <http://trac.webkit.org/changeset/171081> 234877 2014-07-14 13:55:05 -0700 2014-07-14 13:57:54 -0700 Patch bug-134898-20140714135449.patch text/plain 6326 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTA3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA3LTE0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFNvbWUgdmlkZW9z IHBsYXkgYXMgaW5saW5lIGF1ZGlvLW9ubHkgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0ODk4LgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTc2MjkzNzk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgbmV3ICdwcmVzZW50YXRpb25UeXBlJyBhY2Nlc3NvciB0aGF0IGluZGljYXRl cyBpZiB0aGUgbWVkaWEKKyAgICAgICAgZWxlbWVudCBpcyBwbGF5aW5nIGluICdhdWRpbycgbW9k ZS4gVGhpcyBjYW4gaGFwcGVuIGlmIGEgdmlkZW8KKyAgICAgICAgZWxlbWVudCBwbGF5cyBhbiBI TFMgc3RyZWFtIHRoYXQgc3RhcnRzIG9mZiBpbiBhdWRpby1vbmx5IG1vZGUuCisKKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6cHJlc2VudGF0aW9uVHlwZSk6IEFkZGVkLgorICAgICAgICAqIGh0bWwvSFRNTE1l ZGlhRWxlbWVudC5oOgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL01lZGlhU2Vzc2lvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb246OnByZXNlbnRhdGlvblR5cGUpOiBBZGRl ZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb24uaDoKKyAgICAgICAgKiBw bGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcDogCisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVNlc3Npb25NYW5hZ2VyOjpzZXNzaW9uUmVzdHJpY3RzSW5saW5lVmlkZW9QbGF5YmFj ayk6CisgICAgICAgIFVzZSB0aGUgcHJlc2VudGF0aW9uVHlwZSwgcmF0aGVyIHRoYW4gdGhlIG1l ZGlhVHlwZSB0byBjb250cm9sCisgICAgICAgIGlubGluZSBwbGF5YmFjayBiZWhhdmlvci4KKyAg ICAgICAgKiBwbGF0Zm9ybS9hdWRpby9pb3MvQXVkaW9EZXN0aW5hdGlvbklPUy5oOgorICAgICAg ICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbk1hYzo6cHJlc2VudGF0aW9uVHlwZSk6IEFkZCBw cmVzZW50YXRpb25UeXBlLgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb0Rlc3Rp bmF0aW9uTWFjLmg6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0aW9uTWFjOjpwcmVz ZW50YXRpb25UeXBlKTogRGl0dG8uCisKIDIwMTQtMDctMTQgIEJlYXIgVHJhdmlzICA8YmV0cmF2 aXNAYWRvYmUuY29tPgogCiAgICAgICAgIFtGZWF0dXJlIFF1ZXJpZXNdIEVuYWJsZSBGZWF0dXJl IFF1ZXJpZXMgb24gTWFjCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHJldmlzaW9uIDE3MTA2NykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5MzksNiArNTkzOSwxNCBAQCBNZWRpYVNl c3Npb246Ok1lZGlhVHlwZSBIVE1MTWVkaWFFbGVtZW50CiAgICAgcmV0dXJuIE1lZGlhU2Vzc2lv bjo6QXVkaW87CiB9CiAKK01lZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIEhUTUxNZWRpYUVsZW1lbnQ6 OnByZXNlbnRhdGlvblR5cGUoKSBjb25zdAoreworICAgIGlmIChoYXNUYWdOYW1lKEhUTUxOYW1l czo6dmlkZW9UYWcpKQorICAgICAgICByZXR1cm4gTWVkaWFTZXNzaW9uOjpWaWRlbzsKKworICAg IHJldHVybiBNZWRpYVNlc3Npb246OkF1ZGlvOworfQorCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnBhdXNlUGxheWJhY2soKQogewogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OnBh dXNlUGxheWJhY2sgLSBwYXVzZWQgPSAlcyIsIGJvb2xTdHJpbmcocGF1c2VkKCkpKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCShyZXZpc2lvbiAxNzEwNjcpCisr KyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpA QCAtNjg1LDYgKzY4NSw3IEBAIHByaXZhdGU6CiAKICAgICAvLyBNZWRpYVNlc3Npb25DbGllbnQg T3ZlcnJpZGVzCiAgICAgdmlydHVhbCBNZWRpYVNlc3Npb246Ok1lZGlhVHlwZSBtZWRpYVR5cGUo KSBjb25zdCBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIE1lZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIHBy ZXNlbnRhdGlvblR5cGUoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgcGF1c2VQ bGF5YmFjaygpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCByZXN1bWVQbGF5YmFjaygpIG92 ZXJyaWRlOwogICAgIHZpcnR1YWwgU3RyaW5nIG1lZGlhU2Vzc2lvblRpdGxlKCkgY29uc3Qgb3Zl cnJpZGU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL01lZGlhU2Vz c2lvbi5jcHAJKHJldmlzaW9uIDE3MTA2NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL01lZGlhU2Vzc2lvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MCw2ICsxNDAsMTEgQEAg TWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgTWVkaWFTZXNzaW9uOjptZQogICAgIHJldHVybiBtX2Ns aWVudC5tZWRpYVR5cGUoKTsKIH0KIAorTWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgTWVkaWFTZXNz aW9uOjpwcmVzZW50YXRpb25UeXBlKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9jbGllbnQucHJl c2VudGF0aW9uVHlwZSgpOworfQorCiBTdHJpbmcgTWVkaWFTZXNzaW9uOjp0aXRsZSgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuIG1fY2xpZW50Lm1lZGlhU2Vzc2lvblRpdGxlKCk7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb24uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb24uaAkocmV2aXNpb24gMTcx MDY3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uLmgJKHdv cmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDcgQEAgcHVibGljOgogICAgICAgICBXZWJBdWRpbywK ICAgICB9OwogICAgIE1lZGlhVHlwZSBtZWRpYVR5cGUoKSBjb25zdDsKKyAgICBNZWRpYVR5cGUg cHJlc2VudGF0aW9uVHlwZSgpIGNvbnN0OwogCiAgICAgZW51bSBTdGF0ZSB7CiAgICAgICAgIElk bGUsCkBAIC0xMTUsNiArMTE2LDggQEAgcHVibGljOgogICAgIE1lZGlhU2Vzc2lvbkNsaWVudCgp IHsgfQogICAgIAogICAgIHZpcnR1YWwgTWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgbWVkaWFUeXBl KCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgTWVkaWFTZXNzaW9uOjpNZWRpYVR5cGUgcHJlc2Vu dGF0aW9uVHlwZSgpIGNvbnN0ID0gMDsKKwogICAgIHZpcnR1YWwgdm9pZCByZXN1bWVQbGF5YmFj aygpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcGF1c2VQbGF5YmFjaygpID0gMDsKIApJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFuYWdlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uTWFu YWdlci5jcHAJKHJldmlzaW9uIDE3MTA2NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjMsNyArMjYz LDcgQEAgTWVkaWFTZXNzaW9uKiBNZWRpYVNlc3Npb25NYW5hZ2VyOjpjdXJyZQogICAgIAogYm9v bCBNZWRpYVNlc3Npb25NYW5hZ2VyOjpzZXNzaW9uUmVzdHJpY3RzSW5saW5lVmlkZW9QbGF5YmFj ayhjb25zdCBNZWRpYVNlc3Npb24mIHNlc3Npb24pIGNvbnN0CiB7Ci0gICAgTWVkaWFTZXNzaW9u OjpNZWRpYVR5cGUgc2Vzc2lvblR5cGUgPSBzZXNzaW9uLm1lZGlhVHlwZSgpOworICAgIE1lZGlh U2Vzc2lvbjo6TWVkaWFUeXBlIHNlc3Npb25UeXBlID0gc2Vzc2lvbi5wcmVzZW50YXRpb25UeXBl KCk7CiAgICAgaWYgKHNlc3Npb25UeXBlICE9IE1lZGlhU2Vzc2lvbjo6VmlkZW8pCiAgICAgICAg IHJldHVybiBmYWxzZTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9z L0F1ZGlvRGVzdGluYXRpb25JT1MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9pb3MvQXVkaW9EZXN0aW5hdGlvbklPUy5oCShyZXZpc2lvbiAxNzEwNjcpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9pb3MvQXVkaW9EZXN0aW5hdGlvbklPUy5o CSh3b3JraW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw3IEBAIHByaXZhdGU6CiAKICAgICAvLyBNZWRp YVNlc3Npb25DbGllbnQKICAgICB2aXJ0dWFsIE1lZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIG1lZGlh VHlwZSgpIGNvbnN0IHsgcmV0dXJuIE1lZGlhU2Vzc2lvbjo6V2ViQXVkaW87IH0KKyAgICB2aXJ0 dWFsIE1lZGlhU2Vzc2lvbjo6TWVkaWFUeXBlIHByZXNlbnRhdGlvblR5cGUoKSBjb25zdCB7IHJl dHVybiBNZWRpYVNlc3Npb246OldlYkF1ZGlvOyB9CiAgICAgdmlydHVhbCBib29sIGNhblJlY2Vp dmVSZW1vdGVDb250cm9sQ29tbWFuZHMoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZp cnR1YWwgdm9pZCBkaWRSZWNlaXZlUmVtb3RlQ29udHJvbENvbW1hbmQoTWVkaWFTZXNzaW9uOjpS ZW1vdGVDb250cm9sQ29tbWFuZFR5cGUpIHsgfQogICAgIHZpcnR1YWwgYm9vbCBvdmVycmlkZUJh Y2tncm91bmRQbGF5YmFja1Jlc3RyaWN0aW9uKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb0Rlc3RpbmF0aW9uTWFj LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlv RGVzdGluYXRpb25NYWMuaAkocmV2aXNpb24gMTcxMDY3KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vbWFjL0F1ZGlvRGVzdGluYXRpb25NYWMuaAkod29ya2luZyBjb3B5KQpAQCAt NTMsNiArNTMsNyBAQCBwcml2YXRlOgogICAgIE9TU3RhdHVzIHJlbmRlcihVSW50MzIgbnVtYmVy T2ZGcmFtZXMsIEF1ZGlvQnVmZmVyTGlzdCogaW9EYXRhKTsKIAogICAgIHZpcnR1YWwgTWVkaWFT ZXNzaW9uOjpNZWRpYVR5cGUgbWVkaWFUeXBlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gTWVk aWFTZXNzaW9uOjpXZWJBdWRpbzsgfQorICAgIHZpcnR1YWwgTWVkaWFTZXNzaW9uOjpNZWRpYVR5 cGUgcHJlc2VudGF0aW9uVHlwZSgpIGNvbnN0IHsgcmV0dXJuIE1lZGlhU2Vzc2lvbjo6V2ViQXVk aW87IH0KICAgICB2aXJ0dWFsIGJvb2wgY2FuUmVjZWl2ZVJlbW90ZUNvbnRyb2xDb21tYW5kcygp IGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZFJl Y2VpdmVSZW1vdGVDb250cm9sQ29tbWFuZChNZWRpYVNlc3Npb246OlJlbW90ZUNvbnRyb2xDb21t YW5kVHlwZSkgb3ZlcnJpZGUgeyB9CiAgICAgdmlydHVhbCBib29sIG92ZXJyaWRlQmFja2dyb3Vu ZFBsYXliYWNrUmVzdHJpY3Rpb24oKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBmYWxzZTsgfQo=