134887 2014-07-14 11:24:46 -0700 REGRESSION (r171045): Reproducible crash on navigation in PageClientImpl::willRecordNavigationSnapshot 2014-07-14 11:33:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz oldest_to_newest 1022262 0 mitz 2014-07-14 11:24:46 -0700 <rdar://problem/17664217> 1022263 1 234868 mitz 2014-07-14 11:27:17 -0700 Created attachment 234868 Add nil checks 1022264 2 mitz 2014-07-14 11:33:18 -0700 Fixed in <http://trac.webkit.org/r171070>. 234868 2014-07-14 11:27:17 -0700 2014-07-14 11:31:36 -0700 Add nil checks bug-134887-20140714112700.patch text/plain 2866 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTA2OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTE0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE3MTA0NSk6 IFJlcHJvZHVjaWJsZSBjcmFzaCBvbiBuYXZpZ2F0aW9uIGluIFBhZ2VDbGllbnRJbXBsOjp3aWxs UmVjb3JkTmF2aWdhdGlvblNuYXBzaG90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzQ4ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW06CisgICAg ICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKTog bmlsLWNoZWNrIG1fd2ViVmlldy4gSXQgY2FuIGJlIG5pbCB3aGVuCisgICAgICAgIHRoZSBjbGll bnQgaXMgdXNpbmcgV0tWaWV3IGRpcmVjdGx5LgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50 SW1wbDo6bmF2aWdhdGlvbkdlc3R1cmVXaWxsRW5kKTogRGl0dG8uCisgICAgICAgIChXZWJLaXQ6 OlBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZURpZEVuZCk6IERpdHRvLgorICAgICAg ICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6d2lsbFJlY29yZE5hdmlnYXRpb25TbmFwc2hvdCk6 IERpdHRvLgorCiAyMDE0LTA3LTE0ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFtNYWNdIGRvbid0IGVuYWJsZSBsb3cgcG93ZXIgYXVkaW8gbW9kZSBv biBleHRlcm5hbCBvdXRwdXQgZGV2aWNlcwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9QYWdlQ2xpZW50SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiAxNzEwNjQpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCSh3b3JraW5nIGNvcHkpCkBA IC02OTAsMTQgKzY5MCwxNiBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpiZWdhbkV4aXRGdWxsU2Ny ZWVuCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKCkKIHsK ICNpZiBXS19BUElfRU5BQkxFRAotICAgIE5hdmlnYXRpb25TdGF0ZTo6ZnJvbVdlYlBhZ2UoKm1f d2ViVmlldy0+X3BhZ2UpLm5hdmlnYXRpb25HZXN0dXJlRGlkQmVnaW4oKTsKKyAgICBpZiAobV93 ZWJWaWV3KQorICAgICAgICBOYXZpZ2F0aW9uU3RhdGU6OmZyb21XZWJQYWdlKCptX3dlYlZpZXct Pl9wYWdlKS5uYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKCk7CiAjZW5kaWYKIH0KIAogdm9pZCBQ YWdlQ2xpZW50SW1wbDo6bmF2aWdhdGlvbkdlc3R1cmVXaWxsRW5kKGJvb2wgd2lsbE5hdmlnYXRl LCBXZWJCYWNrRm9yd2FyZExpc3RJdGVtJiBpdGVtKQogewogI2lmIFdLX0FQSV9FTkFCTEVECi0g ICAgTmF2aWdhdGlvblN0YXRlOjpmcm9tV2ViUGFnZSgqbV93ZWJWaWV3LT5fcGFnZSkubmF2aWdh dGlvbkdlc3R1cmVXaWxsRW5kKHdpbGxOYXZpZ2F0ZSwgaXRlbSk7CisgICAgaWYgKG1fd2ViVmll dykKKyAgICAgICAgTmF2aWdhdGlvblN0YXRlOjpmcm9tV2ViUGFnZSgqbV93ZWJWaWV3LT5fcGFn ZSkubmF2aWdhdGlvbkdlc3R1cmVXaWxsRW5kKHdpbGxOYXZpZ2F0ZSwgaXRlbSk7CiAjZWxzZQog ICAgIFVOVVNFRF9QQVJBTSh3aWxsTmF2aWdhdGUpOwogICAgIFVOVVNFRF9QQVJBTShpdGVtKTsK QEAgLTcwNyw3ICs3MDksOCBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVy ZVdpCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZURpZEVuZChib29sIHdp bGxOYXZpZ2F0ZSwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYgaXRlbSkKIHsKICNpZiBXS19BUElf RU5BQkxFRAotICAgIE5hdmlnYXRpb25TdGF0ZTo6ZnJvbVdlYlBhZ2UoKm1fd2ViVmlldy0+X3Bh Z2UpLm5hdmlnYXRpb25HZXN0dXJlRGlkRW5kKHdpbGxOYXZpZ2F0ZSwgaXRlbSk7CisgICAgaWYg KG1fd2ViVmlldykKKyAgICAgICAgTmF2aWdhdGlvblN0YXRlOjpmcm9tV2ViUGFnZSgqbV93ZWJW aWV3LT5fcGFnZSkubmF2aWdhdGlvbkdlc3R1cmVEaWRFbmQod2lsbE5hdmlnYXRlLCBpdGVtKTsK ICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKHdpbGxOYXZpZ2F0ZSk7CiAgICAgVU5VU0VEX1BBUkFN KGl0ZW0pOwpAQCAtNzE3LDcgKzcyMCw4IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6Om5hdmlnYXRp b25HZXN0dXJlRGkKIHZvaWQgUGFnZUNsaWVudEltcGw6OndpbGxSZWNvcmROYXZpZ2F0aW9uU25h cHNob3QoV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYgaXRlbSkKIHsKICNpZiBXS19BUElfRU5BQkxF RAotICAgIE5hdmlnYXRpb25TdGF0ZTo6ZnJvbVdlYlBhZ2UoKm1fd2ViVmlldy0+X3BhZ2UpLndp bGxSZWNvcmROYXZpZ2F0aW9uU25hcHNob3QoaXRlbSk7CisgICAgaWYgKG1fd2ViVmlldykKKyAg ICAgICAgTmF2aWdhdGlvblN0YXRlOjpmcm9tV2ViUGFnZSgqbV93ZWJWaWV3LT5fcGFnZSkud2ls bFJlY29yZE5hdmlnYXRpb25TbmFwc2hvdChpdGVtKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFN KGl0ZW0pOwogI2VuZGlmCg==