134856 2014-07-12 11:16:34 -0700 [iOS] update control type when playback state changes 2014-07-12 15:15:09 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson webkit-unassigned calvaris commit-queue dino glenn jer.noble philipj sergio oldest_to_newest 1021980 0 eric.carlson 2014-07-12 11:16:34 -0700 The iOS media controls potentially have two modes: a big play button that sits in the middle of the <video> and inline controls. On devices that allow inline playback, the big play button is always shown and the inline controller is supposed to show once playback begins. Currently the control type is only checked/changed when readyState changes, so it is possible to get stuck with the overlay button if readyState reaches loadeddata before playback begins. 1021988 1 234805 eric.carlson 2014-07-12 11:42:01 -0700 Created attachment 234805 Proposed patch I wasn't able to come up with a reliable test because the problem this patch fixes is extremely timing dependent. 1022000 2 234805 commit-queue 2014-07-12 15:15:06 -0700 Comment on attachment 234805 Proposed patch Clearing flags on attachment: 234805 Committed r171032: <http://trac.webkit.org/changeset/171032> 1022001 3 commit-queue 2014-07-12 15:15:09 -0700 All reviewed patches have been landed. Closing bug. 234805 2014-07-12 11:42:01 -0700 2014-07-12 15:15:05 -0700 Proposed patch patch_2.txt text/plain 2412 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTAyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA3LTEyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIHVwZGF0ZSBj b250cm9sIHR5cGUgd2hlbiBwbGF5YmFjayBzdGF0ZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ4NTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0byBtYWtlIHN1cmUgdGhlIGNv cnJlY3QgdHlwZSBvZiBtZWRpYSBjb250cm9scyBhcmUgc2hvd2luZyB3aGVuIHBsYXliYWNrIHN0 YXRlCisgICAgICAgIGNoYW5nZXMgc28gd2UgZG9uJ3QgZW5kIHVwIHdpdGggdGhlIHdyb25nIHR5 cGUgb2YgY29udHJvbHMgZHVyaW5nIHBsYXliYWNrLgorCisgICAgICAgICogTW9kdWxlcy9tZWRp YWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczogCisgICAgICAgIChDb250cm9sbGVyLnBy b3RvdHlwZS5IYW5kbGVkVmlkZW9FdmVudHMpOiBEcml2ZS1ieSBmaXgsIGNhbGwgaGFuZGxlUGxh eSBvbiAncGxheWluZycgaW5zdGVhZAorICAgICAgICAgICAgb2YgJ3BsYXknIHNvIGNvbnRyb2xz IGRvbid0IGhpZGUgdG9vIGVhcmx5LgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzaU9TLmpzOgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuc2V0 UGxheWluZyk6IE5ldywgY2FsbCB1cGRhdGVDb250cm9scyB0byBtYWtlIHN1cmUgaW5saW5lCisg ICAgICAgICAgICBjb250cm9scyBhcmUgc2hvd24gd2hlbiBhcHByb3ByaWF0ZS4KKwogMjAxNC0w Ny0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UGFydGl0aW9uIHRoZSBDU1MgcnVsZXMgYmFzZWQgb24gdGhlIG1vc3Qgc3BlY2lmaWMgZmlsdGVy IG9mIHRoZSByaWdodG1vc3QgZnJhZ21lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkocmV2 aXNpb24gMTcwOTkwKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtNTgsNyArNTgsNyBAQCBDb250 cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgY2FucGxheXRocm91Z2g6ICdoYW5kbGVSZWFk eVN0YXRlQ2hhbmdlJywKICAgICAgICAgdGltZXVwZGF0ZTogJ2hhbmRsZVRpbWVVcGRhdGUnLAog ICAgICAgICBkdXJhdGlvbmNoYW5nZTogJ2hhbmRsZUR1cmF0aW9uQ2hhbmdlJywKLSAgICAgICAg cGxheTogJ2hhbmRsZVBsYXknLAorICAgICAgICBwbGF5aW5nOiAnaGFuZGxlUGxheScsCiAgICAg ICAgIHBhdXNlOiAnaGFuZGxlUGF1c2UnLAogICAgICAgICBwcm9ncmVzczogJ2hhbmRsZVByb2dy ZXNzJywKICAgICAgICAgdm9sdW1lY2hhbmdlOiAnaGFuZGxlVm9sdW1lQ2hhbmdlJywKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp YUNvbnRyb2xzaU9TLmpzCShyZXZpc2lvbiAxNzA5OTApCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwkod29ya2luZyBjb3B5KQpAQCAt NDI5LDYgKzQyOSwxMiBAQCBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgfSwKIAorICAgIHNldFBsYXlpbmc6IGZ1bmN0aW9uKGlzUGxheWluZykK KyAgICB7CisgICAgICAgIHRoaXMudXBkYXRlQ29udHJvbHMoKTsKKyAgICAgICAgQ29udHJvbGxl ci5wcm90b3R5cGUuc2V0UGxheWluZy5jYWxsKHRoaXMsIGlzUGxheWluZyk7CisgICAgfSwKKwog ICAgIGdldCBwYWdlU2NhbGVGYWN0b3IoKSB7CiAgICAgICAgIHJldHVybiB0aGlzLl9wYWdlU2Nh bGVGYWN0b3I7CiAgICAgfSwK