134820 2014-07-10 18:24:15 -0700 [iOS][WK2] It should be safe to call WKContentViewInteraction's cleanupInteraction multiple times 2014-07-10 19:29:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1021753 0 benjamin 2014-07-10 18:24:15 -0700 [iOS][WK2] It should be safe to call WKContentViewInteraction's cleanupInteraction multiple times 1021756 1 234735 benjamin 2014-07-10 18:45:07 -0700 Created attachment 234735 Patch 1021760 2 234735 kling 2014-07-10 19:09:10 -0700 Comment on attachment 234735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234735&action=review r=me > Source/WebKit2/ChangeLog:15 > + are completely symetrical. If cleanup is called twice, the second time would not enter the branch because Typo: symmetrical. 1021762 3 benjamin 2014-07-10 19:29:59 -0700 Committed r170988: <http://trac.webkit.org/changeset/170988> 234735 2014-07-10 18:45:07 -0700 2014-07-10 19:09:09 -0700 Patch bug-134820-20140710184439.patch text/plain 3129 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTAyODgyZjE3M2VlZTQ3 OTQ0Yzg0YWRiMzZkMzk4ZjUxODc4NzUxMS4uOWQ4MjM5N2U1MzQzM2I0YjI3ZGZlODY5NmJiOTBk ZmYxNzJhMmQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA3LTEwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g SXQgc2hvdWxkIGJlIHNhZmUgdG8gY2FsbCBXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ncyBjbGVh bnVwSW50ZXJhY3Rpb24gbXVsdGlwbGUgdGltZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDgyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElmIGEgdmlldyBpcyBkZXN0cm95ZWQganVzdCBhZnRlciBh IGNyYXNoLCAiY2xlYW51cEludGVyYWN0aW9uIiBpcyBjYWxsZWQgdHdpY2U6IG9uY2Ugb24gY3Jh c2gsCisgICAgICAgIG9uY2Ugb24gZGVhbGxvYy4KKworICAgICAgICBUaGUgY29kZSBoYW5kbGlu ZyBfaW50ZXJhY3Rpb25WaWV3c0NvbnRhaW5lclZpZXcgaXMgdXNpbmcgS1ZPIHRvIG1vbml0b3Ig dHJhbnNmb3JtIGNoYW5nZXMuIEl0IGlzIG5vdCBzYWZlCisgICAgICAgIHRvIHJlbW92ZSB0aGUg b2JzZXJ2ZXIgaWYgd2UgYXJlIG5vdCBhbHJlYWR5IG9ic2VydmluZyBvbiB0aGF0IHZpZXcuCisK KyAgICAgICAgVG8gc29sdmUgdGhlIHByb2JsZW0sIHRoaXMgcGF0Y2ggbWFrZXMgdGhlIGNsZWFu dXAgYWN0dWFsbHkgcmVtb3ZlIHRoZSB2aWV3IHNvIHRoYXQgc2V0dXAgYW5kIGNsZWFudXAKKyAg ICAgICAgYXJlIGNvbXBsZXRlbHkgc3ltZXRyaWNhbC4gSWYgY2xlYW51cCBpcyBjYWxsZWQgdHdp Y2UsIHRoZSBzZWNvbmQgdGltZSB3b3VsZCBub3QgZW50ZXIgdGhlIGJyYW5jaCBiZWNhdXNlCisg ICAgICAgIHRoZSB2aWV3IGlzIGFscmVhZHkgbmlsLgorCisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg c2V0dXBJbnRlcmFjdGlvbl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNsZWFudXBJbnRl cmFjdGlvbl0pOgorCiAyMDE0LTA3LTA5ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdW1dLMl0gRml4IHdpdGhpbkVwc2lsb24oKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQppbmRleCA4NGM0Y2QxZTYwMDhmZmQ5MjIwYzM3NDBjOTIwMzZiMjY3YTkyZWM1Li4x YWEyNGZkY2YzZmU5N2U1Zjk1YmMzNzBlNGVlNmM5MTQ0ZmY2OGZmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQpAQCAtMjIwLDggKzIyMCw5IEBAIHN0YXRpYyBVSVdlYlNlbGVjdGlvbk1vZGUgdG9VSVdlYlNl bGVjdGlvbk1vZGUoV0tTZWxlY3Rpb25HcmFudWxhcml0eSBncmFudWxhcml0CiAgICAgICAgIF9p bnRlcmFjdGlvblZpZXdzQ29udGFpbmVyVmlldyA9IGFkb3B0TlMoW1tVSVZpZXcgYWxsb2NdIGlu aXRdKTsKICAgICAgICAgW19pbnRlcmFjdGlvblZpZXdzQ29udGFpbmVyVmlldyBzZXRPcGFxdWU6 Tk9dOwogICAgICAgICBbX2ludGVyYWN0aW9uVmlld3NDb250YWluZXJWaWV3IGxheWVyXS5hbmNo b3JQb2ludCA9IENHUG9pbnRaZXJvOworICAgICAgICBbc2VsZi5zdXBlcnZpZXcgYWRkU3Vidmll dzpfaW50ZXJhY3Rpb25WaWV3c0NvbnRhaW5lclZpZXcuZ2V0KCldOwogICAgIH0KLSAgICBbX2lu dGVyYWN0aW9uVmlld3NDb250YWluZXJWaWV3IHNldEhpZGRlbjpOT107CisKICAgICBbc2VsZi5s YXllciBhZGRPYnNlcnZlcjpzZWxmIGZvcktleVBhdGg6QCJ0cmFuc2Zvcm0iIG9wdGlvbnM6TlNL ZXlWYWx1ZU9ic2VydmluZ09wdGlvbkluaXRpYWwgY29udGV4dDpuaWxdOwogCiAgICAgX3RvdWNo RXZlbnRHZXN0dXJlUmVjb2duaXplciA9IGFkb3B0TlMoW1tVSVdlYlRvdWNoRXZlbnRzR2VzdHVy ZVJlY29nbml6ZXIgYWxsb2NdIGluaXRXaXRoVGFyZ2V0OnNlbGYgYWN0aW9uOkBzZWxlY3Rvcihf d2ViVG91Y2hFdmVudHNSZWNvZ25pemVkOikgdG91Y2hEZWxlZ2F0ZTpzZWxmXSk7CkBAIC0yNzYs OCArMjc3LDEzIEBAIHN0YXRpYyBVSVdlYlNlbGVjdGlvbk1vZGUgdG9VSVdlYlNlbGVjdGlvbk1v ZGUoV0tTZWxlY3Rpb25HcmFudWxhcml0eSBncmFudWxhcml0CiAgICAgW19mb3JtSW5wdXRTZXNz aW9uIGludmFsaWRhdGVdOwogICAgIF9mb3JtSW5wdXRTZXNzaW9uID0gbmlsOwogICAgIFtfaGln aGxpZ2h0VmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKLSAgICBbc2VsZi5sYXllciByZW1vdmVP YnNlcnZlcjpzZWxmIGZvcktleVBhdGg6QCJ0cmFuc2Zvcm0iXTsKLSAgICBbX2ludGVyYWN0aW9u Vmlld3NDb250YWluZXJWaWV3IHNldEhpZGRlbjpZRVNdOworCisgICAgaWYgKF9pbnRlcmFjdGlv blZpZXdzQ29udGFpbmVyVmlldykgeworICAgICAgICBbc2VsZi5sYXllciByZW1vdmVPYnNlcnZl cjpzZWxmIGZvcktleVBhdGg6QCJ0cmFuc2Zvcm0iXTsKKyAgICAgICAgW19pbnRlcmFjdGlvblZp ZXdzQ29udGFpbmVyVmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKKyAgICAgICAgX2ludGVyYWN0 aW9uVmlld3NDb250YWluZXJWaWV3ID0gbmlsOworICAgIH0KKwogICAgIFtfdG91Y2hFdmVudEdl c3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRlOm5pbF07CiAgICAgW3NlbGYgcmVtb3ZlR2VzdHVy ZVJlY29nbml6ZXI6X3RvdWNoRXZlbnRHZXN0dXJlUmVjb2duaXplci5nZXQoKV07CiAK