134813 2014-07-10 15:03:42 -0700 [Mac] NSWindow warning: adding an unknown subview opening detached Inspector 2014-07-10 16:21:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue joepeck timothy oldest_to_newest 1021709 0 joepeck 2014-07-10 15:03:42 -0700 Warning messages in syslog about dock buttons. We should avoid the warning messages. We would like to move to new API to do this though. 1021710 1 joepeck 2014-07-10 15:03:57 -0700 <rdar://problem/17081606> 1021711 2 234725 joepeck 2014-07-10 15:05:41 -0700 Created attachment 234725 [PATCH] Proposed Fix 1021729 3 234725 commit-queue 2014-07-10 16:21:15 -0700 Comment on attachment 234725 [PATCH] Proposed Fix Clearing flags on attachment: 234725 Committed r170980: <http://trac.webkit.org/changeset/170980> 1021730 4 commit-queue 2014-07-10 16:21:17 -0700 All reviewed patches have been landed. Closing bug. 234725 2014-07-10 15:05:41 -0700 2014-07-10 16:21:14 -0700 [PATCH] Proposed Fix known-subview.patch text/plain 4021 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBkZTk2NjYxLi5kMGQ4OGZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTQtMDctMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBbTWFjXSBOU1dpbmRvdyB3YXJuaW5nOiBhZGRpbmcgYW4gdW5r bm93biBzdWJ2aWV3IG9wZW5pbmcgZGV0YWNoZWQgSW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ4MTMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkluc3Bl Y3RvckNsaWVudC5tbToKKyAgICAgICAgKC1bV2ViSW5zcGVjdG9yV2luZG93Q29udHJvbGxlciB3 aW5kb3ddKToKKyAgICAgICAgVXNlIGEgc2VsZWN0b3IgdGhhdCB3aWxsIGF2b2lkIHRoZSB3YXJu aW5nIG1lc3NhZ2UuCisKIDIwMTQtMDctMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTY3NzcwKTogQ2Fubm90IGxvZ2luIGluIEV2ZXJu b3RlIFNhZmFyaSBleHRlbnNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNv cmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNv cmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQppbmRleCAxMjQ4OTA0Li4yZWE0YWUwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JD bGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVj dG9yQ2xpZW50Lm1tCkBAIC02Miw2ICs2MiwxMCBAQCBzdGF0aWMgY29uc3QgQ0dGbG9hdCBkb2Nr QnV0dG9uTWFyZ2luID0gMzsKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKK0BpbnRlcmZh Y2UgTlNWaWV3IChBcHBLaXREZXRhaWxzKQorLSAodm9pZClfYWRkS25vd25TdWJ2aWV3OihOU1Zp ZXcgKilzdWJ2aWV3OworQGVuZAorCiBAaW50ZXJmYWNlIE5TV2luZG93IChBcHBLaXREZXRhaWxz KQogLSAoTlNDdXJzb3IgKilfY3Vyc29yRm9yUmVzaXplRGlyZWN0aW9uOihOU0ludGVnZXIpZGly ZWN0aW9uOwogLSAoTlNSZWN0KV9jdXN0b21UaXRsZUZyYW1lOwpAQCAtNTE3LDcgKzUyMSwxMCBA QCB2b2lkIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50OjphcHBlbmQoY29uc3QgU3RyaW5nJiBz dWdnZXN0ZWRVUkwsIGNvbnN0IFN0cmluZwogICAgIC8vIFNldCB0aGUgYXV0b3Jlc2l6aW5nIG1h c2sgdG8ga2VlcCB0aGUgZG9jayBidXR0b24gcGlubmVkIHRvIHRoZSB0b3AgcmlnaHQgY29ybmVy LgogICAgIF9kb2NrQnV0dG9uLmdldCgpLmF1dG9yZXNpemluZ01hc2sgPSBOU1ZpZXdNaW5YTWFy Z2luIHwgTlNWaWV3TWluWU1hcmdpbjsKIAotICAgIFtmcmFtZVZpZXcgYWRkU3VidmlldzpfZG9j a0J1dHRvbi5nZXQoKV07CisgICAgaWYgKFtmcmFtZVZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBz ZWxlY3RvcihfYWRkS25vd25TdWJ2aWV3OildKQorICAgICAgICBbZnJhbWVWaWV3IF9hZGRLbm93 blN1YnZpZXc6X2RvY2tCdXR0b24uZ2V0KCldOworICAgIGVsc2UKKyAgICAgICAgW2ZyYW1lVmll dyBhZGRTdWJ2aWV3Ol9kb2NrQnV0dG9uLmdldCgpXTsKIAogICAgIC8vIEhpZGUgdGhlIGRvY2sg YnV0dG9uIGlmIHdlIGNhbid0IGF0dGFjaC4KICAgICBfZG9ja0J1dHRvbi5nZXQoKS5oaWRkZW4g PSAhX2Zyb250ZW5kQ2xpZW50LT5jYW5BdHRhY2hXaW5kb3coKSB8fCBfaW5zcGVjdG9yQ2xpZW50 LT5pbnNwZWN0b3JBdHRhY2hEaXNhYmxlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDkwOTIzNGQuLmYzY2Ji NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wNy0xMCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIE5TV2luZG93IHdhcm5p bmc6IGFkZGluZyBhbiB1bmtub3duIHN1YnZpZXcgb3BlbmluZyBkZXRhY2hlZCBJbnNwZWN0b3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDgxMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5z cGVjdG9yUHJveHk6OmNyZWF0ZUluc3BlY3RvcldpbmRvdyk6CisgICAgICAgIFVzZSBhIHNlbGVj dG9yIHRoYXQgd2lsbCBhdm9pZCB0aGUgd2FybmluZyBtZXNzYWdlLgorCiAyMDE0LTA3LTEwICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3JlIFZp ZXdTbmFwc2hvdHMgZGlyZWN0bHkgb24gdGhlIFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1t CmluZGV4IGEyZTMwYzguLjY3NTkwNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtMTU0LDYgKzE1NCwxMCBAQCBz dGF0aWMgY29uc3QgTlNVSW50ZWdlciB3aW5kb3dTdHlsZU1hc2sgPSBOU1RpdGxlZFdpbmRvd01h c2sgfCBOU0Nsb3NhYmxlV2luZG93TQogCiBAZW5kCiAKK0BpbnRlcmZhY2UgTlNWaWV3IChBcHBL aXREZXRhaWxzKQorLSAodm9pZClfYWRkS25vd25TdWJ2aWV3OihOU1ZpZXcgKilzdWJ2aWV3Owor QGVuZAorCiBAaW50ZXJmYWNlIE5TV2luZG93IChBcHBLaXREZXRhaWxzKQogLSAoTlNDdXJzb3Ig KilfY3Vyc29yRm9yUmVzaXplRGlyZWN0aW9uOihOU0ludGVnZXIpZGlyZWN0aW9uOwogLSAoTlNS ZWN0KV9jdXN0b21UaXRsZUZyYW1lOwpAQCAtMzM3LDggKzM0MSwxMyBAQCB2b2lkIFdlYkluc3Bl Y3RvclByb3h5OjpjcmVhdGVJbnNwZWN0b3JXaW5kb3coKQogICAgIGRvY2tCdXR0b25PcmlnaW4u eCAtPSBkb2NrQnV0dG9uU2l6ZS53aWR0aCArIGRvY2tCdXR0b25TcGFjaW5nOwogICAgIG1fZG9j a0JvdHRvbUJ1dHRvbi5nZXQoKS5mcmFtZU9yaWdpbiA9IGRvY2tCdXR0b25PcmlnaW47CiAKLSAg ICBbZnJhbWVWaWV3IGFkZFN1YnZpZXc6bV9kb2NrQm90dG9tQnV0dG9uLmdldCgpXTsKLSAgICBb ZnJhbWVWaWV3IGFkZFN1YnZpZXc6bV9kb2NrUmlnaHRCdXR0b24uZ2V0KCldOworICAgIGlmIChb ZnJhbWVWaWV3IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX2FkZEtub3duU3Vidmlldzop XSkgeworICAgICAgICBbZnJhbWVWaWV3IF9hZGRLbm93blN1YnZpZXc6bV9kb2NrQm90dG9tQnV0 dG9uLmdldCgpXTsKKyAgICAgICAgW2ZyYW1lVmlldyBfYWRkS25vd25TdWJ2aWV3Om1fZG9ja1Jp Z2h0QnV0dG9uLmdldCgpXTsKKyAgICB9IGVsc2UgeworICAgICAgICBbZnJhbWVWaWV3IGFkZFN1 YnZpZXc6bV9kb2NrQm90dG9tQnV0dG9uLmdldCgpXTsKKyAgICAgICAgW2ZyYW1lVmlldyBhZGRT dWJ2aWV3Om1fZG9ja1JpZ2h0QnV0dG9uLmdldCgpXTsKKyAgICB9CiAKICAgICAvLyBIaWRlIHRo ZSBkb2NrIGJ1dHRvbnMgaWYgd2UgY2FuJ3QgYXR0YWNoLgogICAgIG1fZG9ja0JvdHRvbUJ1dHRv bi5nZXQoKS5oaWRkZW4gPSAhY2FuQXR0YWNoKCk7Cg==