134801 2014-07-10 09:02:08 -0700 [GTK] Enable VIDEO_TRACK by default 2014-07-11 05:13:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bunhere calvaris commit-queue gustavo gyuyoung.kim pnormand rakuco sergio oldest_to_newest 1021621 0 cgarcia 2014-07-10 09:02:08 -0700 I'm getting several build failures with this combination that is the default one in GTK+ production builds 1021645 1 calvaris 2014-07-10 10:05:58 -0700 This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK. 1021649 2 cgarcia 2014-07-10 10:16:55 -0700 (In reply to comment #1) > This can't happen anymore. New JS controls need VIDEO_TRACK. So either we resurrect them or require VIDEO_TRACK. We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled. 1021674 3 calvaris 2014-07-10 12:04:03 -0700 (In reply to comment #2) > We can't build with VIDEO_TRACK disabled anymore, we should just remove the option and enabled it unconditionally when video is enabled. Agree. 1021800 4 calvaris 2014-07-11 02:04:33 -0700 Btw, we could remove MediaControlsGtk.h from the repo, which I forgot at bug 131300. 1021819 5 234757 cgarcia 2014-07-11 04:18:09 -0700 Created attachment 234757 Patch 1021823 6 cgarcia 2014-07-11 05:13:13 -0700 Committed r170997: <http://trac.webkit.org/changeset/170997> 234757 2014-07-11 04:18:09 -0700 2014-07-11 04:36:03 -0700 Patch wk-video-track.diff text/plain 1175 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4YzcxODdkLi4wZWY1ZTcw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTQtMDctMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEVuYWJsZSBWSURFT19UUkFDSyBieSBkZWZhdWx0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ4MDEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlOgorCiAyMDE0LTA3LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtDTWFrZV0gQWRkIGEgJ2Rpc3RjaGVjaycg dGFyZ2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGVhOWEyYmEuLjJmN2ZhMmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlCkBAIC0xMzEsNyArMTMxLDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9VU0VSU0VMRUNUX0FMTCBPTikKIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9WSUJSQVRJT04gT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX1ZJREVPIE9OKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX1ZJREVPX1RSQUNLIE9GRikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9WSURFT19UUkFDSyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBIE9OKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9BVURJTyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfVElNSU5HIE9OKQo=