134792 2014-07-09 19:08:43 -0700 Assertions or crashes under _takeViewSnapshot when restoring windows 2014-07-10 08:40:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca jer.noble simon.fraser oldest_to_newest 1021527 0 thorton 2014-07-09 19:08:43 -0700 We shouldn't try to take a snapshot of a non-visible window! Also, we shouldn't crash if you try to make an IOSurface from a null CGImageRef. 1021529 1 234681 thorton 2014-07-09 19:10:59 -0700 Created attachment 234681 patch 1021620 2 thorton 2014-07-10 08:40:24 -0700 http://trac.webkit.org/changeset/170963 234681 2014-07-09 19:10:59 -0700 2014-07-09 19:16:19 -0700 patch ws.diff text/plain 2550 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZTczY2E5Li40NWQ1ZTc1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA3LTA5ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KKworICAgICAgICBBc3NlcnRpb25zIG9yIGNyYXNoZXMgdW5kZXIgX3Rha2VWaWV3U25hcHNo b3Qgd2hlbiByZXN0b3Jpbmcgd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW06 CisgICAgICAgIChJT1N1cmZhY2U6OmNyZWF0ZUZyb21JbWFnZSk6CisKIDIwMTQtMDctMDkgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBJbmRp cmVjdENvbXBvc2l0aW5nUmVhc29uIGFuIGVudW0gY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQppbmRleCBiNzJmM2JkLi40 ZDg1YTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29j b2EvSU9TdXJmYWNlLm1tCkBAIC03Miw2ICs3Miw5IEBAIFBhc3NSZWZQdHI8SU9TdXJmYWNlPiBJ T1N1cmZhY2U6OmNyZWF0ZUZyb21TdXJmYWNlKElPU3VyZmFjZVJlZiBzdXJmYWNlLCBDb2xvclNw CiAKIFBhc3NSZWZQdHI8SU9TdXJmYWNlPiBJT1N1cmZhY2U6OmNyZWF0ZUZyb21JbWFnZShDR0lt YWdlUmVmIGltYWdlKQogeworICAgIGlmICghaW1hZ2UpCisgICAgICAgIHJldHVybiBudWxscHRy OworCiAgICAgc2l6ZV90IHdpZHRoID0gQ0dJbWFnZUdldFdpZHRoKGltYWdlKTsKICAgICBzaXpl X3QgaGVpZ2h0ID0gQ0dJbWFnZUdldEhlaWdodChpbWFnZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwZmQ0 ZTUwLi40MWE1Yzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDctMDkgIFRp bW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEFzc2Vy dGlvbnMgb3IgY3Jhc2hlcyB1bmRlciBfdGFrZVZpZXdTbmFwc2hvdCB3aGVuIHJlc3RvcmluZyB3 aW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzQ3OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF90YWtlVmll d1NuYXBzaG90XSk6CisgICAgICAgIFRha2luZyBhIHdpbmRvdy1zZXJ2ZXIgc25hcHNob3Qgb2Yg YSBub24tdmlzaWJsZSB3aW5kb3cgdGVuZHMgdG8gbm90IHN1Y2NlZWQuCisKIDIwMTQtMDctMDkg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTYWZhcmkg c2hvd2luZyBibGFuayBwYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tW aWV3Lm1tCmluZGV4IGU1NzhhMDcuLjU5MzQ2OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0KQEAgLTMxMDgsNyArMzEwOCw3IEBAIHN0YXRpYyB2b2lkKiBr ZXlWYWx1ZU9ic2VydmluZ0NvbnRleHQgPSAma2V5VmFsdWVPYnNlcnZpbmdDb250ZXh0OwogICAg IFZpZXdTbmFwc2hvdCBzbmFwc2hvdDsKIAogICAgIENHU1dpbmRvd0lEIHdpbmRvd0lEID0gKENH U1dpbmRvd0lEKVt3aW5kb3cgd2luZG93TnVtYmVyXTsKLSAgICBpZiAoIXdpbmRvd0lEKQorICAg IGlmICghd2luZG93SUQgfHwgIXdpbmRvdy52aXNpYmxlKQogICAgICAgICByZXR1cm4gc25hcHNo b3Q7CiAKICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gd2luZG93U25hcHNob3RJbWFnZSA9IGFk b3B0Q0YoQ0dXaW5kb3dMaXN0Q3JlYXRlSW1hZ2UoQ0dSZWN0TnVsbCwga0NHV2luZG93TGlzdE9w dGlvbkluY2x1ZGluZ1dpbmRvdywgd2luZG93SUQsIGtDR1dpbmRvd0ltYWdlQm91bmRzSWdub3Jl RnJhbWluZyB8IGtDR1dpbmRvd0ltYWdlU2hvdWxkQmVPcGFxdWUpKTsK