134788 2014-07-09 17:41:58 -0700 [iOS] Some QuickLook documents are not displayed as previews 2014-07-10 17:03:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes ddkilzer psolanki thorton oldest_to_newest 1021504 0 aestes 2014-07-09 17:41:58 -0700 [iOS] Some QuickLook documents are not displayed as previews 1021508 1 aestes 2014-07-09 17:53:48 -0700 <rdar://problem/17278194> 1021509 2 234677 aestes 2014-07-09 17:55:18 -0700 Created attachment 234677 Patch 1021575 3 234677 psolanki 2014-07-09 23:21:38 -0700 Comment on attachment 234677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234677&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=134788 Mention the radar number here as well. > Source/WebCore/ChangeLog:9 > + NSURLRequest have no way to set this bit properly) and should probably be removed. Instead of using That would be great! Do you think we can update all uses of isMainResourceRequest() with your check below? It would be good to get rid of this iOS specific code. 1021596 4 234677 ddkilzer 2014-07-10 04:24:56 -0700 Comment on attachment 234677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234677&action=review >> Source/WebCore/ChangeLog:9 >> + NSURLRequest have no way to set this bit properly) and should probably be removed. Instead of using > > That would be great! Do you think we can update all uses of isMainResourceRequest() with your check below? It would be good to get rid of this iOS specific code. I think this logic should be wrapped in a well-named (inline) method since it's not immediately obvious from reading the code that you're checking for the main resource being loaded. 1021618 5 aestes 2014-07-10 08:36:00 -0700 (In reply to comment #3) > (From update of attachment 234677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234677&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=134788 > > Mention the radar number here as well. > > > Source/WebCore/ChangeLog:9 > > + NSURLRequest have no way to set this bit properly) and should probably be removed. Instead of using > > That would be great! Do you think we can update all uses of isMainResourceRequest() with your check below? It would be good to get rid of this iOS specific code. I considered doing this, but couldn't find an easy way to do so. The other uses of isMainResourceRequest() have access to a ResourceHandle instead of a ResourceLoader, and there's no easy way to get a ResourceLoader from a ResourceHandle (you can only get a ResourceHandleClient*, which isn't necessarily a ResourceLoader). For now, what do you think about me renaming isMainResourceRequest() to deprecatedIsMainResourceRequest() and adding a comment stating why it can't be used reliably with the Network Process? 1021619 6 aestes 2014-07-10 08:38:22 -0700 (In reply to comment #4) > (From update of attachment 234677 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234677&action=review > > >> Source/WebCore/ChangeLog:9 > >> + NSURLRequest have no way to set this bit properly) and should probably be removed. Instead of using > > > > That would be great! Do you think we can update all uses of isMainResourceRequest() with your check below? It would be good to get rid of this iOS specific code. > > I think this logic should be wrapped in a well-named (inline) method since it's not immediately obvious from reading the code that you're checking for the main resource being loaded. Will do! 1021741 7 aestes 2014-07-10 17:03:19 -0700 Committed r170984: <http://trac.webkit.org/changeset/170984> 234677 2014-07-09 17:55:18 -0700 2014-07-10 04:24:56 -0700 Patch bug-134788-20140709175500.patch text/plain 2407 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwOTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjkxOTAyY2I4ZDQwMmNk ZWJhNDhiODJmNTE0ZmVjNDk1ZDJmOTNlYi4uNWQ3YTI5YzMwNWRjZWQ2NzI0OTVmMzQzMTkwZjhl NWU4MGUxZDk4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA3LTA5ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBTb21lIFF1aWNrTG9v ayBkb2N1bWVudHMgYXJlIG5vdCBkaXNwbGF5ZWQgYXMgcHJldmlld3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDc4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgUmVzb3VyY2VSZXF1ZXN0 Ojppc01haW5SZXNvdXJjZVJlcXVlc3QoKSBpcyBub3QgcmVsaWFibGUgKGUuZy4gUmVzb3VyY2VS ZXF1ZXN0cyByZWNvbnN0aXR1dGVkIGZyb20gYW4KKyAgICAgICAgTlNVUkxSZXF1ZXN0IGhhdmUg bm8gd2F5IHRvIHNldCB0aGlzIGJpdCBwcm9wZXJseSkgYW5kIHNob3VsZCBwcm9iYWJseSBiZSBy ZW1vdmVkLiBJbnN0ZWFkIG9mIHVzaW5nCisgICAgICAgIGlzTWFpblJlc291cmNlUmVxdWVzdCgp IHRvIGNoZWNrIGlmIGEgUXVpY2tMb29rSGFuZGxlIHNob3VsZCBiZSBjcmVhdGVkIHdoZW4gdGhl IE5ldHdvcmsgUHJvY2VzcyBpcyBpbiB1c2UsCisgICAgICAgIGp1c3QgY2hlY2sgaWYgdGhlIGN1 cnJlbnQgUmVzb3VyY2VMb2FkZXIgaXMgdGhlIHNhbWUgYXMgdGhlIERvY3VtZW50TG9hZGVyJ3Mg UmVzb3VyY2VMb2FkZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBRdWlja0xvb2sgaXMgbm90 IHRlc3RhYmxlIGZyb20gV2ViS2l0LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9pb3Mv UXVpY2tMb29rLm1tOgorICAgICAgICAoV2ViQ29yZTo6UXVpY2tMb29rSGFuZGxlOjpjcmVhdGUp OgorCiAyMDE0LTA3LTA5ICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29t PgogICAgICAgICBDU1MgY2FudmFzIGNvbG9yIHBhcnNpbmcgYWNjZXB0cyBpbnZhbGlkIGNvbG9y IGlkZW50aWZpZXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQ2NjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv aW9zL1F1aWNrTG9vay5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1 aWNrTG9vay5tbQppbmRleCA5NmM4NzE1YzgzNjdhOGE5ODQ4MDQ1YjMwNGM0YjI0MTI0YmI3Mjk5 Li4xN2MzZGVjMGIzZDVmNDEwMWI5NGVlNmMzMGZmMDUyOWJiODlmZjE0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2subW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tCkBAIC0yOCw2ICsy OCw3IEBACiAKICNpZiBVU0UoUVVJQ0tfTE9PSykKIAorI2ltcG9ydCAiRG9jdW1lbnRMb2FkZXIu aCIKICNpbXBvcnQgIkZpbGVTeXN0ZW1JT1MuaCIKICNpbXBvcnQgIkxvZ2dpbmcuaCIKICNpbXBv cnQgIlJlc291cmNlRXJyb3IuaCIKQEAgLTQ1NCw3ICs0NTUsNyBAQCBDRlVSTFJlc3BvbnNlUmVm IFF1aWNrTG9va0hhbmRsZTo6Y2ZSZXNwb25zZSgpCiBzdGQ6OnVuaXF1ZV9wdHI8UXVpY2tMb29r SGFuZGxlPiBRdWlja0xvb2tIYW5kbGU6OmNyZWF0ZShSZXNvdXJjZUxvYWRlciogbG9hZGVyLCBO U1VSTFJlc3BvbnNlICpyZXNwb25zZSkKIHsKICAgICBBU1NFUlRfQVJHKGxvYWRlciwgbG9hZGVy KTsKLSAgICBpZiAoIWxvYWRlci0+cmVxdWVzdCgpLmlzTWFpblJlc291cmNlUmVxdWVzdCgpIHx8 ICFbV2ViQ29yZTo6UUxQcmV2aWV3R2V0U3VwcG9ydGVkTUlNRVR5cGVzU2V0KCkgY29udGFpbnNP YmplY3Q6W3Jlc3BvbnNlIE1JTUVUeXBlXV0pCisgICAgaWYgKGxvYWRlci0+ZG9jdW1lbnRMb2Fk ZXIoKS0+bWFpblJlc291cmNlTG9hZGVyKCkgIT0gbG9hZGVyIHx8ICFbV2ViQ29yZTo6UUxQcmV2 aWV3R2V0U3VwcG9ydGVkTUlNRVR5cGVzU2V0KCkgY29udGFpbnNPYmplY3Q6W3Jlc3BvbnNlIE1J TUVUeXBlXV0pCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgUmV0YWluUHRyPFdlYlJl c291cmNlTG9hZGVyUXVpY2tMb29rRGVsZWdhdGU+IGRlbGVnYXRlID0gYWRvcHROUyhbW1dlYlJl c291cmNlTG9hZGVyUXVpY2tMb29rRGVsZWdhdGUgYWxsb2NdIGluaXRXaXRoUmVzb3VyY2VMb2Fk ZXI6bG9hZGVyXSk7Cg==