134779 2014-07-09 14:47:02 -0700 Support transparent WKWebViews 2014-07-10 20:13:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin oldest_to_newest 1021450 0 andersca 2014-07-09 14:47:02 -0700 Support transparent WKWebViews 1021452 1 234659 andersca 2014-07-09 14:50:13 -0700 Created attachment 234659 Patch 1021458 2 234659 thorton 2014-07-09 15:00:57 -0700 Comment on attachment 234659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234659&action=review > Source/WebCore/ChangeLog:9 > + Schedule rebuilding the compositing layers if a FrameView's transparency changes. this definitely needs a "why" (though I vaguely remember from you showing me) > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1173 > + BOOL oldOpaque = self.opaque; s/old/was/g? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1176 > + [super setOpaque:opaque]; > + [_contentView setOpaque:opaque]; why are these before the early return? 1021460 3 andersca 2014-07-09 15:06:49 -0700 Committed r170935: <http://trac.webkit.org/changeset/170935> 1021772 4 benjamin 2014-07-10 19:58:35 -0700 The background color is quite broken on load in Safari. This looks related. 1021775 5 234659 benjamin 2014-07-10 20:13:14 -0700 Comment on attachment 234659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234659&action=review I think we should revert, we should not create our own behaviors different from regular UIScrollView. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:665 > + if (!webView.opaque) > + return WebCore::Color::transparent; What? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:672 > - color = _page->pageExtendedBackgroundColor(); > + color = webView->_page->pageExtendedBackgroundColor(); This is an invalid color until the first layer tree update! > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1171 > +- (void)setOpaque:(BOOL)opaque Opaque is a rendering hint, it does not work like that. 234659 2014-07-09 14:50:13 -0700 2014-07-10 20:13:14 -0700 Patch bug-134779-20140709144955.patch text/plain 6340 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNmMTJlNDMzMjY1YTM5 MWUzZDBjM2FiZWIxMDBjZWQ5MjExOTAzNy4uZDQ5YTQ5MzEzYzE0NDc1MjBjNDYwOTExMTJlZjAx MzZkNDVlMDMxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCB0cmFu c3BhcmVudCBXS1dlYlZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzQ3NzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MzUxMDU4PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjaGVkdWxlIHJl YnVpbGRpbmcgdGhlIGNvbXBvc2l0aW5nIGxheWVycyBpZiBhIEZyYW1lVmlldydzIHRyYW5zcGFy ZW5jeSBjaGFuZ2VzLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVWaWV3OjpzZXRUcmFuc3BhcmVudCk6CisKIDIwMTQtMDctMDkgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gUmVtb3ZlIHVz ZSBvZiAnZ3JlcCcgaW4gYnVpbGQgc3RlcHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxNjBmMmJhNzg2ZDFjYTY1 NzcxYTdkMjRlYmU1NjgxZjYwMWY4ZTQwLi5jNDA5MDFhODUxMzAyZjc1MzI0ZjQzN2FmNTc4YTVi NzdjYzU4MGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzMgQEAKIDIwMTQtMDctMDkgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBTdXBwb3J0IHRyYW5z cGFyZW50IFdLV2ViVmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNDc3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTczNTEwNTg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGluaXRXaXRoRnJh bWU6Y29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgQ2FsbCBfdXBkYXRlU2Nyb2xsVmlld0JhY2tn cm91bmQgaW5zdGVhZCBvZiBzZXR0aW5nIHRoZSBiYWNrZ3JvdW5kIGNvbG9yLgorCisgICAgICAg IChjb250ZW50Wm9vbVNjYWxlKToKKyAgICAgICAgVXNlIGRvdCBub3RhdGlvbi4KKworICAgICAg ICAoc2Nyb2xsVmlld0JhY2tncm91bmRDb2xvcik6CisgICAgICAgIEhlbHBlciBmdW5jdGlvbiB0 aGF0IHJldHVybnMgdGhlIHNjcm9sbCB2aWV3IGJhY2tncm91bmQgY29sb3IuIAorICAgICAgICBJ ZiB0aGUgd2ViIHZpZXcgaXNuJ3Qgb3BhcXVlLCB3ZSB3YW50IHRoZSBzY3JvbGwgdmlldyB0byBi ZSB0cmFuc3BhcmVudC4KKworICAgICAgICAoLVtXS1dlYlZpZXcgX3VwZGF0ZVNjcm9sbFZpZXdC YWNrZ3JvdW5kXSk6CisgICAgICAgIENhbGwgc2Nyb2xsVmlld0JhY2tncm91bmRDb2xvci4KKwor ICAgICAgICAoLVtXS1dlYlZpZXcgc2V0T3BhcXVlOl0pOgorICAgICAgICBDYWxsIFdlYlBhZ2VQ cm94eTo6c2V0RHJhd3NCYWNrZ3JvdW5kIGFuZCB1cGRhdGUgdGhlIHNjcm9sbCB2aWV3IGJhY2tn cm91bmQuCisKKyAgICAgICAgKC1bV0tXZWJWaWV3IHNldEJhY2tncm91bmRDb2xvcjpdKToKKyAg ICAgICAgQ2FsbCBzZXRCYWNrZ3JvdW5kQ29sb3Igb24gdGhlIGNvbnRlbnQgdmlldy4KKworMjAx NC0wNy0wOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAg IFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjplbnN1cmVCYWNraW5nU3RvcmUgc2hvdWxkIGVuc3Vy ZSB0aGF0IHRoZSBlbnRpcmUgYmFja2luZyBzdG9yZSBnZXRzIHJlZHJhd24KICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDc3MgogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKaW5kZXggYjM5YWY0MTExZmZjMmQzOTdmMzY5ZDQxOTllZTUzOGJhNTAx NWE1OC4uMDY4NDUxOTVhMWI2NWMzNTBmNzcxOTdlZThiZjI5ZDQzYWJmMWVmYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMjUyMyw3ICsyNTIzLDE4IEBAIGJvb2wgRnJhbWVWaWV3 Ojppc1RyYW5zcGFyZW50KCkgY29uc3QKIAogdm9pZCBGcmFtZVZpZXc6OnNldFRyYW5zcGFyZW50 KGJvb2wgaXNUcmFuc3BhcmVudCkKIHsKKyAgICBpZiAobV9pc1RyYW5zcGFyZW50ID09IGlzVHJh bnNwYXJlbnQpCisgICAgICAgIHJldHVybjsKKwogICAgIG1faXNUcmFuc3BhcmVudCA9IGlzVHJh bnNwYXJlbnQ7CisKKyAgICBSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gdGhpcy0+cmVuZGVyVmll dygpOworICAgIGlmICghcmVuZGVyVmlldykKKyAgICAgICAgcmV0dXJuOworCisgICAgUmVuZGVy TGF5ZXJDb21wb3NpdG9yJiBjb21wb3NpdG9yID0gcmVuZGVyVmlldy0+Y29tcG9zaXRvcigpOwor ICAgIGNvbXBvc2l0b3Iuc2V0Q29tcG9zaXRpbmdMYXllcnNOZWVkUmVidWlsZCgpOworICAgIGNv bXBvc2l0b3Iuc2NoZWR1bGVDb21wb3NpdGluZ0xheWVyVXBkYXRlKCk7CiB9CiAKIGJvb2wgRnJh bWVWaWV3OjpoYXNPcGFxdWVCYWNrZ3JvdW5kKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggYjE1Zjg1OGI5YzNiM2Y4NGFj Y2ZhZDE5MWQ5YWEzNTQ1MjFhY2E5Ni4uODAyMWY3OWQ1Yjk3NzkwNzNmMzY4MzJlODU2NWU5YTJj NDI5MmUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KQEAgLTI3Nyw3ICsyNzcsNiBAQCBzdGF0aWMgaW50MzJfdCBkZXZpY2VPcmllbnRh dGlvbigpCiAgICAgW19zY3JvbGxWaWV3IHNldEJvdW5jZXNab29tOllFU107CiAKICAgICBbc2Vs ZiBhZGRTdWJ2aWV3Ol9zY3JvbGxWaWV3LmdldCgpXTsKLSAgICBbX3Njcm9sbFZpZXcgc2V0QmFj a2dyb3VuZENvbG9yOltVSUNvbG9yIHdoaXRlQ29sb3JdXTsKIAogICAgIF9jb250ZW50VmlldyA9 IGFkb3B0TlMoW1tXS0NvbnRlbnRWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOmJvdW5kcyBjb250 ZXh0OmNvbnRleHQgY29uZmlndXJhdGlvbjpXVEY6Om1vdmUod2ViUGFnZUNvbmZpZ3VyYXRpb24p IHdlYlZpZXc6c2VsZl0pOwogCkBAIC0yODgsNiArMjg3LDggQEAgc3RhdGljIGludDMyX3QgZGV2 aWNlT3JpZW50YXRpb24oKQogICAgIFtfY29udGVudFZpZXcgbGF5ZXJdLmFuY2hvclBvaW50ID0g Q0dQb2ludFplcm87CiAgICAgW19jb250ZW50VmlldyBzZXRGcmFtZTpib3VuZHNdOwogICAgIFtf c2Nyb2xsVmlldyBhZGRTdWJ2aWV3Ol9jb250ZW50Vmlldy5nZXQoKV07CisgICAgW3NlbGYgX3Vw ZGF0ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kXTsKKwogICAgIF92aWV3cG9ydE1ldGFUYWdXaWR0aCA9 IC0xOwogCiAgICAgW3NlbGYgX2ZyYW1lT3JCb3VuZHNDaGFuZ2VkXTsKQEAgLTY1MSwyOSArNjUy LDQwIEBAIHN0YXRpYyBDR1NpemUgcm91bmRTY3JvbGxWaWV3Q29udGVudFNpemUoY29uc3QgV2Vi S2l0OjpXZWJQYWdlUHJveHkmIHBhZ2UsIENHU2l6CiAgICAgfQogfQogCi1zdGF0aWMgQ0dGbG9h dCBjb250ZW50Wm9vbVNjYWxlKFdLV2ViVmlldyogd2ViVmlldykKK3N0YXRpYyBDR0Zsb2F0IGNv bnRlbnRab29tU2NhbGUoV0tXZWJWaWV3ICp3ZWJWaWV3KQogewotICAgIENHRmxvYXQgc2NhbGUg PSBbW3dlYlZpZXcuX2N1cnJlbnRDb250ZW50VmlldyBsYXllcl0gYWZmaW5lVHJhbnNmb3JtXS5h OworICAgIENHRmxvYXQgc2NhbGUgPSB3ZWJWaWV3Ll9jdXJyZW50Q29udGVudFZpZXcubGF5ZXIu YWZmaW5lVHJhbnNmb3JtLmE7CiAgICAgQVNTRVJUKHNjYWxlID09IFt3ZWJWaWV3LT5fc2Nyb2xs VmlldyB6b29tU2NhbGVdKTsKICAgICByZXR1cm4gc2NhbGU7CiB9CiAKLS0gKHZvaWQpX3VwZGF0 ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kCitzdGF0aWMgV2ViQ29yZTo6Q29sb3Igc2Nyb2xsVmlld0Jh Y2tncm91bmRDb2xvcihXS1dlYlZpZXcgKndlYlZpZXcpCiB7CisgICAgaWYgKCF3ZWJWaWV3Lm9w YXF1ZSkKKyAgICAgICAgcmV0dXJuIFdlYkNvcmU6OkNvbG9yOjp0cmFuc3BhcmVudDsKKwogICAg IFdlYkNvcmU6OkNvbG9yIGNvbG9yOwotICAgIGlmIChfY3VzdG9tQ29udGVudFZpZXcpCi0gICAg ICAgIGNvbG9yID0gW19jdXN0b21Db250ZW50VmlldyBiYWNrZ3JvdW5kQ29sb3JdLkNHQ29sb3I7 CisKKyAgICBpZiAod2ViVmlldy0+X2N1c3RvbUNvbnRlbnRWaWV3KQorICAgICAgICBjb2xvciA9 IFt3ZWJWaWV3LT5fY3VzdG9tQ29udGVudFZpZXcgYmFja2dyb3VuZENvbG9yXS5DR0NvbG9yOwog ICAgIGVsc2UKLSAgICAgICAgY29sb3IgPSBfcGFnZS0+cGFnZUV4dGVuZGVkQmFja2dyb3VuZENv bG9yKCk7CisgICAgICAgIGNvbG9yID0gd2ViVmlldy0+X3BhZ2UtPnBhZ2VFeHRlbmRlZEJhY2tn cm91bmRDb2xvcigpOwogCi0gICAgQ0dGbG9hdCB6b29tU2NhbGUgPSBjb250ZW50Wm9vbVNjYWxl KHNlbGYpOwotICAgIENHRmxvYXQgbWluaW11bVpvb21TY2FsZSA9IFtfc2Nyb2xsVmlldyBtaW5p bXVtWm9vbVNjYWxlXTsKKyAgICBDR0Zsb2F0IHpvb21TY2FsZSA9IGNvbnRlbnRab29tU2NhbGUo d2ViVmlldyk7CisgICAgQ0dGbG9hdCBtaW5pbXVtWm9vbVNjYWxlID0gW3dlYlZpZXctPl9zY3Jv bGxWaWV3IG1pbmltdW1ab29tU2NhbGVdOwogICAgIGlmICh6b29tU2NhbGUgPCBtaW5pbXVtWm9v bVNjYWxlKSB7CiAgICAgICAgIENHRmxvYXQgc2xvcGUgPSAxMjsKICAgICAgICAgQ0dGbG9hdCBv cGFjaXR5ID0gc3RkOjptYXg8Q0dGbG9hdD4oMSAtIHNsb3BlICogKG1pbmltdW1ab29tU2NhbGUg LSB6b29tU2NhbGUpLCAwKTsKICAgICAgICAgY29sb3IgPSBXZWJDb3JlOjpjb2xvcldpdGhPdmVy cmlkZUFscGhhKGNvbG9yLnJnYigpLCBvcGFjaXR5KTsKICAgICB9CiAKKyAgICByZXR1cm4gY29s b3I7Cit9CisKKy0gKHZvaWQpX3VwZGF0ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kCit7CisgICAgV2Vi Q29yZTo6Q29sb3IgY29sb3IgPSBzY3JvbGxWaWV3QmFja2dyb3VuZENvbG9yKHNlbGYpOworCiAg ICAgaWYgKF9zY3JvbGxWaWV3QmFja2dyb3VuZENvbG9yID09IGNvbG9yKQogICAgICAgICByZXR1 cm47CiAKQEAgLTExNTYsNiArMTE2OCwyNiBAQCBzdGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBj b25zdHJhaW5Db250ZW50T2Zmc2V0KFdlYkNvcmU6OkZsb2F0UG9pbnQgY29udGVudE9mZgogICAg IF9wYWdlLT52aWV3U3RhdGVEaWRDaGFuZ2UoV2ViQ29yZTo6Vmlld1N0YXRlOjpJc0luV2luZG93 KTsKIH0KIAorLSAodm9pZClzZXRPcGFxdWU6KEJPT0wpb3BhcXVlCit7CisgICAgQk9PTCBvbGRP cGFxdWUgPSBzZWxmLm9wYXF1ZTsKKworICAgIFtzdXBlciBzZXRPcGFxdWU6b3BhcXVlXTsKKyAg ICBbX2NvbnRlbnRWaWV3IHNldE9wYXF1ZTpvcGFxdWVdOworCisgICAgaWYgKG9sZE9wYXF1ZSA9 PSBvcGFxdWUpCisgICAgICAgIHJldHVybjsKKworICAgIF9wYWdlLT5zZXREcmF3c0JhY2tncm91 bmQob3BhcXVlKTsKKyAgICBbc2VsZiBfdXBkYXRlU2Nyb2xsVmlld0JhY2tncm91bmRdOworfQor CistICh2b2lkKXNldEJhY2tncm91bmRDb2xvcjooVUlDb2xvciAqKWJhY2tncm91bmRDb2xvcgor eworICAgIFtzdXBlciBzZXRCYWNrZ3JvdW5kQ29sb3I6YmFja2dyb3VuZENvbG9yXTsKKyAgICBb X2NvbnRlbnRWaWV3IHNldEJhY2tncm91bmRDb2xvcjpiYWNrZ3JvdW5kQ29sb3JdOworfQorCiAj cHJhZ21hIG1hcmsgLSBVSVNjcm9sbFZpZXdEZWxlZ2F0ZQogCiAtIChCT09MKXVzZXNTdGFuZGFy ZENvbnRlbnRWaWV3Cg==