134777 2014-07-09 14:24:54 -0700 [iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI 2014-07-09 21:38:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue enrica oldest_to_newest 1021441 0 joepeck 2014-07-09 14:24:54 -0700 Switch to UIAlertController API instead of SPI. 1021442 1 234657 joepeck 2014-07-09 14:25:41 -0700 Created attachment 234657 [PATCH] Proposed Fix 1021443 2 commit-queue 2014-07-09 14:28:21 -0700 Attachment 234657 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403: Missing space before { [whitespace/braces] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1021557 3 234657 commit-queue 2014-07-09 21:38:37 -0700 Comment on attachment 234657 [PATCH] Proposed Fix Clearing flags on attachment: 234657 Committed r170952: <http://trac.webkit.org/changeset/170952> 1021558 4 commit-queue 2014-07-09 21:38:39 -0700 All reviewed patches have been landed. Closing bug. 234657 2014-07-09 14:25:41 -0700 2014-07-09 21:38:37 -0700 [PATCH] Proposed Fix api.patch text/plain 3383 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNjBmMmJhLi4zYjA4MDdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDctMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBVc2UgVUlBbGVydENvbnRyb2xsZXIgQVBJIGluIFdLRmlsZVVwbG9hZFBh bmVsIGluc3RlYWQgb2YgU1BJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzQ3NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW06Cisg ICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIF9zaG93TWVkaWFTb3VyY2VTZWxlY3Rpb25TaGVl dF0pOgorCiAyMDE0LTA3LTA5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmU6OmVuc3VyZUJhY2tpbmdTdG9yZSBz aG91bGQgZW5zdXJlIHRoYXQgdGhlIGVudGlyZSBiYWNraW5nIHN0b3JlIGdldHMgcmVkcmF3bgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxv YWRQYW5lbC5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBs b2FkUGFuZWwubW0KaW5kZXggNDI5ODRjOC4uNDZlZWRjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCkBAIC00 MSw3ICs0MSw2IEBACiAjaW1wb3J0IDxBVkZvdW5kYXRpb24vQVZGb3VuZGF0aW9uLmg+CiAjaW1w b3J0IDxDb3JlTWVkaWEvQ29yZU1lZGlhLmg+CiAjaW1wb3J0IDxNb2JpbGVDb3JlU2VydmljZXMv TW9iaWxlQ29yZVNlcnZpY2VzLmg+Ci0jaW1wb3J0IDxVSUtpdC9VSUFsZXJ0Q29udHJvbGxlcl9Q cml2YXRlLmg+CiAjaW1wb3J0IDxVSUtpdC9VSUFwcGxpY2F0aW9uX1ByaXZhdGUuaD4KICNpbXBv cnQgPFVJS2l0L1VJSW1hZ2VQaWNrZXJDb250cm9sbGVyX1ByaXZhdGUuaD4KICNpbXBvcnQgPFVJ S2l0L1VJSW1hZ2VfUHJpdmF0ZS5oPgpAQCAtMzg4LDI0ICszODcsMjcgQEAgc3RhdGljIGJvb2wg c3RyaW5nSGFzUHJlZml4Q2FzZUluc2Vuc2l0aXZlKE5TU3RyaW5nICpzdHIsIE5TU3RyaW5nICpw cmVmaXgpCiAgICAgZWxzZQogICAgICAgICBjYW1lcmFTdHJpbmcgPSBXRUJfVUlfU1RSSU5HX0tF WSgiVGFrZSBQaG90byIsICJUYWtlIFBob3RvIChmaWxlIHVwbG9hZCBhY3Rpb24gc2hlZXQpIiwg IkZpbGUgVXBsb2FkIGFsZXJ0IHNoZWV0IGNhbWVyYSBidXR0b24gc3RyaW5nIGZvciB0YWtpbmcg b25seSBwaG90b3MiKTsKIAotICAgIF9hY3Rpb25TaGVldENvbnRyb2xsZXIgPSBbVUlBbGVydENv bnRyb2xsZXIgX2FsZXJ0Q29udHJvbGxlcldpdGhUaXRsZTpuaWwgbWVzc2FnZTpuaWxdOwotICAg IFtfYWN0aW9uU2hlZXRDb250cm9sbGVyIHNldFByZWZlcnJlZFN0eWxlOlVJQWxlcnRDb250cm9s bGVyU3R5bGVBY3Rpb25TaGVldF07CisgICAgX2FjdGlvblNoZWV0Q29udHJvbGxlciA9IFtVSUFs ZXJ0Q29udHJvbGxlciBhbGVydENvbnRyb2xsZXJXaXRoVGl0bGU6bmlsIG1lc3NhZ2U6bmlsIHBy ZWZlcnJlZFN0eWxlOlVJQWxlcnRDb250cm9sbGVyU3R5bGVBY3Rpb25TaGVldF07CiAKLSAgICBb X2FjdGlvblNoZWV0Q29udHJvbGxlciBfYWRkQWN0aW9uV2l0aFRpdGxlOmNhbmNlbFN0cmluZyBz dHlsZTpVSUFsZXJ0QWN0aW9uU3R5bGVDYW5jZWwgaGFuZGxlcjpeeworICAgIFVJQWxlcnRBY3Rp b24gKmNhbmNlbEFjdGlvbiA9IFtVSUFsZXJ0QWN0aW9uIGFjdGlvbldpdGhUaXRsZTpjYW5jZWxT dHJpbmcgc3R5bGU6VUlBbGVydEFjdGlvblN0eWxlQ2FuY2VsIGhhbmRsZXI6XihVSUFsZXJ0QWN0 aW9uICopewogICAgICAgICBbc2VsZiBfY2FuY2VsXTsKICAgICAgICAgLy8gV2UgaGFuZGxlZCBj YW5jZWwgb3Vyc2VsdmVzLiBQcmV2ZW50IHRoZSBwb3BvdmVyIGNvbnRyb2xsZXIgZGVsZWdhdGUg ZnJvbSBjYW5jZWxsaW5nIHdoZW4gdGhlIHBvcG92ZXIgZGlzbWlzc2VkLgogICAgICAgICBbX3By ZXNlbnRhdGlvblBvcG92ZXIgc2V0RGVsZWdhdGU6bmlsXTsKICAgICB9XTsKIAotICAgIFtfYWN0 aW9uU2hlZXRDb250cm9sbGVyIF9hZGRBY3Rpb25XaXRoVGl0bGU6Y2FtZXJhU3RyaW5nIHN0eWxl OlVJQWxlcnRBY3Rpb25TdHlsZURlZmF1bHQgaGFuZGxlcjpeeworICAgIFVJQWxlcnRBY3Rpb24g KmNhbWVyYUFjdGlvbiA9IFtVSUFsZXJ0QWN0aW9uIGFjdGlvbldpdGhUaXRsZTpjYW1lcmFTdHJp bmcgc3R5bGU6VUlBbGVydEFjdGlvblN0eWxlRGVmYXVsdCBoYW5kbGVyOl4oVUlBbGVydEFjdGlv biAqKXsKICAgICAgICAgX3VzaW5nQ2FtZXJhID0gWUVTOwogICAgICAgICBbc2VsZiBfc2hvd1Bo b3RvUGlja2VyV2l0aFNvdXJjZVR5cGU6VUlJbWFnZVBpY2tlckNvbnRyb2xsZXJTb3VyY2VUeXBl Q2FtZXJhXTsKICAgICB9XTsKIAotICAgIFtfYWN0aW9uU2hlZXRDb250cm9sbGVyIF9hZGRBY3Rp b25XaXRoVGl0bGU6ZXhpc3RpbmdTdHJpbmcgc3R5bGU6VUlBbGVydEFjdGlvblN0eWxlRGVmYXVs dCBoYW5kbGVyOl57CisgICAgVUlBbGVydEFjdGlvbiAqcGhvdG9MaWJyYXJ5QWN0aW9uID0gW1VJ QWxlcnRBY3Rpb24gYWN0aW9uV2l0aFRpdGxlOmV4aXN0aW5nU3RyaW5nIHN0eWxlOlVJQWxlcnRB Y3Rpb25TdHlsZURlZmF1bHQgaGFuZGxlcjpeKFVJQWxlcnRBY3Rpb24gKil7CiAgICAgICAgIFtz ZWxmIF9zaG93UGhvdG9QaWNrZXJXaXRoU291cmNlVHlwZTpVSUltYWdlUGlja2VyQ29udHJvbGxl clNvdXJjZVR5cGVQaG90b0xpYnJhcnldOwogICAgIH1dOwogCisgICAgW19hY3Rpb25TaGVldENv bnRyb2xsZXIgYWRkQWN0aW9uOmNhbmNlbEFjdGlvbl07CisgICAgW19hY3Rpb25TaGVldENvbnRy b2xsZXIgYWRkQWN0aW9uOmNhbWVyYUFjdGlvbl07CisgICAgW19hY3Rpb25TaGVldENvbnRyb2xs ZXIgYWRkQWN0aW9uOnBob3RvTGlicmFyeUFjdGlvbl07CisKICAgICBpZiAoVUlDdXJyZW50VXNl ckludGVyZmFjZUlkaW9tSXNQYWQoKSkKICAgICAgICAgW3NlbGYgX3ByZXNlbnRQb3BvdmVyV2l0 aENvbnRlbnRWaWV3Q29udHJvbGxlcjpfYWN0aW9uU2hlZXRDb250cm9sbGVyLmdldCgpIGFuaW1h dGVkOllFU107CiAgICAgZWxzZQo=