134776 2014-07-09 13:47:29 -0700 REGRESSION(r167770): Cannot login in Evernote Safari extension 2014-07-09 14:36:41 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa andersca commit-queue darin enrica oldest_to_newest 1021433 0 rniwa 2014-07-09 13:47:29 -0700 Turns out that NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification do not notify us when a popover becomes key so we need to keep using the SPI I removed. 1021435 1 234654 rniwa 2014-07-09 13:54:52 -0700 Created attachment 234654 Partially reverts r167770 1021446 2 234654 commit-queue 2014-07-09 14:36:38 -0700 Comment on attachment 234654 Partially reverts r167770 Clearing flags on attachment: 234654 Committed r170931: <http://trac.webkit.org/changeset/170931> 1021447 3 commit-queue 2014-07-09 14:36:41 -0700 All reviewed patches have been landed. Closing bug. 234654 2014-07-09 13:54:52 -0700 2014-07-09 14:36:38 -0700 Partially reverts r167770 bug-134776-20140709135434.patch text/plain 1851 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDkxNikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTA5 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjE2Nzc3MCk6IENhbm5vdCBsb2dpbiBpbiBFdmVybm90ZSBTYWZhcmkgZXh0ZW5zaW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ3NzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5 LCBOU1dpbmRvd0RpZEJlY29tZUtleU5vdGlmaWNhdGlvbiBkb2VzIG5vdCBub3RpZnkgdXMgd2hl biBhIHBvcG92ZXIgYmVjb21lcyBrZXkKKyAgICAgICAgc28gd2UgbmVlZCB0byBrZWVwIHVzaW5n IHRoZSBTUEkgKF93aW5kb3dDaGFuZ2VkS2V5U3RhdGUpIEkgcmVtb3ZlZCBpbiByMTY3NzcwLgor CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF93aW5k b3dDaGFuZ2VkS2V5U3RhdGVdKToKKwogMjAxNC0wNy0wOCAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBFeHBvc2UgYSBmZXcgZHJhd2luZy9j b21wb3NpdGluZyBzZXR0aW5ncyBvbiBXS1ByZWZlcmVuY2VzKFByaXZhdGUpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiAxNzA5MTYpCisrKyBTb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTI5NSw2ICsy OTUsNyBAQCBAaW50ZXJmYWNlIE5TVmlldyAoV2ViTlNWaWV3RGV0YWlscykKIC0gKE5TVmlldyAq KV9oaXRUZXN0OihOU1BvaW50ICopYVBvaW50IGRyYWdUeXBlczooTlNTZXQgKil0eXBlczsKIC0g KHZvaWQpX2F1dG9zY3JvbGxGb3JEcmFnZ2luZ0luZm86KGlkKWRyYWdJbmZvIHRpbWVEZWx0YToo TlNUaW1lSW50ZXJ2YWwpcmVwZWF0RGVsdGE7CiAtIChCT09MKV9zaG91bGRBdXRvc2Nyb2xsRm9y RHJhZ2dpbmdJbmZvOihpZClkcmFnSW5mbzsKKy0gKHZvaWQpX3dpbmRvd0NoYW5nZWRLZXlTdGF0 ZTsKIEBlbmQKIAogQGludGVyZmFjZSBOU1dpbmRvdyAoV2ViTlNXaW5kb3dEZXRhaWxzKQpAQCAt NTI3NCw2ICs1Mjc1LDEyIEBAIC0gKHZvaWQpZG9XaW5kb3dEaWRDaGFuZ2VTY3JlZW4KICAgICAg ICAgX3ByaXZhdGUtPnBhZ2UtPmNocm9tZSgpLndpbmRvd1NjcmVlbkRpZENoYW5nZSgoUGxhdGZv cm1EaXNwbGF5SUQpW1tbW1tzZWxmIHdpbmRvd10gc2NyZWVuXSBkZXZpY2VEZXNjcmlwdGlvbl0g b2JqZWN0Rm9yS2V5OkAiTlNTY3JlZW5OdW1iZXIiXSBpbnRWYWx1ZV0pOwogfQogCistICh2b2lk KV93aW5kb3dDaGFuZ2VkS2V5U3RhdGUKK3sKKyAgICBbc2VsZiBfdXBkYXRlQWN0aXZlU3RhdGVd OworICAgIFtzdXBlciBfd2luZG93Q2hhbmdlZEtleVN0YXRlXTsKK30KKwogLSAodm9pZCl3aW5k b3dLZXlTdGF0ZUNoYW5nZWQ6KE5TTm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiB7CiAgICAg W3NlbGYgX3VwZGF0ZUFjdGl2ZVN0YXRlXTsK