134759 2014-07-09 04:31:32 -0700 [EFL][WK2] Add new Public API in ewk_download_job.h to get length of the data already downloaded 2014-07-09 21:14:06 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi sergio oldest_to_newest 1021332 0 shiva.jm 2014-07-09 04:31:32 -0700 Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h. 1021334 1 234627 shiva.jm 2014-07-09 04:38:06 -0700 Created attachment 234627 Patch Add new API in ewk_download_job.h to get length of the data already downloaded. 1021335 2 234627 gyuyoung.kim 2014-07-09 04:41:34 -0700 Comment on attachment 234627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234627&action=review > Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193 > +EAPI uint64_t ewk_download_get_received_data_length(const Ewk_Download_Job *download); Missing API test for this new API. And also, looks wrong API naming. Generally verb is placed at the end of function name in EFL function. For example, ewk_download_received_data_length_get() 1021336 3 234628 shiva.jm 2014-07-09 05:00:57 -0700 Created attachment 234628 Patch-Updated-Review Updated the Patch with review comments 1021337 4 gyuyoung.kim 2014-07-09 05:04:23 -0700 (In reply to comment #0) > Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h. Could you explain why we have to add this API ? I wonder when application needs to know downloaded data length. 1021338 5 shiva.jm 2014-07-09 05:08:03 -0700 (In reply to comment #4) > (In reply to comment #0) > > Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h. > > Could you explain why we have to add this API ? I wonder when application needs to know downloaded data length. I feel these will be useful in multiple download and also for download manger kind of applications. 1021339 6 234628 gyuyoung.kim 2014-07-09 05:33:26 -0700 Comment on attachment 234628 Patch-Updated-Review View in context: https://bugs.webkit.org/attachment.cgi?id=234628&action=review LGTM except for minor nits. > Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:189 > + * @param download a #Ewk_Download_Job to query. We haven't add period at @param and @return. > Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:191 > + * @return the length of the data already downloaded. ditto. > Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193 > +EAPI uint64_t ewk_download_job_received_data_length_get(const Ewk_Download_Job *download); Isn't "data_size" more proper for this API ? > Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h:71 > + uint64_t receivedData() const; receivedDataSize() ? 1021538 7 234684 shiva.jm 2014-07-09 20:22:42 -0700 Created attachment 234684 Patch for landing 1021548 8 234684 commit-queue 2014-07-09 21:13:59 -0700 Comment on attachment 234684 Patch for landing Clearing flags on attachment: 234684 Committed r170951: <http://trac.webkit.org/changeset/170951> 1021549 9 commit-queue 2014-07-09 21:14:06 -0700 All reviewed patches have been landed. Closing bug. 234627 2014-07-09 04:38:06 -0700 2014-07-09 05:00:57 -0700 Patch bug-134759.patch text/plain 2917 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDkxNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA3LTA5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQg bmV3IFB1YmxpYyBBUEkgaW4gZXdrX2Rvd25sb2FkX2pvYi5oIHRvIGdldCBsZW5ndGggb2YgdGhl IGRhdGEgYWxyZWFkeSBkb3dubG9hZGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIG5ldyBBUEkgaW4gZXdrX2Rvd25sb2FkX2pvYi5oIHRvIGdl dCBsZW5ndGggb2YgdGhlIGRhdGEgYWxyZWFkeSBkb3dubG9hZGVkLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5jcHA6CisgICAgICAgIChld2tfZG93bmxv YWRfZ2V0X3JlY2VpdmVkX2RhdGFfbGVuZ3RoKToKKyAgICAgICAgKEV3a0Rvd25sb2FkSm9iOjpy ZWNlaXZlZERhdGEpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19kb3dubG9hZF9q b2IuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iX3ByaXZh dGUuaDoKKwogMjAxNC0wNy0wOSAgS3dhbmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNv bT4KIAogICAgICAgICBbRUZMXSBGaXggY3Jhc2ggY2F1c2VkIGJ5IGludmFsaWQgY3Vyc29yIGlt YWdlLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2Fk X2pvYi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX2Rvd25sb2FkX2pvYi5jcHAJKHJldmlzaW9uIDE3MDkxNSkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19kb3dubG9hZF9qb2IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMDMsNiArMjAzLDE4IEBAIGRvdWJsZSBFd2tEb3dubG9hZEpvYjo6ZWxhcHNlZFRpbWUoKSBj b24KICAgICByZXR1cm4gZWNvcmVfdGltZV9nZXQoKSAtIG1fc3RhcnRUaW1lOwogfQogCit1aW50 NjRfdCBld2tfZG93bmxvYWRfZ2V0X3JlY2VpdmVkX2RhdGFfbGVuZ3RoKGNvbnN0IEV3a19Eb3du bG9hZF9Kb2IqIGRvd25sb2FkKQoreworICAgIEVXS19PQkpfR0VUX0lNUExfT1JfUkVUVVJOKGNv bnN0IEV3a0Rvd25sb2FkSm9iLCBkb3dubG9hZCwgaW1wbCwgMCk7CisKKyAgICByZXR1cm4gaW1w bC0+cmVjZWl2ZWREYXRhKCk7Cit9CisKK3VpbnQ2NF90IEV3a0Rvd25sb2FkSm9iOjpyZWNlaXZl ZERhdGEoKSBjb25zdAoreworICAgIHJldHVybiBtX2Rvd25sb2FkZWQ7Cit9CisKIC8qKgogICog QGludGVybmFsCiAgKiBTZXRzIHRoZSBVUkwgQGEgcmVzcG9uc2UgZm9yIHRoaXMgQGEgZG93bmxv YWQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRf am9iLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X2Rvd25sb2FkX2pvYi5oCShyZXZpc2lvbiAxNzA5MTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Myw2 ICsxODMsMTUgQEAgRUFQSSBkb3VibGUgZXdrX2Rvd25sb2FkX2pvYl9lc3RpbWF0ZWRfcAogICov CiBFQVBJIGRvdWJsZSBld2tfZG93bmxvYWRfam9iX2VsYXBzZWRfdGltZV9nZXQoY29uc3QgRXdr X0Rvd25sb2FkX0pvYiAqZG93bmxvYWQpOwogCisvKioKKyAqIEdldHMgdGhlIGxlbmd0aCwgYWxy ZWFkeSBkb3dubG9hZGVkLgorICoKKyAqIEBwYXJhbSBkb3dubG9hZCBhICNFd2tfRG93bmxvYWRf Sm9iIHRvIHF1ZXJ5LgorICoKKyAqIEByZXR1cm4gdGhlIGxlbmd0aCBvZiB0aGUgZGF0YSBhbHJl YWR5IGRvd25sb2FkZWQuCisgKi8KK0VBUEkgdWludDY0X3QgZXdrX2Rvd25sb2FkX2dldF9yZWNl aXZlZF9kYXRhX2xlbmd0aChjb25zdCBFd2tfRG93bmxvYWRfSm9iICpkb3dubG9hZCk7CisKICNp ZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iX3ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iX3ByaXZhdGUuaAko cmV2aXNpb24gMTcwOTE1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X2Rvd25sb2FkX2pvYl9wcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDYgKzY4LDcgQEAg cHVibGljOgogICAgIGRvdWJsZSBlc3RpbWF0ZWRQcm9ncmVzcygpIGNvbnN0OwogICAgIGRvdWJs ZSBlbGFwc2VkVGltZSgpIGNvbnN0OwogICAgIHZvaWQgaW5jcmVtZW50UmVjZWl2ZWREYXRhKHVp bnQ2NF90IGxlbmd0aCk7CisgICAgdWludDY0X3QgcmVjZWl2ZWREYXRhKCkgY29uc3Q7CiAKIHBy aXZhdGU6CiAgICAgRXdrRG93bmxvYWRKb2IoV0tEb3dubG9hZFJlZiBkb3dubG9hZCwgRXdrVmll dyogdmlldyk7Cg== 234628 2014-07-09 05:00:57 -0700 2014-07-09 20:22:30 -0700 Patch-Updated-Review bug-134759-updated.patch text/plain 4266 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDkxNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA3LTA5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQg bmV3IFB1YmxpYyBBUEkgaW4gZXdrX2Rvd25sb2FkX2pvYi5oIHRvIGdldCBsZW5ndGggb2YgdGhl IGRhdGEgYWxyZWFkeSBkb3dubG9hZGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIG5ldyBBUEkgaW4gZXdrX2Rvd25sb2FkX2pvYi5oIHRvIGdl dCBsZW5ndGggb2YgdGhlIGRhdGEgYWxyZWFkeSBkb3dubG9hZGVkLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5jcHA6CisgICAgICAgIChld2tfZG93bmxv YWRfam9iX3JlY2VpdmVkX2RhdGFfbGVuZ3RoX2dldCk6CisgICAgICAgIChFd2tEb3dubG9hZEpv Yjo6cmVjZWl2ZWREYXRhKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxv YWRfam9iLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYl9w cml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rv d25sb2FkX2pvYi5jcHA6CisgICAgICAgIChFV0syRG93bmxvYWRKb2JUZXN0Ojpvbl9kb3dubG9h ZF9yZXF1ZXN0ZWQpOgorICAgICAgICAoRVdLMkRvd25sb2FkSm9iVGVzdDo6b25fZG93bmxvYWRf ZmluaXNoZWQpOgorCiAyMDE0LTA3LTA5ICBLd2FuZ0h5dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEZpeCBjcmFzaCBjYXVzZWQgYnkgaW52YWxpZCBjdXJz b3IgaW1hZ2UuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93 bmxvYWRfam9iLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfZG93bmxvYWRfam9iLmNwcAkocmV2aXNpb24gMTcwOTE1KQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIwMyw2ICsyMDMsMTggQEAgZG91YmxlIEV3a0Rvd25sb2FkSm9iOjplbGFwc2VkVGlt ZSgpIGNvbgogICAgIHJldHVybiBlY29yZV90aW1lX2dldCgpIC0gbV9zdGFydFRpbWU7CiB9CiAK K3VpbnQ2NF90IGV3a19kb3dubG9hZF9qb2JfcmVjZWl2ZWRfZGF0YV9sZW5ndGhfZ2V0KGNvbnN0 IEV3a19Eb3dubG9hZF9Kb2IqIGRvd25sb2FkKQoreworICAgIEVXS19PQkpfR0VUX0lNUExfT1Jf UkVUVVJOKGNvbnN0IEV3a0Rvd25sb2FkSm9iLCBkb3dubG9hZCwgaW1wbCwgMCk7CisKKyAgICBy ZXR1cm4gaW1wbC0+cmVjZWl2ZWREYXRhKCk7Cit9CisKK3VpbnQ2NF90IEV3a0Rvd25sb2FkSm9i OjpyZWNlaXZlZERhdGEoKSBjb25zdAoreworICAgIHJldHVybiBtX2Rvd25sb2FkZWQ7Cit9CisK IC8qKgogICogQGludGVybmFsCiAgKiBTZXRzIHRoZSBVUkwgQGEgcmVzcG9uc2UgZm9yIHRoaXMg QGEgZG93bmxvYWQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf ZG93bmxvYWRfam9iLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5oCShyZXZpc2lvbiAxNzA5MTUpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iLmgJKHdvcmtpbmcgY29weSkK QEAgLTE4Myw2ICsxODMsMTUgQEAgRUFQSSBkb3VibGUgZXdrX2Rvd25sb2FkX2pvYl9lc3RpbWF0 ZWRfcAogICovCiBFQVBJIGRvdWJsZSBld2tfZG93bmxvYWRfam9iX2VsYXBzZWRfdGltZV9nZXQo Y29uc3QgRXdrX0Rvd25sb2FkX0pvYiAqZG93bmxvYWQpOwogCisvKioKKyAqIEdldHMgdGhlIGxl bmd0aCwgYWxyZWFkeSBkb3dubG9hZGVkLgorICoKKyAqIEBwYXJhbSBkb3dubG9hZCBhICNFd2tf RG93bmxvYWRfSm9iIHRvIHF1ZXJ5LgorICoKKyAqIEByZXR1cm4gdGhlIGxlbmd0aCBvZiB0aGUg ZGF0YSBhbHJlYWR5IGRvd25sb2FkZWQuCisgKi8KK0VBUEkgdWludDY0X3QgZXdrX2Rvd25sb2Fk X2pvYl9yZWNlaXZlZF9kYXRhX2xlbmd0aF9nZXQoY29uc3QgRXdrX0Rvd25sb2FkX0pvYiAqZG93 bmxvYWQpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYl9wcml2YXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pv Yl9wcml2YXRlLmgJKHJldmlzaW9uIDE3MDkxNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19kb3dubG9hZF9qb2JfcHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02 OCw2ICs2OCw3IEBAIHB1YmxpYzoKICAgICBkb3VibGUgZXN0aW1hdGVkUHJvZ3Jlc3MoKSBjb25z dDsKICAgICBkb3VibGUgZWxhcHNlZFRpbWUoKSBjb25zdDsKICAgICB2b2lkIGluY3JlbWVudFJl Y2VpdmVkRGF0YSh1aW50NjRfdCBsZW5ndGgpOworICAgIHVpbnQ2NF90IHJlY2VpdmVkRGF0YSgp IGNvbnN0OwogCiBwcml2YXRlOgogICAgIEV3a0Rvd25sb2FkSm9iKFdLRG93bmxvYWRSZWYgZG93 bmxvYWQsIEV3a1ZpZXcqIHZpZXcpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25sb2FkX2pvYi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25sb2FkX2pv Yi5jcHAJKHJldmlzaW9uIDE3MDkxNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl9kb3dubG9hZF9qb2IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MDMsNiArMTAzLDcgQEAgcHVibGljOgogICAgICAgICBBU1NFUlRfRVEoRVdLX0RPV05MT0FEX0pP Ql9TVEFURV9OT1RfU1RBUlRFRCwgZXdrX2Rvd25sb2FkX2pvYl9zdGF0ZV9nZXQoZG93bmxvYWQp KTsKICAgICAgICAgQVNTRVJUX0VRKDAsIGV3a19kb3dubG9hZF9qb2JfZXN0aW1hdGVkX3Byb2dy ZXNzX2dldChkb3dubG9hZCkpOwogICAgICAgICBBU1NFUlRfRVEoMCwgZXdrX2Rvd25sb2FkX2pv Yl9lbGFwc2VkX3RpbWVfZ2V0KGRvd25sb2FkKSk7CisgICAgICAgIEFTU0VSVF9FUSgwLCBld2tf ZG93bmxvYWRfam9iX3JlY2VpdmVkX2RhdGFfbGVuZ3RoX2dldChkb3dubG9hZCkpOwogCiAgICAg ICAgIEV3a19VcmxfUmVxdWVzdCogcmVxdWVzdCA9IGV3a19kb3dubG9hZF9qb2JfcmVxdWVzdF9n ZXQoZG93bmxvYWQpOwogICAgICAgICBBU1NFUlRfVFJVRShyZXF1ZXN0KTsKQEAgLTE0Miw2ICsx NDMsNyBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVF9FUSgxLCBld2tfZG93bmxvYWRfam9iX2Vz dGltYXRlZF9wcm9ncmVzc19nZXQoZG93bmxvYWQpKTsKICAgICAgICAgQVNTRVJUX0VRKEVXS19E T1dOTE9BRF9KT0JfU1RBVEVfRklOSVNIRUQsIGV3a19kb3dubG9hZF9qb2Jfc3RhdGVfZ2V0KGRv d25sb2FkKSk7CiAgICAgICAgIEFTU0VSVF9HVChld2tfZG93bmxvYWRfam9iX2VsYXBzZWRfdGlt ZV9nZXQoZG93bmxvYWQpLCAwKTsKKyAgICAgICAgQVNTRVJUX0dUKGV3a19kb3dubG9hZF9qb2Jf cmVjZWl2ZWRfZGF0YV9sZW5ndGhfZ2V0KGRvd25sb2FkKSwgMCk7CiAKICAgICAgICAgQVNTRVJU X1RSVUUoZmlsZUV4aXN0cyh0ZXN0RGF0YS0+ZGVzdGluYXRpb25QYXRoKSk7CiAK 234684 2014-07-09 20:22:42 -0700 2014-07-09 21:13:58 -0700 Patch for landing bug-134759-20140710091046.patch text/plain 4474 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDk0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA3LTA5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQg bmV3IFB1YmxpYyBBUEkgaW4gZXdrX2Rvd25sb2FkX2pvYi5oIHRvIGdldCBzaXplIG9mIHRoZSBk YXRhIGFscmVhZHkgZG93bmxvYWRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNDc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlvdW5nIEtp bS4KKworICAgICAgICBBZGQgbmV3IEFQSSBpbiBld2tfZG93bmxvYWRfam9iLmggdG8gZ2V0IHNp emUgb2YgdGhlIGRhdGEgYWxyZWFkeSBkb3dubG9hZGVkLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5jcHA6CisgICAgICAgIChld2tfZG93bmxvYWRfam9i X3JlY2VpdmVkX2RhdGFfbGVuZ3RoX2dldCk6CisgICAgICAgIChFd2tEb3dubG9hZEpvYjo6cmVj ZWl2ZWREYXRhKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9i Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYl9wcml2YXRl Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25sb2Fk X2pvYi5jcHA6CisgICAgICAgIChFV0syRG93bmxvYWRKb2JUZXN0Ojpvbl9kb3dubG9hZF9yZXF1 ZXN0ZWQpOgorICAgICAgICAoRVdLMkRvd25sb2FkSm9iVGVzdDo6b25fZG93bmxvYWRfZmluaXNo ZWQpOgorCiAyMDE0LTA3LTA5ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMTcwODU4KTogU2FmYXJpIGZyZWV6ZXMgdXBvbiBtYWtpbmcg YSBzZWFyY2ggb24gYSB3ZWJzaXRlICh5ZWxwLmNvbSkuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iLmNwcAkocmV2aXNp b24gMTcwOTQ4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25s b2FkX2pvYi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMyw2ICsyMDMsMTggQEAgZG91YmxlIEV3 a0Rvd25sb2FkSm9iOjplbGFwc2VkVGltZSgpIGNvbgogICAgIHJldHVybiBlY29yZV90aW1lX2dl dCgpIC0gbV9zdGFydFRpbWU7CiB9CiAKK3VpbnQ2NF90IGV3a19kb3dubG9hZF9qb2JfcmVjZWl2 ZWRfZGF0YV9zaXplX2dldChjb25zdCBFd2tfRG93bmxvYWRfSm9iKiBkb3dubG9hZCkKK3sKKyAg ICBFV0tfT0JKX0dFVF9JTVBMX09SX1JFVFVSTihjb25zdCBFd2tEb3dubG9hZEpvYiwgZG93bmxv YWQsIGltcGwsIDApOworCisgICAgcmV0dXJuIGltcGwtPnJlY2VpdmVkRGF0YVNpemUoKTsKK30K KwordWludDY0X3QgRXdrRG93bmxvYWRKb2I6OnJlY2VpdmVkRGF0YVNpemUoKSBjb25zdAorewor ICAgIHJldHVybiBtX2Rvd25sb2FkZWQ7Cit9CisKIC8qKgogICogQGludGVybmFsCiAgKiBTZXRz IHRoZSBVUkwgQGEgcmVzcG9uc2UgZm9yIHRoaXMgQGEgZG93bmxvYWQuCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxvYWRfam9iLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Rvd25sb2FkX2pvYi5oCShy ZXZpc2lvbiAxNzA5NDgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf ZG93bmxvYWRfam9iLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Myw2ICsxODMsMTggQEAgRUFQSSBk b3VibGUgZXdrX2Rvd25sb2FkX2pvYl9lc3RpbWF0ZWRfcAogICovCiBFQVBJIGRvdWJsZSBld2tf ZG93bmxvYWRfam9iX2VsYXBzZWRfdGltZV9nZXQoY29uc3QgRXdrX0Rvd25sb2FkX0pvYiAqZG93 bmxvYWQpOwogCisvKioKKyAqIEdldHMgdGhlIGRhdGEgc2l6ZSwgYWxyZWFkeSBkb3dubG9hZGVk LgorICoKKyAqIElmIHRoZSBkb3dubG9hZCBmaW5pc2hlZCwgaGFkIGFuIGVycm9yIG9yIHdhcyBj YW5jZWxsZWQgdGhpcyBpcworICogdGhlIGRhdGEgc2l6ZSBiZXR3ZWVuIGl0cyBzdGFydCBhbmQg dGhlIGVuZC4KKyAqCisgKiBAcGFyYW0gZG93bmxvYWQgYSAjRXdrX0Rvd25sb2FkX0pvYiB0byBx dWVyeS4KKyAqCisgKiBAcmV0dXJuIHRoZSBzaXplIG9mIHRoZSBkYXRhIGFscmVhZHkgZG93bmxv YWRlZCwgc2luY2UgdGhlIGRvd25sb2FkIHdhcyBzdGFydGVkIG9yIDAuMCBpbiBjYXNlIG9mIGZh aWx1cmUuCisgKi8KK0VBUEkgdWludDY0X3QgZXdrX2Rvd25sb2FkX2pvYl9yZWNlaXZlZF9kYXRh X3NpemVfZ2V0KGNvbnN0IEV3a19Eb3dubG9hZF9Kb2IgKmRvd25sb2FkKTsKKwogI2lmZGVmIF9f Y3BsdXNwbHVzCiB9CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a19kb3dubG9hZF9qb2JfcHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19kb3dubG9hZF9qb2JfcHJpdmF0ZS5oCShyZXZpc2lv biAxNzA5NDgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZG93bmxv YWRfam9iX3ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCBwdWJsaWM6 CiAgICAgZG91YmxlIGVzdGltYXRlZFByb2dyZXNzKCkgY29uc3Q7CiAgICAgZG91YmxlIGVsYXBz ZWRUaW1lKCkgY29uc3Q7CiAgICAgdm9pZCBpbmNyZW1lbnRSZWNlaXZlZERhdGEodWludDY0X3Qg bGVuZ3RoKTsKKyAgICB1aW50NjRfdCByZWNlaXZlZERhdGFTaXplKCkgY29uc3Q7CiAKIHByaXZh dGU6CiAgICAgRXdrRG93bmxvYWRKb2IoV0tEb3dubG9hZFJlZiBkb3dubG9hZCwgRXdrVmlldyog dmlldyk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0 X2V3azJfZG93bmxvYWRfam9iLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfZG93bmxvYWRfam9iLmNwcAkocmV2aXNpb24g MTcwOTQ4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9l d2syX2Rvd25sb2FkX2pvYi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2ICsxMDMsNyBAQCBw dWJsaWM6CiAgICAgICAgIEFTU0VSVF9FUShFV0tfRE9XTkxPQURfSk9CX1NUQVRFX05PVF9TVEFS VEVELCBld2tfZG93bmxvYWRfam9iX3N0YXRlX2dldChkb3dubG9hZCkpOwogICAgICAgICBBU1NF UlRfRVEoMCwgZXdrX2Rvd25sb2FkX2pvYl9lc3RpbWF0ZWRfcHJvZ3Jlc3NfZ2V0KGRvd25sb2Fk KSk7CiAgICAgICAgIEFTU0VSVF9FUSgwLCBld2tfZG93bmxvYWRfam9iX2VsYXBzZWRfdGltZV9n ZXQoZG93bmxvYWQpKTsKKyAgICAgICAgQVNTRVJUX0VRKDAsIGV3a19kb3dubG9hZF9qb2JfcmVj ZWl2ZWRfZGF0YV9zaXplX2dldChkb3dubG9hZCkpOwogCiAgICAgICAgIEV3a19VcmxfUmVxdWVz dCogcmVxdWVzdCA9IGV3a19kb3dubG9hZF9qb2JfcmVxdWVzdF9nZXQoZG93bmxvYWQpOwogICAg ICAgICBBU1NFUlRfVFJVRShyZXF1ZXN0KTsKQEAgLTE0Miw2ICsxNDMsNyBAQCBwdWJsaWM6CiAg ICAgICAgIEFTU0VSVF9FUSgxLCBld2tfZG93bmxvYWRfam9iX2VzdGltYXRlZF9wcm9ncmVzc19n ZXQoZG93bmxvYWQpKTsKICAgICAgICAgQVNTRVJUX0VRKEVXS19ET1dOTE9BRF9KT0JfU1RBVEVf RklOSVNIRUQsIGV3a19kb3dubG9hZF9qb2Jfc3RhdGVfZ2V0KGRvd25sb2FkKSk7CiAgICAgICAg IEFTU0VSVF9HVChld2tfZG93bmxvYWRfam9iX2VsYXBzZWRfdGltZV9nZXQoZG93bmxvYWQpLCAw KTsKKyAgICAgICAgQVNTRVJUX0dUKGV3a19kb3dubG9hZF9qb2JfcmVjZWl2ZWRfZGF0YV9zaXpl X2dldChkb3dubG9hZCksIDApOwogCiAgICAgICAgIEFTU0VSVF9UUlVFKGZpbGVFeGlzdHModGVz dERhdGEtPmRlc3RpbmF0aW9uUGF0aCkpOwogCg==