134757 2014-07-09 03:53:33 -0700 mutable pointers from const methods, timeContainer() 2014-07-16 17:52:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 je_julie.kim webkit-unassigned ap commit-queue dbates d-r fmalita gyuyoung.kim pdr rniwa schenney sergio oldest_to_newest 1021326 0 je_julie.kim 2014-07-09 03:53:33 -0700 According to https://lists.webkit.org/pipermail/webkit-dev/2012-October/022580.html, We avoid return mutable pointers from const methods. timeContainer() doesn't need to be const method. 1021328 1 234625 je_julie.kim 2014-07-09 04:04:14 -0700 Created attachment 234625 Patch 1021329 2 je_julie.kim 2014-07-09 04:11:12 -0700 After I discussed const method with Daniel Bates on IRC, I've checked timeContainer() const method. I think that API doesn't need to be const method. Please take a look. 1022723 3 234625 commit-queue 2014-07-16 08:03:57 -0700 Comment on attachment 234625 Patch Clearing flags on attachment: 234625 Committed r171144: <http://trac.webkit.org/changeset/171144> 1022724 4 commit-queue 2014-07-16 08:04:02 -0700 All reviewed patches have been landed. Closing bug. 1022748 5 ap 2014-07-16 09:44:56 -0700 This commit has added svn:executable bit to several files. I removed it in <http://trac.webkit.org/r171147>. Any idea how it got there? It was not in the patch, and the patch was landed by commit queue. Did someone break commit queue recently? 1022749 6 ap 2014-07-16 09:48:07 -0700 Actually, it was in the patch: > old mode 100644 > new mode 100755 1022884 7 je_julie.kim 2014-07-16 17:52:17 -0700 Sorry for the inconvenience. I checked it with ap on IRC. I'll check patch with that mode information next time. Thanks, 234625 2014-07-09 04:04:14 -0700 2014-07-16 08:03:57 -0700 Patch bug-134757-20140709200356.patch text/plain 2185 je_julie.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBt b2RlIDEwMDc1NQppbmRleCAyMmM1MjQyMWZmMTM0NGNkMjQ0NWI2NDBiMzk0ZWM3Nzk2ZDZjZThk Li40OWI2NzI3NDFhMGE1M2U1ZTVmZTFkZjM1MzBkZjAxZjY5MTZiZTBlCi0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNyBAQAorMjAxNC0wNy0wOSAgSmVvbmdldW4gS2ltICA8amVfanVsaWUua2ltQHNhbXN1bmcu Y29tPgorCisgICAgICAgIG11dGFibGUgcG9pbnRlcnMgZnJvbSBjb25zdCBtZXRob2RzLCB0aW1l Q29udGFpbmVyKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQ3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBdm9pZCByZXR1cm4gbXV0YWJsZSBwb2ludGVycyBmcm9tIGNvbnN0IG1ldGhvZHMuCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogc3Zn L1NWR1NWR0VsZW1lbnQuaDoKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50 Lmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdTTUlMRWxlbWVudDo6dGltZUNvbnRhaW5lcik6CisK IDIwMTQtMDctMDYgIFlvYXYgV2Vpc3MgIDx5b2F2QHlvYXYud3M+CiAKICAgICAgICAgVHVybiBv biBpbWdAc2l6ZXMgY29tcGlsZSBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHU1ZHRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1NWR0VsZW1lbnQuaApvbGQg bW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IGJiYTdlNjc4MmVmMGMyODQ1M2EyMjNl ZmU4YjIxYWNiNzMxZDQ4ZTYuLmI4ZTZiM2QwNzk5ZDE4NzA2N2M2ZDkyODMxOTg1OTNiNDE4MzEy YTUKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1NWR0VsZW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5oCkBAIC04Myw3ICs4Myw3IEBAIHB1YmxpYzoKICAg ICAvLyBPbmx5IHVzZWQgZnJvbSB0aGUgYmluZGluZ3MuCiAgICAgdm9pZCB1cGRhdGVDdXJyZW50 VHJhbnNsYXRlKCk7CiAKLSAgICBTTUlMVGltZUNvbnRhaW5lciogdGltZUNvbnRhaW5lcigpIGNv bnN0IHsgcmV0dXJuIG1fdGltZUNvbnRhaW5lci5nZXQoKTsgfQorICAgIFNNSUxUaW1lQ29udGFp bmVyKiB0aW1lQ29udGFpbmVyKCkgeyByZXR1cm4gbV90aW1lQ29udGFpbmVyLmdldCgpOyB9CiAg ICAgCiAgICAgdm9pZCBwYXVzZUFuaW1hdGlvbnMoKTsKICAgICB2b2lkIHVucGF1c2VBbmltYXRp b25zKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxF bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgK b2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCAxMmZhMTgxMGY4NWFlMmViZGQ4 ZmMyZWFmYzk5MzA0ODZmZTI4MjlkLi4xZWVmMzE4NmQyZWYxZTczYTc1ZWU1ZWM0MjM3NDY4ODk5 YjBmMjc5Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgKQEAg LTUyLDcgKzUyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBoYXNWYWxpZEF0dHJpYnV0 ZU5hbWUoKTsKICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0aW9uQXR0cmlidXRlQ2hhbmdlZCgpID0g MDsKIAotICAgIFNNSUxUaW1lQ29udGFpbmVyKiB0aW1lQ29udGFpbmVyKCkgY29uc3QgeyByZXR1 cm4gbV90aW1lQ29udGFpbmVyLmdldCgpOyB9CisgICAgU01JTFRpbWVDb250YWluZXIqIHRpbWVD b250YWluZXIoKSB7IHJldHVybiBtX3RpbWVDb250YWluZXIuZ2V0KCk7IH0KIAogICAgIFNWR0Vs ZW1lbnQqIHRhcmdldEVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBtX3RhcmdldEVsZW1lbnQ7IH0K ICAgICBjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyaWJ1dGVOYW1lKCkgY29uc3QgeyByZXR1cm4g bV9hdHRyaWJ1dGVOYW1lOyB9Cg==