<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134746</bug_id>
          
          <creation_ts>2014-07-08 15:30:30 -0700</creation_ts>
          <short_desc>VM::lastCachedString should be a Strong, not a Weak.</short_desc>
          <delta_ts>2014-07-08 15:43:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>kling</cc>
    
    <cc>mhahnenberg</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1021217</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-07-08 15:30:30 -0700</bug_when>
    <thetext>Fatch porthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1021218</commentid>
    <comment_count>1</comment_count>
      <attachid>234601</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-07-08 15:30:55 -0700</bug_when>
    <thetext>Created attachment 234601
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1021219</commentid>
    <comment_count>2</comment_count>
      <attachid>234601</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-07-08 15:36:09 -0700</bug_when>
    <thetext>Comment on attachment 234601
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1021223</commentid>
    <comment_count>3</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-07-08 15:43:05 -0700</bug_when>
    <thetext>Committed r170898: &lt;http://trac.webkit.org/changeset/170898&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>234601</attachid>
            <date>2014-07-08 15:30:55 -0700</date>
            <delta_ts>2014-07-08 15:36:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-134746.diff</filename>
            <type>text/plain</type>
            <size>2255</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUwOWE5NDkuLjhmMDU0MTQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA3LTA4ICBBbmRyZWFzIEtsaW5n
ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBWTTo6bGFzdENhY2hlZFN0cmluZyBzaG91
bGQgYmUgYSBTdHJvbmcsIG5vdCBhIFdlYWsuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcv
Yi8xMzQ3NDY+CisKKyAgICAgICAgVXNpbmcgV2VhazxKU1N0cmluZz4gZm9yIHRoaXMgcmVncmVz
c2VkIHNvbWUgb2Ygb3VyIGJpbmRpbmdzIHBlcmYgdGVzdHMKKyAgICAgICAgZHVlIHRvIFdlYWsg
aGF2aW5nIHRvIGFsbG9jYXRlIGEgbmV3IFdlYWtJbXBsIGV2ZXJ5IHRpbWUgdGhlIGxhc3QgY2Fj
aGVkCisgICAgICAgIHN0cmluZyBjaGFuZ2VkLiBNYWtlIGl0IGEgU3Ryb25nIGluc3RlYWQgc2hv
dWxkIG1ha2UgdGhhdCBwcm9ibGVtIGdvIGF3YXkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmNwcDoKKyAgICAgICAg
KEpTQzo6anNTdHJpbmdXaXRoQ2FjaGVTbG93Q2FzZSk6CisgICAgICAgICogcnVudGltZS9WTS5o
OgorCiAyMDE0LTA3LTA3ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgog
CiAgICAgICAgIEZpeCB0aGUgYnVpbGQgYWZ0ZXIgcjE3MDg3NgpkaWZmIC0tZ2l0IGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCmluZGV4IGNkYzM0ZDYuLjEwYTE2ZDkgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcAorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAKQEAgLTI5LDYgKzI5LDcgQEAK
ICNpbmNsdWRlICJKU0NJbmxpbmVzLmgiCiAjaW5jbHVkZSAiU3RyaW5nT2JqZWN0LmgiCiAjaW5j
bHVkZSAiU3RyaW5nUHJvdG90eXBlLmgiCisjaW5jbHVkZSAiU3Ryb25nSW5saW5lcy5oIgogCiBu
YW1lc3BhY2UgSlNDIHsKICAgICAKQEAgLTM3OSw3ICszODAsNyBAQCBKU1N0cmluZyoganNTdHJp
bmdXaXRoQ2FjaGVTbG93Q2FzZShWTSYgdm0sIFN0cmluZ0ltcGwmIHN0cmluZ0ltcGwpCiAgICAg
YXV0byBhZGRSZXN1bHQgPSB2bS5zdHJpbmdDYWNoZS5hZGQoJnN0cmluZ0ltcGwsIG51bGxwdHIp
OwogICAgIGlmIChhZGRSZXN1bHQuaXNOZXdFbnRyeSkKICAgICAgICAgYWRkUmVzdWx0Lml0ZXJh
dG9yLT52YWx1ZSA9IGpzU3RyaW5nKCZ2bSwgU3RyaW5nKHN0cmluZ0ltcGwpKTsKLSAgICB2bS5s
YXN0Q2FjaGVkU3RyaW5nID0gYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZS5nZXQoKTsKKyAgICB2
bS5sYXN0Q2FjaGVkU3RyaW5nLnNldCh2bSwgYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZS5nZXQo
KSk7CiAgICAgcmV0dXJuIGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUuZ2V0KCk7CiB9CiAKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmggYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCmluZGV4IDMyNTE4MDkuLjFmNGQxNzIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL3J1bnRpbWUvVk0uaApAQCAtMjk3LDcgKzI5Nyw3IEBAIG5hbWVzcGFjZSBKU0Mg
ewogICAgICAgICBEYXRlSW5zdGFuY2VDYWNoZSBkYXRlSW5zdGFuY2VDYWNoZTsKICAgICAgICAg
V1RGOjpTaW1wbGVTdGF0cyBtYWNoaW5lQ29kZUJ5dGVzUGVyQnl0ZWNvZGVXb3JkRm9yQmFzZWxp
bmVKSVQ7CiAgICAgICAgIFdlYWtHQ01hcDxTdHJpbmdJbXBsKiwgSlNTdHJpbmcsIFB0ckhhc2g8
U3RyaW5nSW1wbCo+PiBzdHJpbmdDYWNoZTsKLSAgICAgICAgV2VhazxKU1N0cmluZz4gbGFzdENh
Y2hlZFN0cmluZzsKKyAgICAgICAgU3Ryb25nPEpTU3RyaW5nPiBsYXN0Q2FjaGVkU3RyaW5nOwog
CiAgICAgICAgIEF0b21pY1N0cmluZ1RhYmxlKiBhdG9taWNTdHJpbmdUYWJsZSgpIGNvbnN0IHsg
cmV0dXJuIG1fYXRvbWljU3RyaW5nVGFibGU7IH0KIAo=
</data>
<flag name="review"
          id="259138"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>