<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134719</bug_id>
          
          <creation_ts>2014-07-07 23:31:00 -0700</creation_ts>
          <short_desc>Fix build warning in /WebKit/Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp</short_desc>
          <delta_ts>2014-09-15 01:37:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>134975</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tanay">tanay.c</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1021047</commentid>
    <comment_count>0</comment_count>
    <who name="Tanay">tanay.c</who>
    <bug_when>2014-07-07 23:31:00 -0700</bug_when>
    <thetext>/home/tanay.c/webkit-svn/WebKit/Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp:47:6: warning: unused parameter â€˜dataâ€™ [-Wunused-parameter]
 bool decodeLegacySessionState(const uint8_t* data, size_t, SessionState&amp;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1021063</commentid>
    <comment_count>1</comment_count>
      <attachid>234554</attachid>
    <who name="Tanay">tanay.c</who>
    <bug_when>2014-07-08 03:13:10 -0700</bug_when>
    <thetext>Created attachment 234554
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1022971</commentid>
    <comment_count>2</comment_count>
    <who name="Tanay">tanay.c</who>
    <bug_when>2014-07-16 23:24:29 -0700</bug_when>
    <thetext>Request to commit the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023673</commentid>
    <comment_count>3</comment_count>
      <attachid>234554</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-07-21 08:51:19 -0700</bug_when>
    <thetext>Comment on attachment 234554
Patch

Rejecting attachment 234554 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.appspot.com&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 234554, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Sam Weinig&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4889753199575040</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1029754</commentid>
    <comment_count>4</comment_count>
    <who name="Tanay">tanay.c</who>
    <bug_when>2014-08-18 05:08:40 -0700</bug_when>
    <thetext>Duplicate of https://bugs.webkit.org/show_bug.cgi?id=134975</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1035180</commentid>
    <comment_count>5</comment_count>
    <who name="Tanay">tanay.c</who>
    <bug_when>2014-09-15 01:37:58 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 134975 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>234554</attachid>
            <date>2014-07-08 03:13:10 -0700</date>
            <delta_ts>2014-07-21 08:51:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-134719-20140708154331.patch</filename>
            <type>text/plain</type>
            <size>1275</size>
            <attacher name="Tanay">tanay.c</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDg4MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA3LTA4ICBUYW5heSBD
ICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBpbiAv
V2ViS2l0L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MZWdhY3lTZXNzaW9uU3RhdGVDb2RpbmdO
b25lLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTM0NzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBVSVByb2Nlc3MvTGVnYWN5U2Vzc2lvblN0YXRlQ29kaW5nTm9uZS5jcHA6CisgICAgICAgIChX
ZWJLaXQ6OmRlY29kZUxlZ2FjeVNlc3Npb25TdGF0ZSk6IHJlbW92ZWQgdW51c2VkIHBhcmFtZXRl
cgorCiAyMDE0LTA3LTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog
CiAgICAgICAgIFR1cm4gb24gYWNjZWxlcmF0ZWQgZHJhd2luZyBmb3IgV2ViS2l0MiBieSBkZWZh
dWx0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGVnYWN5U2Vzc2lvblN0YXRlQ29k
aW5nTm9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xlZ2Fj
eVNlc3Npb25TdGF0ZUNvZGluZ05vbmUuY3BwCShyZXZpc2lvbiAxNzA4ODEpCisrKyBTb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvTGVnYWN5U2Vzc2lvblN0YXRlQ29kaW5nTm9uZS5jcHAJKHdvcmtp
bmcgY29weSkKQEAgLTQ0LDcgKzQ0LDcgQEAgUmVmUHRyPEFQSTo6RGF0YT4gZW5jb2RlTGVnYWN5
U2Vzc2lvbkhpcwogICAgIHJldHVybiBBUEk6OkRhdGE6OmNyZWF0ZShudWxscHRyLCAwKTsKIH0K
IAotYm9vbCBkZWNvZGVMZWdhY3lTZXNzaW9uU3RhdGUoY29uc3QgdWludDhfdCogZGF0YSwgc2l6
ZV90LCBTZXNzaW9uU3RhdGUmKQorYm9vbCBkZWNvZGVMZWdhY3lTZXNzaW9uU3RhdGUoY29uc3Qg
dWludDhfdCosIHNpemVfdCwgU2Vzc2lvblN0YXRlJikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgp
OwogICAgIHJldHVybiBmYWxzZTsK
</data>
<flag name="review"
          id="259090"
          type_id="1"
          status="+"
          setter="sam"
    />
    <flag name="commit-queue"
          id="259102"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>