134711 2014-07-07 19:06:52 -0700 WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect 2014-07-08 12:28:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca mitz sam oldest_to_newest 1021002 0 thorton 2014-07-07 19:06:52 -0700 Because nothing ever reads from it! It would also be nice if MiniBrowser had a maximumProcessCount=1 mode; frequently useful for debugging things where having two pages in one process is important. 1021016 1 thorton 2014-07-07 20:00:30 -0700 Huh, I see no indication that there's a process cap by default. I thought it was 20 or some such? 1021155 2 234581 thorton 2014-07-08 12:19:57 -0700 Created attachment 234581 patch 1021157 3 234581 mitz 2014-07-08 12:22:38 -0700 Comment on attachment 234581 patch View in context: https://bugs.webkit.org/attachment.cgi?id=234581&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:173 > + _context->setMaximumNumberOfProcesses(configuration.maximumProcessCount); Everywhere else in this method we use the instance variable _configuration, not the parameter. 1021158 4 thorton 2014-07-08 12:28:43 -0700 http://trac.webkit.org/changeset/170893 234581 2014-07-08 12:19:57 -0700 2014-07-08 12:22:37 -0700 patch max.diff text/plain 1558 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZWVhNWM5Li5jODhkZGM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA3LTA4ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFdLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uUHJpdmF0ZSdzIG1heGltdW1Qcm9j ZXNzQ291bnQgcHJvcGVydHkgaGFzIG5vIGVmZmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0NzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bv b2wubW06CisgICAgICAgICgtW1dLUHJvY2Vzc1Bvb2wgX2luaXRXaXRoQ29uZmlndXJhdGlvbjpd KToKKyAgICAgICAgUmVzcGVjdCB0aGUgbWF4aW11bVByb2Nlc3NDb3VudC4KKyAgICAgICAgQ3Vy cmVudGx5IHRoZSBkZWZhdWx0IGxpbWl0IGlzIFVJTlRfTUFYOyBpZiBtYXhpbXVtUHJvY2Vzc0Nv dW50ID0gMCAodGhlIGRlZmF1bHQpLCB3ZSdsbCB1c2UgdGhhdCBsaW1pdC4KKwogMjAxNC0wNy0w OCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIE1vdmUgdXNlciBzdHlsZSBzaGVldCBBUEkgb3V0IG9mIFdlYktpdFdlYlZpZXdHcm91 cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nl c3NQb29sLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQ b29sLm1tCmluZGV4IGNiMmFmOTk4Li5lNzI0ZmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tCkBAIC0xNzAsNiArMTcwLDcg QEAgLSAoaW5zdGFuY2V0eXBlKV9pbml0V2l0aENvbmZpZ3VyYXRpb246KF9XS1Byb2Nlc3NQb29s Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXQKICAgICBfY29udGV4dC0+c2V0SGlzdG9yeUNsaWVu dChzdGQ6Om1ha2VfdW5pcXVlPFdlYktpdDo6SGlzdG9yeUNsaWVudD4oKSk7CiAgICAgX2NvbnRl eHQtPnNldFVzZXNOZXR3b3JrUHJvY2Vzcyh0cnVlKTsKICAgICBfY29udGV4dC0+c2V0UHJvY2Vz c01vZGVsKFdlYktpdDo6UHJvY2Vzc01vZGVsTXVsdGlwbGVTZWNvbmRhcnlQcm9jZXNzZXMpOwor ICAgIF9jb250ZXh0LT5zZXRNYXhpbXVtTnVtYmVyT2ZQcm9jZXNzZXMoY29uZmlndXJhdGlvbi5t YXhpbXVtUHJvY2Vzc0NvdW50KTsKIAogI2lmIEVOQUJMRShDQUNIRV9QQVJUSVRJT05JTkcpCiAg ICAgZm9yIChOU1N0cmluZyAqdXJsU2NoZW1lIGluIFtfY29uZmlndXJhdGlvbiBjYWNoZVBhcnRp dGlvbmVkVVJMU2NoZW1lc10pCg==