134704 2014-07-07 16:58:37 -0700 Web Inspector: CSS style declaration editor should ignore empty lines when determining prefix whitespace 2014-07-08 12:12:18 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jonowells jonowells commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1020970 0 jonowells 2014-07-07 16:58:37 -0700 The CSS style editor looks for the line with the shortest prefixed whitespace and strips that from every line, the idea being that the baseline indentation is ignored and the rules look better. Indentation relative to that baseline is honored. The change made in https://bugs.webkit.org/show_bug.cgi?id=133515 properly handles lines with zero-length prefixed whitespace lines, but doesn't consider completely empty lines in cases such as: div { font-weight: bold; color: red; display: inline; } The empty line here lacks any spaces or tabs. In this case the empty line should be ignored as it is likely the author is eliminating all trailing whitespace from the document. This is so common that many inspected style declarations appear indented when they should not. 1020972 1 webkit-bug-importer 2014-07-07 16:58:45 -0700 <rdar://problem/17583210> 1020974 2 234527 jonowells 2014-07-07 17:07:34 -0700 Created attachment 234527 [PATCH] Attempted fix. 1020981 3 234527 joepeck 2014-07-07 18:06:28 -0700 Comment on attachment 234527 [PATCH] Attempted fix. Awesome. r=me 1020986 4 234527 commit-queue 2014-07-07 18:39:03 -0700 Comment on attachment 234527 [PATCH] Attempted fix. Clearing flags on attachment: 234527 Committed r170868: <http://trac.webkit.org/changeset/170868> 1020987 5 commit-queue 2014-07-07 18:39:06 -0700 All reviewed patches have been landed. Closing bug. 1021150 6 234527 timothy 2014-07-08 12:12:18 -0700 Comment on attachment 234527 [PATCH] Attempted fix. Nice fix! We will likely add the space o the empty line in _formattedContent before committing the change. We likely want to only do that for lines with content to prevent unneeded whitespace. Not critical though. 234527 2014-07-07 17:07:34 -0700 2014-07-08 12:12:18 -0700 [PATCH] Attempted fix. ruleindent.diff text/plain 2818 jonowells ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5NTQ5ZTcuLjIwYzgwYjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTA3ICBKb25hdGhhbiBXZWxs cyAgPGpvbm93ZWxsc0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIHN0 eWxlIGRlY2xhcmF0aW9uIGVkaXRvciBzaG91bGQgaWdub3JlIGVtcHR5IGxpbmVzIHdoZW4gZGV0 ZXJtaW5pbmcgcHJlZml4IHdoaXRlc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNDcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gY2hlY2tpbmcgZm9yIHplcm8tbGVuZ3RoIHByZWZpeCB3 aGl0ZXNwYWNlLCBjb21wbGV0ZWx5IGVtcHR5IGxpbmVzIGFyZSBub3cgaWdub3JlZAorICAgICAg ICBhcyB0aGVzZSBsaW5lcyBhcmUgbW9zdCBvZnRlbiB1c2VkIGZvciBvcmdhbml6aW5nIHJ1bGVz IGludG8gZ3JvdXBzIGFuZCBvZnRlbiBoYXZlIHRoZWlyCisgICAgICAgIHdoaXRlc3BhY2UgcmVt b3ZlZCBkdWUgdG8gdHJhaWxpbmcgd2hpdGVzcGFjZSByZW1vdmFsIGNvbnZlbnRpb25zLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRv ci5qczoKKwogMjAxNC0wNy0wMSAgSm9uYXRoYW4gV2VsbHMgIDxqb25vd2VsbHNAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhleGFkZWNpbWFsIGNvbG9yIHZhbHVlcyBpbiBh bGwgQ1NTIGVkaXRvcnMgYXJlIHB1cnBsZSB3aGVuIHRoZXkgc2hvdWxkIGJlIGJsdWUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKaW5kZXggZDM1MmVj Yy4uMWYxNzQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRF ZGl0b3IuanMKQEAgLTg2OSw5ICs4NjksMTEgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFy YXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgdmFyIGxp bmVDb250ZW50ID0gdGhpcy5fY29kZU1pcnJvci5nZXRMaW5lKGkpOwogICAgICAgICAgICAgICAg ICAgICB2YXIgcHJlZml4V2hpdGVzcGFjZU1hdGNoID0gbGluZUNvbnRlbnQubWF0Y2goL15ccysv KTsKIAotICAgICAgICAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBubyBwcmVmaXggd2hpdGVz cGFjZSwgdGhlbiB0aGUgcHJlZml4IHdoaXRlc3BhY2Ugb2YgYWxsCi0gICAgICAgICAgICAgICAg ICAgIC8vIG90aGVyIGxpbmVzIHdpbGwgYmUgcmV0YWluZWQgYXMgaXMuIFVwZGF0ZSBtYXJrZXJz IGFuZCByZXR1cm4uCisgICAgICAgICAgICAgICAgICAgIC8vIElmIHRoZXJlIGlzIG5vIHByZWZp eCB3aGl0ZXNwYWNlIChleGNlcHQgZm9yIGVtcHR5IGxpbmVzKSB0aGVuIHRoZSBwcmVmaXgKKyAg ICAgICAgICAgICAgICAgICAgLy8gd2hpdGVzcGFjZSBvZiBhbGwgb3RoZXIgbGluZXMgd2lsbCBi ZSByZXRhaW5lZCBhcyBpcy4gVXBkYXRlIG1hcmtlcnMgYW5kIHJldHVybi4KICAgICAgICAgICAg ICAgICAgICAgaWYgKCFwcmVmaXhXaGl0ZXNwYWNlTWF0Y2gpIHsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGlmICghbGluZUNvbnRlbnQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u dGludWU7CiAgICAgICAgICAgICAgICAgICAgICAgICB0aGlzLl9saW5lUHJlZml4V2hpdGVzcGFj ZSA9ICIiOwogICAgICAgICAgICAgICAgICAgICAgICAgdGhpcy5fdXBkYXRlVGV4dE1hcmtlcnMo dHJ1ZSk7CiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47CkBAIC05MTIsNyArOTE0LDcg QEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZSA9 IHsKIAogICAgICAgICAgICAgICAgIHZhciBsaW5lTnVtYmVyID0gMDsKIAotICAgICAgICAgICAg ICAgIC8vIEl0ZXJhdGUgb25seSB2aXNpYmxlIHByb3BlcnRpZXMgaWYgd2UgaGF2ZSBvcmlnaW5h bCBzdHlsZSB0ZXh0LiBUaGF0IHdheSB3ZSBrbm93biB3ZSBvbmx5IHN5bnRlc2l6ZQorICAgICAg ICAgICAgICAgIC8vIEl0ZXJhdGUgb25seSB2aXNpYmxlIHByb3BlcnRpZXMgaWYgd2UgaGF2ZSBv cmlnaW5hbCBzdHlsZSB0ZXh0LiBUaGF0IHdheSB3ZSBrbm93biB3ZSBvbmx5IHN5bnRoZXNpemUK ICAgICAgICAgICAgICAgICAvLyB3aGF0IHdhcyBvcmlnaW5hbHkgaW4gdGhlIHN0eWxlIHRleHQu CiAgICAgICAgICAgICAgICAgdGhpcy5faXRlcmF0ZU92ZXJQcm9wZXJ0aWVzKHN0eWxlVGV4dCA/ IHRydWUgOiBmYWxzZSwgZnVuY3Rpb24ocHJvcGVydHkpIHsKICAgICAgICAgICAgICAgICAgICAg Ly8gU29tZSBwcm9wZXJ0eSB0ZXh0IGNhbiBoYXZlIGxpbmUgYnJlYWtzLCBzbyBjb25zaWRlciB0 aGF0IGluIHRoZSByYW5nZXMgYmVsb3cuCg==