134698 2014-07-07 15:30:52 -0700 Web Inspector: SearchResultTreeElement.representedObject is missing a saveIdentityToCookie implementation 2015-03-11 07:10:05 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1020928 0 joepeck 2014-07-07 15:30:52 -0700 Represented object types: console.assert(representedObject instanceof WebInspector.DOMSearchMatchObject || representedObject instanceof WebInspector.ResourceSearchMatchObject); Seems like we should avoid having a saved cookie for search results. 1020929 1 joepeck 2014-07-07 15:31:43 -0700 Full console log was: [Error] Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation. TreeElement.constructor: function (representedObject) { console.assert(representedObject instanceof WebInspector.DOMSearchMatchObject || representedObject instanceof WebInspector.ResourceSearchMatchObject); var title = WebInspector.SearchResultTreeElement.truncateAndHighlightTitle(representedObject.title, representedObject.searchTerm, representedObject.sourceCodeTextRange); WebInspector.GeneralTreeElement.call(this, representedObject.className, title, null, representedObject, false); this.small = true; } Meaning it was WebInspector.SearchResultTreeElement represented object types listed in the above comment. 1020930 2 webkit-bug-importer 2014-07-07 15:31:52 -0700 <rdar://problem/17581638> 1020931 3 webkit-bug-importer 2014-07-07 15:32:02 -0700 <rdar://problem/17581640> 1020944 4 joepeck 2014-07-07 15:51:57 -0700 Test comment. 1076221 5 joepeck 2015-03-10 21:51:42 -0700 * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com> 2. Shift+Cmd+F for global search "div" 3. Select any result (text result or DOM result) 5. Cmd+R Reload => error and sidebar is empty, it hasn't re-triggered the search or cleared the search 1076224 6 joepeck 2015-03-10 21:56:35 -0700 Also, the backtrace is: [Error] Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation.... saveStateToCookie (Main.js, line 4379) _updateCookieForInspectorViewState (Main.js, line 10938) _provisionalLoadStarted (Main.js, line 10853) dispatch (Main.js, line 67) dispatchEventToListeners (Main.js, line 69) startProvisionalLoad (Main.js, line 1947) _addResourceToFrame (Main.js, line 10293) _addNewResourceToFrame (Main.js, line 10288) resourceRequestWillBeSent (Main.js, line 10248) requestWillBeSent (Main.js, line 716) dispatchEvent (Main.js, line 605) _dispatchEvent (Main.js, line 583) dispatch (Main.js, line 556) dispatchNextQueuedMessageFromBackend (Main.js, line 707) 1076233 7 joepeck 2015-03-10 22:19:30 -0700 (In reply to comment #5) > * STEPS TO REPRODUCE > 1. Inspect <http://bogojoker.com> > 2. Shift+Cmd+F for global search "div" > 3. Select any result (text result or DOM result) > 4. Cmd+R Reload > => error and sidebar is empty, it hasn't re-triggered the search or Better steps here for testing is to replace step 4: 4. Close Inspector 5. Open Inspector => ensure same search tree item is selected. Now, we still should fix the scenario above for search term, but that can be handled separately. I have a fix for saveIdentityToCookie here, testable with these steps. 1076234 8 248399 joepeck 2015-03-10 22:21:15 -0700 Created attachment 248399 [PATCH] Proposed Fix 1076309 9 248399 commit-queue 2015-03-11 07:09:59 -0700 Comment on attachment 248399 [PATCH] Proposed Fix Clearing flags on attachment: 248399 Committed r181386: <http://trac.webkit.org/changeset/181386> 1076310 10 commit-queue 2015-03-11 07:10:05 -0700 All reviewed patches have been landed. Closing bug. 248399 2015-03-10 22:21:15 -0700 2015-03-11 07:09:59 -0700 [PATCH] Proposed Fix cookie.patch text/plain 5101 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlhODM2NjQuLmM0NzI2NmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTAzLTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2VhcmNo UmVzdWx0VHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgaXMgbWlzc2luZyBhIHNhdmVJZGVu dGl0eVRvQ29va2llIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ2OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHdpbGwgcmVzdG9yZSBzZWxlY3Rpb24gb2YgYSBnbG9i YWwgc2VhcmNoIHRyZWUgZWxlbWVudCBpZiB5b3UKKyAgICAgICAgY2xvc2UgYW5kIHJlb3BlbiB0 aGUgaW5zcGVjdG9yIGluIHN1Y2ggYSBjYXNlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9N b2RlbHMvRE9NU2VhcmNoTWF0Y2hPYmplY3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9N U2VhcmNoTWF0Y2hPYmplY3QucHJvdG90eXBlLmdldCByZXNvdXJjZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QudGl0bGVGb3JET01Ob2RlKToKKyAgICAgICAg Q29va2llIGhhcyB0aGUgcmVzb3VyY2UgVVJMLCBET00gTm9kZSB0aXRsZSwgYW5kIHRleHQgcmFu Z2UuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VDb2RlU2VhcmNoTWF0 Y2hPYmplY3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVNlYXJjaE1hdGNo T2JqZWN0LnByb3RvdHlwZS5nZXQgc291cmNlQ29kZVRleHRSYW5nZSk6CisgICAgICAgIENvb2tp ZSBoYXMgdGhlIHNvdXJjZSBjb2RlIFVSTCBhbmQgdGV4dCByYW5nZS4KKworMjAxNS0wMy0xMCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENTUyBwYXJzZXIgZXJyb3JzIGluIHRoZSBjb25zb2xlIHNob3VsZCBpbmNsdWRlIGNv bHVtbiBudW1iZXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTQzMTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0RPTVNlYXJjaE1hdGNoT2JqZWN0LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTVNlYXJjaE1hdGNoT2JqZWN0LmpzCmluZGV4IDZl ZTdlMDguLmUxNDcwMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9ET01TZWFyY2hNYXRjaE9iamVjdC5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NU2VhcmNoTWF0Y2hPYmplY3QuanMKQEAg LTQ0LDExICs0NCwyMiBAQCBXZWJJbnNwZWN0b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QuRE9NTWF0 Y2hEb2N1bWVudFR5cGVJY29uU3R5bGVDbGFzc05hbWUgPSAiZG9tLQogV2ViSW5zcGVjdG9yLkRP TVNlYXJjaE1hdGNoT2JqZWN0LkRPTU1hdGNoQ2hhcmFjdGVyRGF0YUljb25TdHlsZUNsYXNzTmFt ZSA9ICJkb20tbWF0Y2gtY2hhcmFjdGVyLWRhdGEtaWNvbiI7CiBXZWJJbnNwZWN0b3IuRE9NU2Vh cmNoTWF0Y2hPYmplY3QuRE9NTWF0Y2hOb2RlSWNvblN0eWxlQ2xhc3NOYW1lID0gImRvbS1tYXRj aC1ub2RlLWljb24iOwogCitXZWJJbnNwZWN0b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QuVHlwZUlk ZW50aWZpZXIgPSAiZG9tLXNlYXJjaC1tYXRjaC1vYmplY3QiOworV2ViSW5zcGVjdG9yLkRPTVNl YXJjaE1hdGNoT2JqZWN0LlVSTENvb2tpZUtleSA9ICJyZXNvdXJjZS11cmwiOworV2ViSW5zcGVj dG9yLkRPTVNlYXJjaE1hdGNoT2JqZWN0LlRpdGxlS2V5ID0gInRpdGxlIjsKK1dlYkluc3BlY3Rv ci5ET01TZWFyY2hNYXRjaE9iamVjdC5UZXh0UmFuZ2VLZXkgPSAidGV4dC1yYW5nZSI7CisKIFdl Ykluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVjdC5wcm90b3R5cGUgPSB7CiAgICAgY29uc3Ry dWN0b3I6IFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVjdCwKKyAgICBfX3Byb3RvX186 IFdlYkluc3BlY3Rvci5PYmplY3QucHJvdG90eXBlLAogCiAgICAgLy8gUHVibGljCiAKKyAgICBn ZXQgcmVzb3VyY2UoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuX3Jlc291cmNlOworICAg IH0sCisKICAgICBnZXQgZG9tTm9kZSgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fZG9t Tm9kZTsKQEAgLTc3LDkgKzg4LDE3IEBAIFdlYkluc3BlY3Rvci5ET01TZWFyY2hNYXRjaE9iamVj dC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0aGlzLl9zb3VyY2VDb2RlVGV4dFJhbmdl OwogICAgIH0sCiAKKyAgICBzYXZlSWRlbnRpdHlUb0Nvb2tpZShjb29raWUpCisgICAgeworICAg ICAgICBjb29raWVbV2ViSW5zcGVjdG9yLkRPTVNlYXJjaE1hdGNoT2JqZWN0LlVSTENvb2tpZUtl eV0gPSB0aGlzLl9yZXNvdXJjZS51cmwuaGFzaDsKKyAgICAgICAgY29va2llW1dlYkluc3BlY3Rv ci5ET01TZWFyY2hNYXRjaE9iamVjdC5UaXRsZUtleV0gPSB0aGlzLl90aXRsZTsKKyAgICAgICAg dmFyIHRleHRSYW5nZSA9IHRoaXMuX3NvdXJjZUNvZGVUZXh0UmFuZ2UudGV4dFJhbmdlOworICAg ICAgICBjb29raWVbV2ViSW5zcGVjdG9yLkRPTVNlYXJjaE1hdGNoT2JqZWN0LlRleHRSYW5nZUtl eV0gPSBbdGV4dFJhbmdlLnN0YXJ0TGluZSwgdGV4dFJhbmdlLnN0YXJ0Q29sdW1uLCB0ZXh0UmFu Z2UuZW5kTGluZSwgdGV4dFJhbmdlLmVuZENvbHVtbl0uam9pbigpOworICAgIH0sCisKICAgICAv LyBQcml2YXRlCiAKLSAgICBfZ2VuZXJhdGVDbGFzc05hbWU6IGZ1bmN0aW9uKCkKKyAgICBfZ2Vu ZXJhdGVDbGFzc05hbWUoKQogICAgIHsKICAgICAgICAgc3dpdGNoICh0aGlzLl9kb21Ob2RlLm5v ZGVUeXBlKCkpIHsKICAgICAgICAgY2FzZSBOb2RlLkVMRU1FTlRfTk9ERToKQEAgLTE1NCw1ICsx NzMsMyBAQCBXZWJJbnNwZWN0b3IuRE9NU2VhcmNoTWF0Y2hPYmplY3QudGl0bGVGb3JET01Ob2Rl ID0gZnVuY3Rpb24oZG9tTm9kZSkKICAgICAgICAgcmV0dXJuIGRvbU5vZGUubm9kZU5hbWVJbkNv cnJlY3RDYXNlKCk7CiAgICAgfQogfTsKLQotV2ViSW5zcGVjdG9yLkRPTVNlYXJjaE1hdGNoT2Jq ZWN0LnByb3RvdHlwZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0b3IuT2JqZWN0LnByb3RvdHlwZTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9T b3VyY2VDb2RlU2VhcmNoTWF0Y2hPYmplY3QuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvU291cmNlQ29kZVNlYXJjaE1hdGNoT2JqZWN0LmpzCmluZGV4IGIx ZjI3OWMuLjgzZjUzNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9Tb3VyY2VDb2RlU2VhcmNoTWF0Y2hPYmplY3QuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZUNvZGVTZWFyY2hNYXRj aE9iamVjdC5qcwpAQCAtMzcsOCArMzcsMTMgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVTZWFy Y2hNYXRjaE9iamVjdCA9IGZ1bmN0aW9uKHNvdXJjZUNvZGUsIGxpbmVUZXh0LCBzZWFyY2gKIAog V2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVTZWFyY2hNYXRjaE9iamVjdC5Tb3VyY2VDb2RlTWF0Y2hJ Y29uU3R5bGVDbGFzc05hbWUgPSAic291cmNlLWNvZGUtbWF0Y2gtaWNvbiI7CiAKK1dlYkluc3Bl Y3Rvci5Tb3VyY2VDb2RlU2VhcmNoTWF0Y2hPYmplY3QuVHlwZUlkZW50aWZpZXIgPSAic291cmNl LWNvZGUtc2VhcmNoLW1hdGNoLW9iamVjdCI7CitXZWJJbnNwZWN0b3IuU291cmNlQ29kZVNlYXJj aE1hdGNoT2JqZWN0LlVSTENvb2tpZUtleSA9ICJzb3VyY2UtY29kZS11cmwiOworV2ViSW5zcGVj dG9yLlNvdXJjZUNvZGVTZWFyY2hNYXRjaE9iamVjdC5UZXh0UmFuZ2VLZXkgPSAidGV4dC1yYW5n ZSI7CisKIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlU2VhcmNoTWF0Y2hPYmplY3QucHJvdG90eXBl ID0gewogICAgIGNvbnN0cnVjdG9yOiBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVNlYXJjaE1hdGNo T2JqZWN0LAorICAgIF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLk9iamVjdC5wcm90b3R5cGUsCiAK ICAgICBnZXQgc291cmNlQ29kZSgpCiAgICAgewpAQCAtNjMsNyArNjgsMTQgQEAgV2ViSW5zcGVj dG9yLlNvdXJjZUNvZGVTZWFyY2hNYXRjaE9iamVjdC5wcm90b3R5cGUgPSB7CiAgICAgZ2V0IHNv dXJjZUNvZGVUZXh0UmFuZ2UoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX3NvdXJjZUNv ZGVUZXh0UmFuZ2U7CisgICAgfSwKKworICAgIHNhdmVJZGVudGl0eVRvQ29va2llKGNvb2tpZSkK KyAgICB7CisgICAgICAgIGlmICh0aGlzLl9zb3VyY2VDb2RlLnVybCkKKyAgICAgICAgICAgIGNv b2tpZVtXZWJJbnNwZWN0b3IuU291cmNlQ29kZVNlYXJjaE1hdGNoT2JqZWN0LlVSTENvb2tpZUtl eV0gPSB0aGlzLl9zb3VyY2VDb2RlLnVybC5oYXNoOworCisgICAgICAgIHZhciB0ZXh0UmFuZ2Ug PSB0aGlzLl9zb3VyY2VDb2RlVGV4dFJhbmdlLnRleHRSYW5nZTsKKyAgICAgICAgY29va2llW1dl Ykluc3BlY3Rvci5Tb3VyY2VDb2RlU2VhcmNoTWF0Y2hPYmplY3QuVGV4dFJhbmdlS2V5XSA9IFt0 ZXh0UmFuZ2Uuc3RhcnRMaW5lLCB0ZXh0UmFuZ2Uuc3RhcnRDb2x1bW4sIHRleHRSYW5nZS5lbmRM aW5lLCB0ZXh0UmFuZ2UuZW5kQ29sdW1uXS5qb2luKCk7CiAgICAgfQogfTsKLQotV2ViSW5zcGVj dG9yLlNvdXJjZUNvZGVTZWFyY2hNYXRjaE9iamVjdC5wcm90b3R5cGUuX19wcm90b19fID0gV2Vi SW5zcGVjdG9yLk9iamVjdC5wcm90b3R5cGU7Cg==