134689 2014-07-07 13:07:56 -0700 Web Inspector: Uncaught Exception debugging iOS 7 NetworkAgent.loadResource is unavailable 2014-07-08 14:15:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1020880 0 joepeck 2014-07-07 13:07:56 -0700 undefined is not a function (evaluating 'NetworkAgent.loadResource(frameIdentifier,sourceMapURL,sourceMapLoaded.bind(this))') We should feature check the existence of this function in the two places it is used. 1020882 1 webkit-bug-importer 2014-07-07 13:08:12 -0700 <rdar://problem/17578914> 1020903 2 joepeck 2014-07-07 14:03:44 -0700 I'll look into this. 1020909 3 234511 joepeck 2014-07-07 14:34:22 -0700 Created attachment 234511 [PATCH] Proposed Fix 1020949 4 234511 darin 2014-07-07 16:13:05 -0700 Comment on attachment 234511 [PATCH] Proposed Fix Might be good to add a comment explaining this is needed to target older versions so it’s not just deleted later. 1020963 5 234511 commit-queue 2014-07-07 16:45:28 -0700 Comment on attachment 234511 [PATCH] Proposed Fix Clearing flags on attachment: 234511 Committed r170863: <http://trac.webkit.org/changeset/170863> 1020964 6 commit-queue 2014-07-07 16:45:30 -0700 All reviewed patches have been landed. Closing bug. 1021153 7 timothy 2014-07-08 12:17:56 -0700 We do typically add // COMPATIBILITY (iOS 7): ... comments for things like this. However, we have other places where we feature check without a comment (mainly for JSContext protocol omissions). 1021193 8 joepeck 2014-07-08 14:15:00 -0700 (In reply to comment #7) > We do typically add // COMPATIBILITY (iOS 7): ... comments for things like this. However, we have other places where we feature check without a comment (mainly for JSContext protocol omissions). Yep, that is exactly why I left it off here. We will want to fix this eventually so we get SourceMap support debugging JSContext scripts. 234511 2014-07-07 14:34:22 -0700 2014-07-07 16:45:28 -0700 [PATCH] Proposed Fix networkagent.patch text/plain 2534 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5NTQ5ZTcuLjk3YjA5OWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9uIGRlYnVnZ2luZyBpT1MgNyBOZXR3b3JrQWdlbnQubG9hZFJlc291cmNlIGlz IHVuYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQ2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBHcmFjZWZ1bGx5IGhhbmRsZSBpZiBOZXR3b3JrQWdlbnQubG9hZFJlc291cmNlIGlzIHVu YXZhaWxhYmxlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Tb3VyY2VN YXBNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZU1hcE1hbmFnZXIucHJv dG90eXBlLl9sb2FkQW5kUGFyc2VTb3VyY2VNYXApOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv TW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzOgorCiAyMDE0LTA3LTAxICBKb25hdGhhbiBXZWxs cyAgPGpvbm93ZWxsc0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSGV4YWRl Y2ltYWwgY29sb3IgdmFsdWVzIGluIGFsbCBDU1MgZWRpdG9ycyBhcmUgcHVycGxlIHdoZW4gdGhl eSBzaG91bGQgYmUgYmx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvU291cmNlTWFwTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NvdXJjZU1hcE1hbmFnZXIuanMKaW5k ZXggOGU4Nzk5Yi4uZjNkMTZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU291cmNlTWFwTWFuYWdlci5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Tb3VyY2VNYXBNYW5hZ2Vy LmpzCkBAIC0xMTYsNyArMTE2LDggQEAgV2ViSW5zcGVjdG9yLlNvdXJjZU1hcE1hbmFnZXIucHJv dG90eXBlID0gewogICAgICAgICBpZiAoIWZyYW1lSWRlbnRpZmllcikKICAgICAgICAgICAgIGZy YW1lSWRlbnRpZmllciA9IFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5tYWluRnJh bWUuaWQ7CiAKLSAgICAgICAgTmV0d29ya0FnZW50LmxvYWRSZXNvdXJjZShmcmFtZUlkZW50aWZp ZXIsIHNvdXJjZU1hcFVSTCwgc291cmNlTWFwTG9hZGVkLmJpbmQodGhpcykpOworICAgICAgICBp ZiAoTmV0d29ya0FnZW50LmxvYWRSZXNvdXJjZSkKKyAgICAgICAgICAgIE5ldHdvcmtBZ2VudC5s b2FkUmVzb3VyY2UoZnJhbWVJZGVudGlmaWVyLCBzb3VyY2VNYXBVUkwsIHNvdXJjZU1hcExvYWRl ZC5iaW5kKHRoaXMpKTsKICAgICB9LAogCiAgICAgX2xvYWRBbmRQYXJzZUZhaWxlZDogZnVuY3Rp b24oc291cmNlTWFwVVJMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzCmluZGV4IGRjYTUz NzMuLjYxY2Q3MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMKQEAgLTExNiw2ICsx MTYsMTEgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZU1hcFJlc291cmNlLnByb3RvdHlwZSA9IHsKICAg ICAgICAgICAgIGNhbGxiYWNrKG51bGwsIGJvZHksIGJhc2U2NGVuY29kZWQpOwogICAgICAgICB9 CiAKKyAgICAgICAgaWYgKCFOZXR3b3JrQWdlbnQubG9hZFJlc291cmNlKSB7CisgICAgICAgICAg ICBzb3VyY2VNYXBSZXNvdXJjZUxvYWRlZC5jYWxsKHRoaXMsICJlcnJvcjogbm8gTmV0d29ya0Fn ZW50LmxvYWRSZXNvdXJjZSIpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9 CisKICAgICAgICAgdmFyIGZyYW1lSWRlbnRpZmllciA9IG51bGw7CiAgICAgICAgIGlmICh0aGlz Ll9zb3VyY2VNYXAub3JpZ2luYWxTb3VyY2VDb2RlIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJl c291cmNlICYmIHRoaXMuX3NvdXJjZU1hcC5vcmlnaW5hbFNvdXJjZUNvZGUucGFyZW50RnJhbWUp CiAgICAgICAgICAgICBmcmFtZUlkZW50aWZpZXIgPSB0aGlzLl9zb3VyY2VNYXAub3JpZ2luYWxT b3VyY2VDb2RlLnBhcmVudEZyYW1lLmlkOwo=