134684 2014-07-07 10:21:12 -0700 ServicesOverlayController menus show up in the wrong place 2014-07-09 17:09:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 134783 1 beidson beidson bdakin commit-queue thorton oldest_to_newest 1020833 0 beidson 2014-07-07 10:21:12 -0700 ServicesOverlayController menus show up in the wrong place. This is despite the fact that they use the context menu mechanism which does display context menus in the right place. The difference is that context menu clicks undergo a hit test and have their coordinate translated to window-space. We need to do the same for Services. <rdar://problem/17130576> 1020835 1 234496 beidson 2014-07-07 10:25:25 -0700 Created attachment 234496 Patch v1 1020846 2 234496 thorton 2014-07-07 11:04:36 -0700 Comment on attachment 234496 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=234496&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:434 > +void ServicesOverlayController::handleClick(const WebCore::IntPoint& clickPoint) This seems wrong. The incoming point is always in a consistent coordinate space (though I'm not sure at the moment which one), not dependent on what frame you click on. Am I wrong and this somehow actually works in subframes? 1020860 3 beidson 2014-07-07 11:31:46 -0700 Discussed with Tim in person - This patch wasn't *wrong*, it was just more work than was needed. Simpler patch coming up, that also includes a fix for a subframe crasher that showed up in testing subframes. 1020864 4 234499 beidson 2014-07-07 11:40:09 -0700 Created attachment 234499 Patch v2 Confirmed with various main frame scroll positions, subframe scroll positions, and page zoom situations, that this patch gives the same coordinates as the hit test patch. 1020865 5 234499 thorton 2014-07-07 11:41:50 -0700 Comment on attachment 234499 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=234499&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:435 > + Page* page = m_webPage->corePage(); Please use WebPage::mainFrameView() instead of all of this. 1020866 6 beidson 2014-07-07 11:51:28 -0700 http://trac.webkit.org/changeset/170852 1021482 7 commit-queue 2014-07-09 16:57:27 -0700 Re-opened since this is blocked by bug 134783 1021485 8 beidson 2014-07-09 17:09:44 -0700 (In reply to comment #7) > Re-opened since this is blocked by bug 134783 That was just a test of webkitbot. All is well. 234496 2014-07-07 10:25:25 -0700 2014-07-07 11:40:09 -0700 Patch v1 patch text/plain 3598 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YmQ5MzgyLi42YjE4MGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDctMDcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIgbWVudXMgc2hvdyB1cCBpbiB0aGUgd3Jvbmcg cGxhY2UuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzEzMDU3Nj4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ2ODQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vy dmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVy bGF5Q29udHJvbGxlcjo6aGFuZGxlQ2xpY2spOiBUcmFuc2xhdGUgdGhlIGNsaWNrIHBvaW50IHRv IHdpbmRvdyBjb29yZGluYXRlcworICAgICAgICAgIGJ5IHBlcmZvcm1pbmcgYSBoaXQgdGVzdCBh bmQgdXNpbmcgdGhlIEZyYW1lVmlldyAoanVzdCBsaWtlIG5vcm1hbCBjb250ZXh0IG1lbnVzIGRv KQorCiAyMDE0LTA3LTA3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgW0NvY29hXSBBc3NlcnRpb24gZmFpbHVyZSBpbiBOYXZpZ2F0aW9uU3RhdGU6OkxvYWRlckNs aWVudDo6ZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZSAobmF2aWdhdGlvbklEKSB3aGVu IG5hdmlnYXRpbmcgdGhyb3VnaCB0aGUgcGFnZSBjYWNoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1t IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlD b250cm9sbGVyLm1tCmluZGV4IGI3YzFlNzQuLjJhNmMyNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3Zl cmxheUNvbnRyb2xsZXIubW0KQEAgLTM1LDcgKzM1LDEwIEBACiAjaW1wb3J0IDxXZWJDb3JlL0Zy YW1lVmlldy5oPgogI2ltcG9ydCA8V2ViQ29yZS9HYXBSZWN0cy5oPgogI2ltcG9ydCA8V2ViQ29y ZS9HcmFwaGljc0NvbnRleHQuaD4KKyNpbXBvcnQgPFdlYkNvcmUvSGl0VGVzdFJlcXVlc3QuaD4K KyNpbXBvcnQgPFdlYkNvcmUvSGl0VGVzdFJlc3VsdC5oPgogI2ltcG9ydCA8V2ViQ29yZS9NYWlu RnJhbWUuaD4KKyNpbXBvcnQgPFdlYkNvcmUvUmVuZGVyVmlldy5oPgogI2ltcG9ydCA8V2ViQ29y ZS9Tb2Z0TGlua2luZy5oPgogCiAjaWYgX19oYXNfaW5jbHVkZSg8RGF0YURldGVjdG9ycy9EREhp Z2hsaWdodERyYXdpbmcuaD4pCkBAIC00MjgsMTggKzQzMSw0NiBAQCBib29sIFNlcnZpY2VzT3Zl cmxheUNvbnRyb2xsZXI6Om1vdXNlRXZlbnQoUGFnZU92ZXJsYXkqLCBjb25zdCBXZWJNb3VzZUV2 ZW50JiBldgogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250 cm9sbGVyOjpoYW5kbGVDbGljayhjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgcG9pbnQpCit2b2lk IFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OmhhbmRsZUNsaWNrKGNvbnN0IFdlYkNvcmU6Oklu dFBvaW50JiBjbGlja1BvaW50KQogeworICAgIC8vIFRvIGNvcnJlY3RseSBtb3ZlIHRoZSBwb2lu dCB0byB3aGVyZSBpdCBzaG91bGQgYmUgZm9yIGZpbmFsIGRpc3BsYXkgb2YgdGhlIG1lbnUKKyAg ICAvLyB3ZSBkbyBhIGhpdCB0ZXN0IHRoZSBzYW1lIHdheSBub3JtYWwgY29udGV4dCBtZW51cyBk by4KKyAgICBQYWdlKiBwYWdlID0gbV93ZWJQYWdlLT5jb3JlUGFnZSgpOworICAgIGlmICghcGFn ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gcGFnZS0+bWFp bkZyYW1lKCkuZG9jdW1lbnQoKTsKKyAgICBpZiAoIWRvY3VtZW50KQorICAgICAgICByZXR1cm47 CisKKyAgICBSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gZG9jdW1lbnQtPnJlbmRlclZpZXcoKTsK KyAgICBpZiAoIXJlbmRlclZpZXcpCisgICAgICAgIHJldHVybjsKKworICAgIEhpdFRlc3RSZXF1 ZXN0IHJlcXVlc3QoSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5IHwgSGl0VGVzdFJlcXVlc3Q6OkFj dGl2ZSB8IEhpdFRlc3RSZXF1ZXN0OjpEaXNhbGxvd1NoYWRvd0NvbnRlbnQpOworICAgIEhpdFRl c3RSZXN1bHQgcmVzdWx0KGNsaWNrUG9pbnQpOworICAgIHJlbmRlclZpZXctPmhpdFRlc3QocmVx dWVzdCwgcmVzdWx0KTsKKworICAgIEZyYW1lKiBmcmFtZSA9IHJlc3VsdC5pbm5lck5vZGVGcmFt ZSgpOworICAgIGlmICghZnJhbWUpCisgICAgICAgIHJldHVybjsKKworICAgIEZyYW1lVmlldyog ZnJhbWVWaWV3ID0gZnJhbWUtPnZpZXcoKTsKKyAgICBpZiAoIWZyYW1lVmlldykKKyAgICAgICAg cmV0dXJuOworCisgICAgSW50UG9pbnQgd2luZG93UG9pbnQgPSBmcmFtZVZpZXctPmNvbnRlbnRz VG9XaW5kb3cocmVzdWx0LnJvdW5kZWRQb2ludEluSW5uZXJOb2RlRnJhbWUoKSk7CisKICAgICBp ZiAobV9kcmF3aW5nVGVsZXBob25lTnVtYmVySGlnaGxpZ2h0KSB7CiAgICAgICAgIEFTU0VSVCht X2N1cnJlbnRUZWxlcGhvbmVOdW1iZXJSYW5nZXMuc2l6ZSgpID09IDEpOwotICAgICAgICBtX3dl YlBhZ2UtPmhhbmRsZVRlbGVwaG9uZU51bWJlckNsaWNrKG1fY3VycmVudFRlbGVwaG9uZU51bWJl clJhbmdlc1swXS0+dGV4dCgpLCBwb2ludCk7CisgICAgICAgIG1fd2ViUGFnZS0+aGFuZGxlVGVs ZXBob25lTnVtYmVyQ2xpY2sobV9jdXJyZW50VGVsZXBob25lTnVtYmVyUmFuZ2VzWzBdLT50ZXh0 KCksIHdpbmRvd1BvaW50KTsKICAgICB9IGVsc2UgewogICAgICAgICBWZWN0b3I8U3RyaW5nPiBz ZWxlY3RlZFRlbGVwaG9uZU51bWJlcnM7CiAgICAgICAgIHNlbGVjdGVkVGVsZXBob25lTnVtYmVy cy5yZXNlcnZlQ2FwYWNpdHkobV9jdXJyZW50VGVsZXBob25lTnVtYmVyUmFuZ2VzLnNpemUoKSk7 CiAgICAgICAgIGZvciAoYXV0byYgcmFuZ2UgOiBtX2N1cnJlbnRUZWxlcGhvbmVOdW1iZXJSYW5n ZXMpCiAgICAgICAgICAgICBzZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMuYXBwZW5kKHJhbmdlLT50 ZXh0KCkpOwogCi0gICAgICAgIG1fd2ViUGFnZS0+aGFuZGxlU2VsZWN0aW9uU2VydmljZUNsaWNr KG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkuc2VsZWN0aW9uKCksIHNlbGVjdGVk VGVsZXBob25lTnVtYmVycywgcG9pbnQpOworICAgICAgICBtX3dlYlBhZ2UtPmhhbmRsZVNlbGVj dGlvblNlcnZpY2VDbGljayhtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnNlbGVj dGlvbigpLCBzZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMsIHdpbmRvd1BvaW50KTsKICAgICB9CiB9 CiAgICAgCg== 234499 2014-07-07 11:40:09 -0700 2014-07-07 11:41:50 -0700 Patch v2 patch text/plain 3495 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YmQ5MzgyLi4zYTNmNGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDctMDcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIgbWVudXMgc2hvdyB1cCBpbiB0aGUgd3Jvbmcg cGxhY2UuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzEzMDU3Nj4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQ2ODQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vy dmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVy bGF5Q29udHJvbGxlcjo6c2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJSYW5nZXNDaGFuZ2VkKTogSGFu ZGxlIGNhc2VzIHdoZXJlCisgICAgICAgICAgdGhlIHRlbGVwaG9uZSBudW1iZXIgaXMgaW4gYSBz dWJmcmFtZS4KKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6aGFu ZGxlQ2xpY2spOiBUaGUgY2xpY2sgcG9pbnQgaXMgYWx3YXlzIGluIG1haW4gZnJhbWUgZG9jdW1l bnQKKyAgICAgICAgICBjb29yZGluYXRlcywgc28gY29udmVydCBpdCB0byB3aW5kb3cgY29vcmRp bmF0ZXMgdXNpbmcgdGhlIG1haW4gZnJhbWXigJlzIEZyYW1lVmlldy4KKwogMjAxNC0wNy0wNyAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQXNzZXJ0 aW9uIGZhaWx1cmUgaW4gTmF2aWdhdGlvblN0YXRlOjpMb2FkZXJDbGllbnQ6OmRpZFN0YXJ0UHJv dmlzaW9uYWxMb2FkRm9yRnJhbWUgKG5hdmlnYXRpb25JRCkgd2hlbiBuYXZpZ2F0aW5nIHRocm91 Z2ggdGhlIHBhZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQppbmRl eCBiN2MxZTc0Li4xMTZkMTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1t CkBAIC0yNDIsOSArMjQyLDExIEBAIHZvaWQgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6c2Vs ZWN0ZWRUZWxlcGhvbmVOdW1iZXJSYW5nZXNDaGFuZ2VkKGNvbnN0IFZlY3RvCiAgICAgbV9kcmF3 aW5nVGVsZXBob25lTnVtYmVySGlnaGxpZ2h0ID0gZmFsc2U7CiAKICAgICBpZiAocmFuZ2VzLnNp emUoKSA9PSAxKSB7Ci0gICAgICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0aW9uUmFuZ2UgPSBtX3dl YlBhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnNlbGVjdGlvbigpLnRvTm9ybWFsaXplZFJh bmdlKCk7Ci0gICAgICAgIGlmIChyYW5nZXNbMF0tPmNvbnRhaW5zKCpzZWxlY3Rpb25SYW5nZSkp Ci0gICAgICAgICAgICBtX2RyYXdpbmdUZWxlcGhvbmVOdW1iZXJIaWdobGlnaHQgPSB0cnVlOwor ICAgICAgICBpZiAoRnJhbWUqIGZyYW1lID0gcmFuZ2VzWzBdLT5zdGFydENvbnRhaW5lcigpLT5k b2N1bWVudCgpLmZyYW1lKCkpIHsKKyAgICAgICAgICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0aW9u UmFuZ2UgPSBmcmFtZS0+c2VsZWN0aW9uKCkudG9Ob3JtYWxpemVkUmFuZ2UoKTsKKyAgICAgICAg ICAgIGlmIChyYW5nZXNbMF0tPmNvbnRhaW5zKCpzZWxlY3Rpb25SYW5nZSkpCisgICAgICAgICAg ICAgICAgbV9kcmF3aW5nVGVsZXBob25lTnVtYmVySGlnaGxpZ2h0ID0gdHJ1ZTsKKyAgICAgICAg fQogICAgIH0KICAgICAKICAgICBjcmVhdGVPdmVybGF5SWZOZWVkZWQoKTsKQEAgLTQyOCwxOCAr NDMwLDI4IEBAIGJvb2wgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6bW91c2VFdmVudChQYWdl T3ZlcmxheSosIGNvbnN0IFdlYk1vdXNlRXZlbnQmIGV2CiAgICAgcmV0dXJuIGZhbHNlOwogfQog Ci12b2lkIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OmhhbmRsZUNsaWNrKGNvbnN0IFdlYkNv cmU6OkludFBvaW50JiBwb2ludCkKK3ZvaWQgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6aGFu ZGxlQ2xpY2soY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIGNsaWNrUG9pbnQpCiB7CisgICAgUGFn ZSogcGFnZSA9IG1fd2ViUGFnZS0+Y29yZVBhZ2UoKTsKKyAgICBpZiAoIXBhZ2UpCisgICAgICAg IHJldHVybjsKKworICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gcGFnZS0+bWFpbkZyYW1lKCku dmlldygpOworICAgIGlmICghZnJhbWVWaWV3KQorICAgICAgICByZXR1cm47CisKKyAgICBJbnRQ b2ludCB3aW5kb3dQb2ludCA9IGZyYW1lVmlldy0+Y29udGVudHNUb1dpbmRvdyhjbGlja1BvaW50 KTsKKwogICAgIGlmIChtX2RyYXdpbmdUZWxlcGhvbmVOdW1iZXJIaWdobGlnaHQpIHsKICAgICAg ICAgQVNTRVJUKG1fY3VycmVudFRlbGVwaG9uZU51bWJlclJhbmdlcy5zaXplKCkgPT0gMSk7Ci0g ICAgICAgIG1fd2ViUGFnZS0+aGFuZGxlVGVsZXBob25lTnVtYmVyQ2xpY2sobV9jdXJyZW50VGVs ZXBob25lTnVtYmVyUmFuZ2VzWzBdLT50ZXh0KCksIHBvaW50KTsKKyAgICAgICAgbV93ZWJQYWdl LT5oYW5kbGVUZWxlcGhvbmVOdW1iZXJDbGljayhtX2N1cnJlbnRUZWxlcGhvbmVOdW1iZXJSYW5n ZXNbMF0tPnRleHQoKSwgd2luZG93UG9pbnQpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFZlY3Rv cjxTdHJpbmc+IHNlbGVjdGVkVGVsZXBob25lTnVtYmVyczsKICAgICAgICAgc2VsZWN0ZWRUZWxl cGhvbmVOdW1iZXJzLnJlc2VydmVDYXBhY2l0eShtX2N1cnJlbnRUZWxlcGhvbmVOdW1iZXJSYW5n ZXMuc2l6ZSgpKTsKICAgICAgICAgZm9yIChhdXRvJiByYW5nZSA6IG1fY3VycmVudFRlbGVwaG9u ZU51bWJlclJhbmdlcykKICAgICAgICAgICAgIHNlbGVjdGVkVGVsZXBob25lTnVtYmVycy5hcHBl bmQocmFuZ2UtPnRleHQoKSk7CiAKLSAgICAgICAgbV93ZWJQYWdlLT5oYW5kbGVTZWxlY3Rpb25T ZXJ2aWNlQ2xpY2sobV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS5zZWxlY3Rpb24o KSwgc2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJzLCBwb2ludCk7CisgICAgICAgIG1fd2ViUGFnZS0+ aGFuZGxlU2VsZWN0aW9uU2VydmljZUNsaWNrKG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZy YW1lKCkuc2VsZWN0aW9uKCksIHNlbGVjdGVkVGVsZXBob25lTnVtYmVycywgd2luZG93UG9pbnQp OwogICAgIH0KIH0KICAgICAK